diff --git a/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs b/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs index 24c4a60b7..00f561a87 100644 --- a/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs +++ b/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs @@ -26,13 +26,12 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Rules private AddPropertyTransform[] KeyFileTransforms => new [] { - new AddPropertyTransform("KeyOriginatorFile", + new AddPropertyTransform("AssemblyOriginatorKeyFile", compilerOptions => compilerOptions.KeyFile, compilerOptions => !string.IsNullOrEmpty(compilerOptions.KeyFile)), new AddPropertyTransform("SignAssembly", "true", - compilerOptions => !string.IsNullOrEmpty(compilerOptions.KeyFile)) - .WithMSBuildCondition(" '$(OS)' == 'Windows_NT' "), + compilerOptions => !string.IsNullOrEmpty(compilerOptions.KeyFile)), new AddPropertyTransform("PublicSign", "true", compilerOptions => !string.IsNullOrEmpty(compilerOptions.KeyFile) && (compilerOptions.PublicSign == null)) diff --git a/test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateBuildOptions.cs b/test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateBuildOptions.cs index b3cb68285..837c6c9ba 100644 --- a/test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateBuildOptions.cs +++ b/test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateBuildOptions.cs @@ -261,12 +261,11 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests } }"); - mockProj.Properties.Count(p => p.Name == "KeyOriginatorFile").Should().Be(1); - mockProj.Properties.First(p => p.Name == "KeyOriginatorFile").Value.Should().Be("../keyfile.snk"); + mockProj.Properties.Count(p => p.Name == "AssemblyOriginatorKeyFile").Should().Be(1); + mockProj.Properties.First(p => p.Name == "AssemblyOriginatorKeyFile").Value.Should().Be("../keyfile.snk"); mockProj.Properties.Count(p => p.Name == "SignAssembly").Should().Be(1); mockProj.Properties.First(p => p.Name == "SignAssembly").Value.Should().Be("true"); - mockProj.Properties.First(p => p.Name == "SignAssembly").Condition.Should().Be(" '$(OS)' == 'Windows_NT' "); mockProj.Properties.Count(p => p.Name == "PublicSign").Should().Be(1); mockProj.Properties.First(p => p.Name == "PublicSign").Value.Should().Be("true"); diff --git a/test/dotnet-migrate.Tests/GivenThatIWantToMigrateTestApps.cs b/test/dotnet-migrate.Tests/GivenThatIWantToMigrateTestApps.cs index 188e79700..ea33b3a2d 100644 --- a/test/dotnet-migrate.Tests/GivenThatIWantToMigrateTestApps.cs +++ b/test/dotnet-migrate.Tests/GivenThatIWantToMigrateTestApps.cs @@ -44,13 +44,14 @@ namespace Microsoft.DotNet.Migration.Tests VerifyAllMSBuildOutputsRunnable(projectDirectory); } - public void It_migrates_signed_apps(string projectName) + [Fact] + public void It_migrates_signed_apps() { var projectDirectory = TestAssetsManager.CreateTestInstance("TestAppWithSigning", callingMethod: "i").WithLockFiles().Path; CleanBinObj(projectDirectory); - var outputComparisonData = BuildProjectJsonMigrateBuildMSBuild(projectDirectory, projectName); + var outputComparisonData = BuildProjectJsonMigrateBuildMSBuild(projectDirectory, "TestAppWithSigning"); var outputsIdentical = outputComparisonData.ProjectJsonBuildOutputs.SetEquals(outputComparisonData.MSBuildBuildOutputs);