mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Respond to review feedback

Browse source
This commit is contained in:
Mike Lorbetske 2017-04-19 20:48:25 -07:00
parent 9ea9cbc8a6
commit 4dd1be1978
3 changed files with 0 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

12
build/compile/LzmaArchive.targets
View file

@ -78,7 +78,6 @@
<FilesToClean Include="$(NuGetPackagesArchiveProject)/**/*" /> <FilesToClean Include="$(NuGetPackagesArchiveProject)/**/*" />
<FilesToClean Include="$(NuGetPackagesArchiveFolder)/**/*" /> <FilesToClean Include="$(NuGetPackagesArchiveFolder)/**/*" />
<NuGetPackagesArchiveDirectory Include="$(NuGetPackagesArchiveProject)/Console" />
<NuGetPackagesArchiveDirectory Include="$(NuGetPackagesArchiveProject)/MvcIndividual" /> <NuGetPackagesArchiveDirectory Include="$(NuGetPackagesArchiveProject)/MvcIndividual" />
<NuGetPackagesArchiveDirectory Include="$(NuGetPackagesArchiveFolder)" /> <NuGetPackagesArchiveDirectory Include="$(NuGetPackagesArchiveFolder)" />
</ItemGroup> </ItemGroup>
@ -91,17 +90,6 @@
File="$(LZMANuGetConfigFilePath)" File="$(LZMANuGetConfigFilePath)"
Lines="$(NuGetConfigContent)" /> Lines="$(NuGetConfigContent)" />
<DotNetNew ToolPath="$(OutputDirectory)"
TemplateType="console"
TemplateArgs="--debug:ephemeral-hive --no-restore"
WorkingDirectory="$(NuGetPackagesArchiveProject)/Console" />
<DotNetRestore ToolPath="$(OutputDirectory)"
Packages="$(NuGetPackagesArchiveFolder)"
ConfigFile="$(LZMANuGetConfigFilePath)"
SkipInvalidConfigurations="True"
WorkingDirectory="$(NuGetPackagesArchiveProject)/Console" />
<DotNetNew ToolPath="$(OutputDirectory)" <DotNetNew ToolPath="$(OutputDirectory)"
TemplateType="mvc" TemplateType="mvc"
TemplateArgs="-au Individual --debug:ephemeral-hive --no-restore" TemplateArgs="-au Individual --debug:ephemeral-hive --no-restore"

1
build_projects/dotnet-cli-build/GenerateNuGetPackagesArchiveVersion.cs
View file

@ -29,7 +29,6 @@ namespace Microsoft.DotNet.Cli.Build
private static string[][] _templatesAndArgs = new string[][] private static string[][] _templatesAndArgs = new string[][]
{ {
new string[] { "console", "" },
new string[] { "mvc", "-au individual" }, new string[] { "mvc", "-au individual" },
}; };

8
test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs
View file

@ -112,17 +112,9 @@ A command is running to initially populate your local package cache, to improve
"microsoft.visualstudio.web.browserlink", "microsoft.visualstudio.web.browserlink",
}; };
List<string> unexpectedDirectories = new List<string>()
{
};
_nugetFallbackFolder _nugetFallbackFolder
.Should() .Should()
.HaveDirectories(expectedDirectories); .HaveDirectories(expectedDirectories);
_nugetFallbackFolder
.Should()
.NotHaveDirectories(unexpectedDirectories);
} }
private string GetDotnetVersion() private string GetDotnetVersion()