mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #9371 from svick/patch-4

Browse source 
Simplified combining dictionaries in Telemetry
This commit is contained in:
William Li 2018-06-04 13:43:13 -07:00 • committed by GitHub
commit 48ee97fb42
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/dotnet/Telemetry/Telemetry.cs
View file

@ -141,14 +141,7 @@ namespace Microsoft.DotNet.Cli.Telemetry
{ {
foreach (KeyValuePair<string, double> measurement in measurements) foreach (KeyValuePair<string, double> measurement in measurements)
{ {
if (eventMeasurements.ContainsKey(measurement.Key)) eventMeasurements[measurement.Key] = measurement.Value;
{
eventMeasurements[measurement.Key] = measurement.Value;
}
else
{
eventMeasurements.Add(measurement.Key, measurement.Value);
}
} }
} }
return eventMeasurements; return eventMeasurements;
@ -161,14 +154,7 @@ namespace Microsoft.DotNet.Cli.Telemetry
var eventProperties = new Dictionary<string, string>(_commonProperties); var eventProperties = new Dictionary<string, string>(_commonProperties);
foreach (KeyValuePair<string, string> property in properties) foreach (KeyValuePair<string, string> property in properties)
{ {
if (eventProperties.ContainsKey(property.Key)) eventProperties[property.Key] = property.Value;
{
eventProperties[property.Key] = property.Value;
}
else
{
eventProperties.Add(property.Key, property.Value);
}
} }
return eventProperties; return eventProperties;
} }