mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Updating script migration to use the correct BeforeTargets. (#4680)

Browse source
This commit is contained in:
Livar 2016-11-10 18:24:35 -08:00 committed by Piotr Puszkiewicz
parent b354e1a3c6
commit 43dfa6b8ba
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateScriptsRule.cs
View file

@ -115,9 +115,9 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Rules
// ProjectJson Script Set Name to // ProjectJson Script Set Name to
private static Dictionary<string, TargetHookInfo> ScriptSetToMSBuildHookTargetMap => new Dictionary<string, TargetHookInfo>() private static Dictionary<string, TargetHookInfo> ScriptSetToMSBuildHookTargetMap => new Dictionary<string, TargetHookInfo>()
{ {
{ "precompile", new TargetHookInfo(true, "Build") }, { "precompile", new TargetHookInfo(true, "BeforeBuild") },
{ "postcompile", new TargetHookInfo(false, "Build") }, { "postcompile", new TargetHookInfo(false, "Build") },
{ "prepublish", new TargetHookInfo(true, "Publish") }, { "prepublish", new TargetHookInfo(true, "PrepareForPublish") },
{ "postpublish", new TargetHookInfo(false, "Publish") } { "postpublish", new TargetHookInfo(false, "Publish") }
}; };

4
test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateScripts.cs
View file

@ -53,8 +53,8 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
} }
[Theory] [Theory]
[InlineData("precompile", "Build")] [InlineData("precompile", "BeforeBuild")]
[InlineData("prepublish", "Publish")] [InlineData("prepublish", "PrepareForPublish")]
public void Migrating_pre_scripts_populates_BeforeTargets_with_appropriate_target(string scriptName, string targetName) public void Migrating_pre_scripts_populates_BeforeTargets_with_appropriate_target(string scriptName, string targetName)
{ {
var scriptMigrationRule = new MigrateScriptsRule(); var scriptMigrationRule = new MigrateScriptsRule();