From 0368ac38f70bc36f2b1439ece97c2e93314f5274 Mon Sep 17 00:00:00 2001
From: Matt Mitchell <mmitche@microsoft.com>
Date: Wed, 7 Feb 2024 08:05:52 -0800
Subject: [PATCH 1/6] Download artifacts in parallel (#18549)

---
 src/redist/targets/BundledDotnetTools.targets |  5 +----
 src/redist/targets/Crossgen.targets           |  5 +----
 src/redist/targets/GenerateLayout.targets     | 10 ++--------
 test/SdkTests/SdkTests.csproj                 |  7 ++-----
 4 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/src/redist/targets/BundledDotnetTools.targets b/src/redist/targets/BundledDotnetTools.targets
index ab3b5e34a..75bb0e213 100644
--- a/src/redist/targets/BundledDotnetTools.targets
+++ b/src/redist/targets/BundledDotnetTools.targets
@@ -28,10 +28,7 @@
       </BundledToolLayoutProject>
     </ItemGroup>
 
-    <MSBuild
-        BuildInParallel="False"
-        Projects="@(BundledToolLayoutProject)">
-    </MSBuild>
+    <MSBuild Projects="@(BundledToolLayoutProject)" />
   </Target>
 
 </Project>
diff --git a/src/redist/targets/Crossgen.targets b/src/redist/targets/Crossgen.targets
index 076a28be9..4121ddb9c 100644
--- a/src/redist/targets/Crossgen.targets
+++ b/src/redist/targets/Crossgen.targets
@@ -26,10 +26,7 @@
       </CrossGenDownloadPackageProject>
     </ItemGroup>
 
-    <MSBuild
-      BuildInParallel="False"
-      Projects="@(CrossGenDownloadPackageProject)">
-    </MSBuild>
+    <MSBuild Projects="@(CrossGenDownloadPackageProject)" />
 
     <!-- This PropertyGroup contains the paths to the various SDK tooling that should be
          cross-genned. This tooling multi-targets, and we only want to cross-gen the .NET Core
diff --git a/src/redist/targets/GenerateLayout.targets b/src/redist/targets/GenerateLayout.targets
index 14708e432..8ef9e81b7 100644
--- a/src/redist/targets/GenerateLayout.targets
+++ b/src/redist/targets/GenerateLayout.targets
@@ -409,10 +409,7 @@
       </BundledLayoutPackageDownloadProject>
     </ItemGroup>
 
-    <MSBuild
-      BuildInParallel="False"
-      Projects="@(BundledLayoutPackageDownloadProject)">
-    </MSBuild>
+    <MSBuild Projects="@(BundledLayoutPackageDownloadProject)" />
 
     <ItemGroup>
       <!-- Use lowercase package name in package path -->
@@ -534,10 +531,7 @@
       </AppHostTemplateDownloadPackageProject>
     </ItemGroup>
 
-    <MSBuild
-      BuildInParallel="False"
-      Projects="@(AppHostTemplateDownloadPackageProject)">
-    </MSBuild>
+    <MSBuild Projects="@(AppHostTemplateDownloadPackageProject)" />
 
     <PropertyGroup>
       <AppHostExecutableName>AppHost$(ExeExtension)</AppHostExecutableName>
diff --git a/test/SdkTests/SdkTests.csproj b/test/SdkTests/SdkTests.csproj
index 5cf2f0c56..058f4cf7a 100644
--- a/test/SdkTests/SdkTests.csproj
+++ b/test/SdkTests/SdkTests.csproj
@@ -82,8 +82,7 @@
 
     <MSBuild Projects="$(MSBuildProjectFullPath)"
          Targets="InstallRuntimeToLayout"
-         Properties="RuntimeVersionToInstall=%(RuntimeVersionToInstall.Identity)"
-         BuildInParallel="false"/>
+         Properties="RuntimeVersionToInstall=%(RuntimeVersionToInstall.Identity)" />
   </Target>
 
   <Target Name="InstallRuntimeToLayout">
@@ -155,9 +154,7 @@
     </ItemGroup>
     
     <MSBuild Projects="@(TestProjectToRun)"
-             Targets="RunTestsAsTool"
-             BuildInParallel="true"
-             />
+             Targets="RunTestsAsTool" />
   </Target>
   
   <Target Name="RunTestsAsTool">

From 2c49b202647cf470452890c7c8793d2ea1b0b1df Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Wed, 7 Feb 2024 17:27:55 +0100
Subject: [PATCH 2/6] Change the package cache dir to repo-root/.packages
 (#18550)

---
 src/SourceBuild/content/.gitignore            | 6 ++----
 src/SourceBuild/content/Directory.Build.props | 2 +-
 src/SourceBuild/content/build.sh              | 4 ++--
 src/SourceBuild/content/eng/build.ps1         | 2 +-
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/SourceBuild/content/.gitignore b/src/SourceBuild/content/.gitignore
index 2bcbb63f3..e88b2a3e8 100644
--- a/src/SourceBuild/content/.gitignore
+++ b/src/SourceBuild/content/.gitignore
@@ -1,11 +1,9 @@
 /.dotnet
+/.packages
 /artifacts
-/eng/tools/**/bin
-/eng/tools/**/obj
 /prereqs/packages
-/src/linker/src/ILLink.Tasks/ILLink.Tasks.nuspec
 /src/nuget-client/NuGet.config
 /test/Microsoft.DotNet.SourceBuild.SmokeTests/bin
 /test/Microsoft.DotNet.SourceBuild.SmokeTests/obj
 /test/Microsoft.DotNet.SourceBuild.SmokeTests/TestResults
-*.binlog
\ No newline at end of file
+*.binlog
diff --git a/src/SourceBuild/content/Directory.Build.props b/src/SourceBuild/content/Directory.Build.props
index 2ab3da9ec..91df19fb2 100644
--- a/src/SourceBuild/content/Directory.Build.props
+++ b/src/SourceBuild/content/Directory.Build.props
@@ -148,7 +148,7 @@
     <KeysDir>$([MSBuild]::NormalizeDirectory('$(PrereqsDir)', 'keys'))</KeysDir>
     <PrereqsPackagesDir>$([MSBuild]::NormalizeDirectory('$(PrereqsDir)', 'packages'))</PrereqsPackagesDir>
 
-    <!-- When SB mode, the initial arcade is unzipped to a the "ArcadeBootStrap" dir.
+    <!-- When SB mode, the initial arcade is unzipped to the "ArcadeBootstrapPackage" dir.
          When running in VBPOC, the bootstrap package is the arcade restored at the beginning of the build. -->
     <ArcadeBootstrapPackageDir Condition="'$(DotNetBuildSourceOnly)' == 'true'">$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'ArcadeBootstrapPackage'))</ArcadeBootstrapPackageDir>
     <ArcadeBootstrapPackageDir Condition="'$(DotNetBuildSourceOnly)' != 'true'">$(NuGetPackageRoot)</ArcadeBootstrapPackageDir>
diff --git a/src/SourceBuild/content/build.sh b/src/SourceBuild/content/build.sh
index ab9c9170d..751f9a188 100755
--- a/src/SourceBuild/content/build.sh
+++ b/src/SourceBuild/content/build.sh
@@ -57,8 +57,7 @@ scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
 
 # Set the NUGET_PACKAGES dir so that we don't accidentally pull some packages from the global location,
 # They should be pulled from the local feeds.
-packagesDir="$scriptroot/prereqs/packages/"
-packagesRestoredDir="${packagesDir}restored/"
+packagesRestoredDir="$scriptroot/.packages/"
 export NUGET_PACKAGES=$packagesRestoredDir/
 
 # Common settings
@@ -77,6 +76,7 @@ sourceRepository=''
 sourceVersion=''
 CUSTOM_PACKAGES_DIR=''
 CUSTOM_SDK_DIR=''
+packagesDir="$scriptroot/prereqs/packages/"
 packagesArchiveDir="${packagesDir}archive/"
 packagesPreviouslySourceBuiltDir="${packagesDir}previously-source-built/"
 
diff --git a/src/SourceBuild/content/eng/build.ps1 b/src/SourceBuild/content/eng/build.ps1
index 35a494aa5..c13ce050a 100644
--- a/src/SourceBuild/content/eng/build.ps1
+++ b/src/SourceBuild/content/eng/build.ps1
@@ -41,7 +41,7 @@ function Get-Usage() {
 
 # Set the NUGET_PACKAGES dir so that we don't accidentally pull some packages from the global location,
 # They should be pulled from the local feeds.
-$env:NUGET_PACKAGES="$RepoRoot\prereqs\packages\restored\"
+$env:NUGET_PACKAGES="$RepoRoot\.packages\"
 
 if ($help) {
   Get-Usage

From d67876b1265271c6edb8593aa6fada5dbca037c6 Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Wed, 7 Feb 2024 17:54:43 +0100
Subject: [PATCH 3/6] Update vmr-build.yml (#18553)

---
 eng/pipelines/vmr-build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/pipelines/vmr-build.yml b/eng/pipelines/vmr-build.yml
index 15cc40fc4..45733f9d2 100644
--- a/eng/pipelines/vmr-build.yml
+++ b/eng/pipelines/vmr-build.yml
@@ -3,7 +3,7 @@
 # - installer-source-build (public)
 #   - PR: release/* and main, ultralite build
 # - installer-unified-build (public)
-#   - PR: release/* and main, lite build
+#   - PR: main, lite build
 
 trigger: none
 pr:

From 540504fb32093192941ff6a52da649c5006c66fa Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Wed, 7 Feb 2024 17:58:02 +0100
Subject: [PATCH 4/6] =?UTF-8?q?Enable=20target=20that=20copies=20binaries?=
 =?UTF-8?q?=20to=20final=20location=20for=20non=20source-b=E2=80=A6=20(#18?=
 =?UTF-8?q?552)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/SourceBuild/content/build.proj                | 15 +++++++++++++++
 .../content/eng/build.sourcebuild.targets         | 14 --------------
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/src/SourceBuild/content/build.proj b/src/SourceBuild/content/build.proj
index 04f6a25b6..10aa956ce 100644
--- a/src/SourceBuild/content/build.proj
+++ b/src/SourceBuild/content/build.proj
@@ -19,6 +19,21 @@
              StopOnFirstFailure="true" />
   </Target>
 
+  <!-- Copies the output assets of the builds to the output path. -->
+  <Target Name="CopyBinariesToBinFolder"
+          AfterTargets="Build">
+    <ItemGroup>
+      <BinaryToCopy Include="$(SourceBuiltAssetsDir)*.*"
+                    Exclude="$(SourceBuiltAssetsDir)*.nupkg;
+                             $(SourceBuiltAssetsDir)*.requires_nupkg_signing" />
+    </ItemGroup>
+
+    <Copy SourceFiles="@(BinaryToCopy)"
+          DestinationFolder="$(SharedOutputPath)"
+          SkipUnchangedFiles="true"
+          Condition="'@(BinaryToCopy)'!=''" />
+  </Target>
+
   <Import Project="$(RepositoryEngineeringDir)build.sourcebuild.targets" Condition="'$(DotNetBuildSourceOnly)' == 'true'" />
 
 </Project>
diff --git a/src/SourceBuild/content/eng/build.sourcebuild.targets b/src/SourceBuild/content/eng/build.sourcebuild.targets
index 89c9db476..b9786179f 100644
--- a/src/SourceBuild/content/eng/build.sourcebuild.targets
+++ b/src/SourceBuild/content/eng/build.sourcebuild.targets
@@ -9,20 +9,6 @@
     <PoisonUsageReportFile>$(PackageReportDir)poison-usage.xml</PoisonUsageReportFile>
   </PropertyGroup>
 
-  <!-- Copies the output assets of the builds to the output path. -->
-  <Target Name="CopyBinariesToBinFolder"
-          AfterTargets="Build">
-    <ItemGroup>
-      <BinariesToCopy Include="$(SourceBuiltAssetsDir)*.*"
-                      Exclude="$(SourceBuiltAssetsDir)*.nupkg;$(SourceBuiltAssetsDir)*.requires_nupkg_signing" />
-    </ItemGroup>
-
-    <Copy SourceFiles="@(BinariesToCopy)"
-          DestinationFolder="$(SharedOutputPath)"
-          SkipUnchangedFiles="true"
-          Condition="'@(BinariesToCopy)'!=''" />
-  </Target>
-
   <!-- After building, generate a prebuilt usage report. -->
   <Target Name="ReportPrebuiltUsage"
           AfterTargets="Build"

From ee9a93b4cc6f99b9a1f6a97a35d8e7dbe92681bc Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Wed, 7 Feb 2024 18:44:09 +0100
Subject: [PATCH 5/6] Follow-up on CopyRepoArtifacts directly in the VMR
 (#18551)

---
 .../repo-projects/Directory.Build.targets     | 80 +------------------
 1 file changed, 3 insertions(+), 77 deletions(-)

diff --git a/src/SourceBuild/content/repo-projects/Directory.Build.targets b/src/SourceBuild/content/repo-projects/Directory.Build.targets
index a06ced3c0..9165e7da1 100644
--- a/src/SourceBuild/content/repo-projects/Directory.Build.targets
+++ b/src/SourceBuild/content/repo-projects/Directory.Build.targets
@@ -345,18 +345,13 @@
     </ItemGroup>
   </Target>
 
-  <!--
-    Condition should be removed after source-build picks up version of Arcade that has
-    source-build infra changes for removal od inner-clone in VMR build. Until then some
-    repos will produce intermediate packages instead of repo manifest file.
-
-    https://github.com/dotnet/source-build/issues/3930
-  -->
   <Target Name="CopyRepoArtifacts"
           AfterTargets="Package"
-          Condition="Exists($(RepoManifestFile))"
+          Condition="'$(IsUtilityProject)' != 'true'"
           Inputs="$(RepoManifestFile)"
           Outputs="$(BaseIntermediateOutputPath)ArtifactsCopy.complete">
+    <Error Text="Repo manifest file doesn't exist." Condition="!Exists('$(RepoManifestFile)')" />
+
     <XmlPeek XmlInputPath="$(RepoManifestFile)"
              Query="Build/Artifact/@Path">
         <Output TaskParameter="Result" ItemName="RepoManifestArtifact" />
@@ -408,75 +403,6 @@
     </Touch>
   </Target>
 
-  <!--
-    This target can be removed after source-build picks up version of Arcade that has
-    source-build infra changes for removal od inner-clone in VMR build. Until then the target
-    is needed for building source-build-reference-packages and arcade repos.
-
-    https://github.com/dotnet/source-build/issues/3930
-  -->
-  <Target Name="ExtractIntermediatePackages"
-          AfterTargets="Package"
-          Inputs="$(MSBuildProjectFullPath)"
-          Outputs="$(BaseIntermediateOutputPath)IntermediateExtraction.complete">
-    <ItemGroup>
-      <_BuiltIntermediatePackages Condition="'$(PackagesOutput)' != ''" Include="$(PackagesOutput)/Microsoft.SourceBuild.Intermediate.*.nupkg" Exclude="$(PackagesOutput)/*.symbols.nupkg"/>
-      <_BuiltIntermediatePackages Condition="'@(PackagesOutputList)' != ''" Include="%(PackagesOutputList.Identity)/Microsoft.SourceBuild.Intermediate.*.nupkg" Exclude="%(PackagesOutputList.Identity)/*.symbols.nupkg"/>
-    </ItemGroup>
-
-    <PropertyGroup Condition="'@(_BuiltIntermediatePackages)' != ''">
-      <_NupkgDestinationPath>$(SourceBuiltPackagesPath)</_NupkgDestinationPath>
-      <!-- SBRP packages unpack into the Reference packages directory instead of into blob-feed packages -->
-      <_NupkgDestinationPath Condition="$([System.String]::Copy(%(_BuiltIntermediatePackages.Identity)).Contains('source-build-reference-packages'))">$(ReferencePackagesDir)</_NupkgDestinationPath>
-    </PropertyGroup>
-
-    <Unzip SourceFiles="@(_BuiltIntermediatePackages)"
-           DestinationFolder="$(SourceBuiltPackagesPath)extractArtifacts/%(_BuiltIntermediatePackages.FileName)/"
-           SkipUnchangedFiles="true"
-           Condition="'@(_BuiltIntermediatePackages)' != ''" />
-
-    <ItemGroup Condition="'@(_BuiltIntermediatePackages)' != ''">
-      <SourceBuiltNupkgFiles Include="$(SourceBuiltPackagesPath)extractArtifacts/**/artifacts/*.nupkg" />
-    </ItemGroup>
-
-    <ItemGroup Condition="'@(_BuiltIntermediatePackages)' != ''">
-      <NonShippingPackageLists Include="$(SourceBuiltPackagesPath)extractArtifacts/**/$(NonShippingPackagesListPrefix)*" />
-    </ItemGroup>
-
-    <!-- Copy lists of NonShipping packages to prebuilt-report dir -->
-    <Copy SourceFiles="@(NonShippingPackageLists)" DestinationFolder="$(PackageListsDir)" />
-
-    <!-- Building SBRP: At this point the References directory contains the previously-source-built SBRPs,
-         clear it before moving the current SBRPs.  This ensures n-1 SBRPs aren't required to build the product repos. -->
-    <RemoveDir
-      Condition="'$(_NupkgDestinationPath)' == '$(ReferencePackagesDir)'"
-      Directories="$(ReferencePackagesDir)" />
-
-    <Move
-      Condition="'@(SourceBuiltNupkgFiles)' != ''"
-      SourceFiles="@(SourceBuiltNupkgFiles)"
-      DestinationFiles="@(SourceBuiltNupkgFiles -> '$(_NupkgDestinationPath)%(Filename)%(Extension)')" />
-
-    <ItemGroup Condition="'@(_BuiltIntermediatePackages)' != ''">
-      <SourceBuiltAssetFiles Include="$(SourceBuiltPackagesPath)extractArtifacts/**/artifacts/*.*" />
-      <SourceBuiltAssetFiles Remove="$(SourceBuiltPackagesPath)extractArtifacts/**/artifacts/*.nupkg" />
-    </ItemGroup>
-
-    <Move
-      Condition="'@(SourceBuiltAssetFiles)' != ''"
-      SourceFiles="@(SourceBuiltAssetFiles)"
-      DestinationFiles="@(SourceBuiltAssetFiles -> '$(SourceBuiltAssetsDir)%(Filename)%(Extension)')" />
-
-    <RemoveDir
-      Condition="Exists('$(SourceBuiltPackagesPath)extractArtifacts/')"
-      Directories="$(SourceBuiltPackagesPath)extractArtifacts/" />
-
-    <MakeDir Directories="$(BaseIntermediateOutputPath)" />
-    <Touch Files="$(BaseIntermediateOutputPath)IntermediateExtraction.complete" AlwaysCreate="true">
-      <Output TaskParameter="TouchedFiles" ItemName="FileWrites" />
-    </Touch>
-  </Target>
-
   <!-- Copy restored packages from inner build to ensure they're included in the
        main build prebuilt check -->
   <Target Name="CopyInnerBuildRestoredPackages"

From 43f55219364ffb6402e628571cf854e76040f403 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= <alex.koeplinger@outlook.com>
Date: Wed, 7 Feb 2024 18:55:54 +0100
Subject: [PATCH 6/6] Use arm64 Mac pool for internal VMR build (#18554)

---
 eng/pipelines/templates/variables/vmr-stage.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/eng/pipelines/templates/variables/vmr-stage.yml b/eng/pipelines/templates/variables/vmr-stage.yml
index 7363922bc..4d906db13 100644
--- a/eng/pipelines/templates/variables/vmr-stage.yml
+++ b/eng/pipelines/templates/variables/vmr-stage.yml
@@ -32,6 +32,8 @@ variables:
     value: NetCore-Public-XL
   - name: defaultPoolNameLinuxArm64
     value: Docker-Linux-Arm-Public
+  - name: defaultPoolNameMac
+    value: macos-12
   - name: defaultPoolDemandsLinux
     value: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open
   - name: defaultPoolDemandsWindows
@@ -45,10 +47,9 @@ variables:
       value: NetCore1ESPool-Svc-Internal
   - name: defaultPoolNameLinuxArm64
     value: Docker-Linux-Arm-Internal
+  - name: defaultPoolNameMac
+    value: macos-13-arm64
   - name: defaultPoolDemandsLinux
     value: ImageOverride -equals Build.Ubuntu.1804.Amd64
   - name: defaultPoolDemandsWindows
     value: ImageOverride -equals windows.vs2022.amd64
-
-- name: defaultPoolNameMac
-  value: macos-12