Step one of introducing a flag to drop the suffix out of our build versions.
This commit is contained in:
parent
eebd77efe3
commit
35fc8c1d0e
10 changed files with 31 additions and 58 deletions
|
@ -115,7 +115,7 @@
|
||||||
<DotNetPublish ToolPath="%(Stage.DotnetDir)"
|
<DotNetPublish ToolPath="%(Stage.DotnetDir)"
|
||||||
Output="$(SdkOutputDirectory)"
|
Output="$(SdkOutputDirectory)"
|
||||||
Configuration="$(Configuration)"
|
Configuration="$(Configuration)"
|
||||||
VersionSuffix="rc4-$(CommitCount)"
|
VersionSuffix="$(VersionSuffix)"
|
||||||
ProjectPath="$(SrcDirectory)/redist/redist.csproj"
|
ProjectPath="$(SrcDirectory)/redist/redist.csproj"
|
||||||
MSBuildArgs="/p:GenerateRuntimeConfigurationFiles=true" />
|
MSBuildArgs="/p:GenerateRuntimeConfigurationFiles=true" />
|
||||||
|
|
||||||
|
@ -123,7 +123,7 @@
|
||||||
<DotNetPublish ToolPath="%(Stage.DotnetDir)"
|
<DotNetPublish ToolPath="%(Stage.DotnetDir)"
|
||||||
Output="$(SdkOutputDirectory)/Roslyn"
|
Output="$(SdkOutputDirectory)/Roslyn"
|
||||||
Configuration="$(Configuration)"
|
Configuration="$(Configuration)"
|
||||||
VersionSuffix="rc4-$(CommitCount)"
|
VersionSuffix="$(VersionSuffix)"
|
||||||
ProjectPath="$(SrcDirectory)/tool_roslyn/tool_roslyn.csproj" />
|
ProjectPath="$(SrcDirectory)/tool_roslyn/tool_roslyn.csproj" />
|
||||||
|
|
||||||
<!-- Corehostify Binaries -->
|
<!-- Corehostify Binaries -->
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
<?xml version="1.0" encoding="utf-8"?>
|
<?xml version="1.0" encoding="utf-8"?>
|
||||||
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
|
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<SdkBrandName>Microsoft .NET Core 1.0.3 - SDK RC 4</SdkBrandName>
|
<SdkBrandName>Microsoft .NET Core 1.0.3 - SDK</SdkBrandName>
|
||||||
<SharedFrameworkBrandName>Microsoft .NET Core 1.0.3 - Runtime</SharedFrameworkBrandName>
|
<SharedFrameworkBrandName>Microsoft .NET Core 1.0.3 - Runtime</SharedFrameworkBrandName>
|
||||||
<SharedHostBrandName>Microsoft .NET Core 1.1.0 - Host</SharedHostBrandName>
|
<SharedHostBrandName>Microsoft .NET Core 1.1.0 - Host</SharedHostBrandName>
|
||||||
<HostFxrBrandName>Microsoft .NET Core 1.1.0 - Host FX Resolver</HostFxrBrandName>
|
<HostFxrBrandName>Microsoft .NET Core 1.1.0 - Host FX Resolver</HostFxrBrandName>
|
||||||
|
|
|
@ -68,16 +68,18 @@
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<CommitCount Condition=" '$(CommitCount)' == '' ">$(DefaultCommitCount)</CommitCount>
|
<CommitCount Condition=" '$(CommitCount)' == '' ">$(DefaultCommitCount)</CommitCount>
|
||||||
|
|
||||||
<SimpleVersion>$(VersionMajor).$(VersionMinor).$(VersionPatch).$(CommitCount)</SimpleVersion>
|
<SimpleVersion Condition=" '$(DropSuffix)' == '' ">$(VersionMajor).$(VersionMinor).$(VersionPatch).$(CommitCount)</SimpleVersion>
|
||||||
<VersionSuffix>$(ReleaseSuffix)-$(CommitCount)</VersionSuffix>
|
<SimpleVersion Condition=" '$(SimpleVersion)' == '' ">$(VersionMajor).$(VersionMinor).$(VersionPatch)</SimpleVersion>
|
||||||
<NugetVersion>$(VersionMajor).$(VersionMinor).$(VersionPatch)-$(VersionSuffix)</NugetVersion>
|
|
||||||
|
<VersionSuffix Condition=" '$(DropSuffix)' == '' ">$(ReleaseSuffix)-$(CommitCount)</VersionSuffix>
|
||||||
|
|
||||||
|
<NugetVersion Condition=" '$(DropSuffix)' == '' ">$(VersionMajor).$(VersionMinor).$(VersionPatch)-$(VersionSuffix)</NugetVersion>
|
||||||
|
<NugetVersion Condition=" '$(NugetVersion)' == '' ">$(VersionMajor).$(VersionMinor).$(VersionPatch)</NugetVersion>
|
||||||
|
|
||||||
|
<SdkVersion>$(NugetVersion)</SdkVersion>
|
||||||
|
<SdkNugetVersion>$(NugetVersion)</SdkNugetVersion>
|
||||||
|
|
||||||
<VersionBadge>$(BaseOutputDirectory)/$(VersionBadgeMoniker)_$(Configuration)_version_badge.svg</VersionBadge>
|
<VersionBadge>$(BaseOutputDirectory)/$(VersionBadgeMoniker)_$(Configuration)_version_badge.svg</VersionBadge>
|
||||||
<SdkVersion>$(NugetVersion)</SdkVersion>
|
|
||||||
|
|
||||||
<SdkNugetVersion>$(VersionMajor).$(VersionMinor).$(VersionPatch)-rc4-$(CommitCount)</SdkNugetVersion>
|
|
||||||
<ProjectModelNugetVersion>$(VersionMajor).$(VersionMinor).$(VersionPatch)-rc4-$(CommitCount)</ProjectModelNugetVersion>
|
|
||||||
<DependencyModelAndInternalAbstractionsNugetVersion>$(VersionMajor).$(VersionMinor).1-beta-$(CommitCount)</DependencyModelAndInternalAbstractionsNugetVersion>
|
|
||||||
|
|
||||||
<ArchiveExtension Condition=" '$(OSName)' == 'win' ">.zip</ArchiveExtension>
|
<ArchiveExtension Condition=" '$(OSName)' == 'win' ">.zip</ArchiveExtension>
|
||||||
<ArchiveExtension Condition=" '$(OSName)' != 'win' ">.tar.gz</ArchiveExtension>
|
<ArchiveExtension Condition=" '$(OSName)' != 'win' ">.tar.gz</ArchiveExtension>
|
||||||
|
|
|
@ -59,7 +59,6 @@
|
||||||
DependsOnTargets="Init;
|
DependsOnTargets="Init;
|
||||||
SetupTestProjectData">
|
SetupTestProjectData">
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<TestPackageBuildVersionSuffix>$(CommitCount)</TestPackageBuildVersionSuffix>
|
|
||||||
<TestOutputDir>$(RepoRoot)/artifacts/testpackages/</TestOutputDir>
|
<TestOutputDir>$(RepoRoot)/artifacts/testpackages/</TestOutputDir>
|
||||||
<TestPackagesBuildDir>$(TestOutputDir)/packagesBuild/</TestPackagesBuildDir>
|
<TestPackagesBuildDir>$(TestOutputDir)/packagesBuild/</TestPackagesBuildDir>
|
||||||
<TestPackagesDir>$(TestOutputDir)/packages/</TestPackagesDir>
|
<TestPackagesDir>$(TestOutputDir)/packages/</TestPackagesDir>
|
||||||
|
|
|
@ -4,7 +4,6 @@
|
||||||
<Target Name="SetupProjectsToPack"
|
<Target Name="SetupProjectsToPack"
|
||||||
DependsOnTargets="Init">
|
DependsOnTargets="Init">
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<NupkgVersionSuffix>$(CommitCount)</NupkgVersionSuffix>
|
|
||||||
<ProjectsSrcDirectory>$(RepoRoot)/src</ProjectsSrcDirectory>
|
<ProjectsSrcDirectory>$(RepoRoot)/src</ProjectsSrcDirectory>
|
||||||
<PackagingBuildBasePath>$(Stage2CompilationDirectory)/forPackaging</PackagingBuildBasePath>
|
<PackagingBuildBasePath>$(Stage2CompilationDirectory)/forPackaging</PackagingBuildBasePath>
|
||||||
<NupkgOutputDirectory>$(PackagesDirectory)</NupkgOutputDirectory>
|
<NupkgOutputDirectory>$(PackagesDirectory)</NupkgOutputDirectory>
|
||||||
|
@ -26,7 +25,7 @@
|
||||||
Output="$(NupkgOutputDirectory)"
|
Output="$(NupkgOutputDirectory)"
|
||||||
ProjectPath="%(ProjectsToPack.Identity)/%(ProjectsToPack.ProjectName).csproj"
|
ProjectPath="%(ProjectsToPack.Identity)/%(ProjectsToPack.ProjectName).csproj"
|
||||||
ToolPath="$(Stage0Directory)"
|
ToolPath="$(Stage0Directory)"
|
||||||
VersionSuffix="rc4-$(NupkgVersionSuffix)"
|
VersionSuffix="$(VersionSuffix)"
|
||||||
Configuration="$(Configuration)" />
|
Configuration="$(Configuration)" />
|
||||||
</Target>
|
</Target>
|
||||||
|
|
||||||
|
|
|
@ -22,8 +22,8 @@
|
||||||
<ProjectName>Microsoft.DotNet.Cli.Utils.csproj</ProjectName>
|
<ProjectName>Microsoft.DotNet.Cli.Utils.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>$(CliVersionPrefix)-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc4-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>False</Clean>
|
<Clean>False</Clean>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
<BaseTestPackageProject Include="src/Microsoft.DotNet.Cli.Utils"
|
<BaseTestPackageProject Include="src/Microsoft.DotNet.Cli.Utils"
|
||||||
|
@ -32,8 +32,8 @@
|
||||||
<ProjectName>Microsoft.DotNet.Cli.Utils.csproj</ProjectName>
|
<ProjectName>Microsoft.DotNet.Cli.Utils.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>$(CliVersionPrefix)-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc4-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>False</Clean>
|
<Clean>False</Clean>
|
||||||
<MsbuildArgs>/p:TargetFramework=netstandard1.5</MsbuildArgs>
|
<MsbuildArgs>/p:TargetFramework=netstandard1.5</MsbuildArgs>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
|
@ -42,8 +42,8 @@
|
||||||
<ProjectName>Microsoft.DotNet.InternalAbstractions.csproj</ProjectName>
|
<ProjectName>Microsoft.DotNet.InternalAbstractions.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>2.0.0-beta-</VersionPrefix>
|
<VersionPrefix>2.0.0</VersionPrefix>
|
||||||
<VersionSuffix>beta-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>False</Clean>
|
<Clean>False</Clean>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
<BaseTestPackageProject Include="TestAssets/TestPackages/PackageWithFakeNativeDep"
|
<BaseTestPackageProject Include="TestAssets/TestPackages/PackageWithFakeNativeDep"
|
||||||
|
@ -62,8 +62,8 @@
|
||||||
<ProjectName>dotnet-dependency-context-test.csproj</ProjectName>
|
<ProjectName>dotnet-dependency-context-test.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>1.0.0-rc-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>True</Clean>
|
<Clean>True</Clean>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
<BaseTestPackageProject Include="TestAssets/TestPackages/dotnet-dependency-tool-invoker">
|
<BaseTestPackageProject Include="TestAssets/TestPackages/dotnet-dependency-tool-invoker">
|
||||||
|
@ -71,8 +71,8 @@
|
||||||
<ProjectName>dotnet-dependency-tool-invoker.csproj</ProjectName>
|
<ProjectName>dotnet-dependency-tool-invoker.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>1.0.0-rc-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>True</Clean>
|
<Clean>True</Clean>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
<BaseTestPackageProject Include="TestAssets/TestPackages/dotnet-desktop-and-portable"
|
<BaseTestPackageProject Include="TestAssets/TestPackages/dotnet-desktop-and-portable"
|
||||||
|
@ -81,8 +81,8 @@
|
||||||
<ProjectName>dotnet-desktop-and-portable.csproj</ProjectName>
|
<ProjectName>dotnet-desktop-and-portable.csproj</ProjectName>
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsApplicable>True</IsApplicable>
|
<IsApplicable>True</IsApplicable>
|
||||||
<VersionPrefix>1.0.0-rc-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>True</Clean>
|
<Clean>True</Clean>
|
||||||
<MsbuildArgs>/p:RuntimeIdentifier=$(CoreCLRRid)</MsbuildArgs>
|
<MsbuildArgs>/p:RuntimeIdentifier=$(CoreCLRRid)</MsbuildArgs>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
|
@ -93,8 +93,8 @@
|
||||||
<IsTool>True</IsTool>
|
<IsTool>True</IsTool>
|
||||||
<IsMsbuild>True</IsMsbuild>
|
<IsMsbuild>True</IsMsbuild>
|
||||||
<IsApplicable>$(DesktopAvailable)</IsApplicable>
|
<IsApplicable>$(DesktopAvailable)</IsApplicable>
|
||||||
<VersionPrefix>1.0.0-rc-</VersionPrefix>
|
<VersionPrefix>$(CliVersionPrefix)</VersionPrefix>
|
||||||
<VersionSuffix>rc-$(TestPackageBuildVersionSuffix)</VersionSuffix>
|
<VersionSuffix>$(VersionSuffix)</VersionSuffix>
|
||||||
<Clean>True</Clean>
|
<Clean>True</Clean>
|
||||||
<MsbuildArgs>/p:RuntimeIdentifier=$(CoreCLRRid)</MsbuildArgs>
|
<MsbuildArgs>/p:RuntimeIdentifier=$(CoreCLRRid)</MsbuildArgs>
|
||||||
</BaseTestPackageProject>
|
</BaseTestPackageProject>
|
||||||
|
|
|
@ -27,15 +27,6 @@ namespace Microsoft.DotNet.Cli.Build
|
||||||
[Output]
|
[Output]
|
||||||
public string ReleaseSuffix { get; set; }
|
public string ReleaseSuffix { get; set; }
|
||||||
|
|
||||||
[Output]
|
|
||||||
public string VersionSuffix { get; set; }
|
|
||||||
|
|
||||||
[Output]
|
|
||||||
public string SimpleVersion { get; set; }
|
|
||||||
|
|
||||||
[Output]
|
|
||||||
public string NugetVersion { get; set; }
|
|
||||||
|
|
||||||
[Output]
|
[Output]
|
||||||
public string MsiVersion { get; set; }
|
public string MsiVersion { get; set; }
|
||||||
|
|
||||||
|
@ -56,7 +47,7 @@ namespace Microsoft.DotNet.Cli.Build
|
||||||
|
|
||||||
var branchInfo = new BranchInfo(RepoRoot);
|
var branchInfo = new BranchInfo(RepoRoot);
|
||||||
|
|
||||||
var buildVersion = new BuildVersion()
|
var buildVersion = new Version
|
||||||
{
|
{
|
||||||
Major = int.Parse(branchInfo.Entries["MAJOR_VERSION"]),
|
Major = int.Parse(branchInfo.Entries["MAJOR_VERSION"]),
|
||||||
Minor = int.Parse(branchInfo.Entries["MINOR_VERSION"]),
|
Minor = int.Parse(branchInfo.Entries["MINOR_VERSION"]),
|
||||||
|
@ -70,9 +61,6 @@ namespace Microsoft.DotNet.Cli.Build
|
||||||
VersionPatch = buildVersion.Patch;
|
VersionPatch = buildVersion.Patch;
|
||||||
CommitCount = buildVersion.CommitCountString;
|
CommitCount = buildVersion.CommitCountString;
|
||||||
ReleaseSuffix = buildVersion.ReleaseSuffix;
|
ReleaseSuffix = buildVersion.ReleaseSuffix;
|
||||||
VersionSuffix = buildVersion.VersionSuffix;
|
|
||||||
SimpleVersion = buildVersion.SimpleVersion;
|
|
||||||
NugetVersion = buildVersion.NuGetVersion;
|
|
||||||
MsiVersion = buildVersion.GenerateMsiVersion();
|
MsiVersion = buildVersion.GenerateMsiVersion();
|
||||||
VersionBadgeMoniker = Monikers.GetBadgeMoniker();
|
VersionBadgeMoniker = Monikers.GetBadgeMoniker();
|
||||||
Channel = branchInfo.Entries["CHANNEL"];
|
Channel = branchInfo.Entries["CHANNEL"];
|
||||||
|
|
|
@ -1,13 +0,0 @@
|
||||||
using System.Collections.Generic;
|
|
||||||
|
|
||||||
namespace Microsoft.DotNet.Cli.Build
|
|
||||||
{
|
|
||||||
public class BuildVersion : Version
|
|
||||||
{
|
|
||||||
public string SimpleVersion => $"{Major}.{Minor}.{Patch}.{CommitCountString}";
|
|
||||||
public string VersionSuffix => $"{ReleaseSuffix}-{CommitCountString}";
|
|
||||||
public string NuGetVersion => $"{Major}.{Minor}.{Patch}-{VersionSuffix}";
|
|
||||||
public string NetCoreAppVersion => $"{Major}.{Minor}.{Patch}-rc4-{CommitCountString}";
|
|
||||||
public string ProductionVersion => $"{Major}.{Minor}.{Patch}";
|
|
||||||
}
|
|
||||||
}
|
|
|
@ -1,8 +1,6 @@
|
||||||
using System.Collections.Generic;
|
|
||||||
|
|
||||||
namespace Microsoft.DotNet.Cli.Build
|
namespace Microsoft.DotNet.Cli.Build
|
||||||
{
|
{
|
||||||
public abstract class Version
|
public class Version
|
||||||
{
|
{
|
||||||
public virtual int Major { get; set; }
|
public virtual int Major { get; set; }
|
||||||
public virtual int Minor { get; set; }
|
public virtual int Minor { get; set; }
|
||||||
|
|
|
@ -10,7 +10,7 @@
|
||||||
</Component>
|
</Component>
|
||||||
<Component Id="SetupRegistry_x86_RC2_Compat_Key" Directory="TARGETDIR" Win64="no">
|
<Component Id="SetupRegistry_x86_RC2_Compat_Key" Directory="TARGETDIR" Win64="no">
|
||||||
<RegistryKey Root="HKLM" Key="SOFTWARE\dotnet\Setup\InstalledVersions\$(var.Platform)\sdk">
|
<RegistryKey Root="HKLM" Key="SOFTWARE\dotnet\Setup\InstalledVersions\$(var.Platform)\sdk">
|
||||||
<RegistryValue Action="write" Name="1.0.0-rc4" Type="integer" Value="1" KeyPath="yes"/>
|
<RegistryValue Action="write" Name="1.0.0" Type="integer" Value="1" KeyPath="yes"/>
|
||||||
</RegistryKey>
|
</RegistryKey>
|
||||||
</Component>
|
</Component>
|
||||||
</ComponentGroup>
|
</ComponentGroup>
|
||||||
|
|
Loading…
Add table
Reference in a new issue