mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disable warnings for aspnetcore, cleanup NoWarns (#16792)

Browse source
This commit is contained in:
Matt Thalman 2023-06-22 20:08:59 -05:00 • committed by GitHub
parent 2a43d7040d
commit 29bfd81725
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 5 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/SourceBuild/content/repo-projects/aspnetcore.proj
View file

@ -24,19 +24,12 @@
<LogVerbosityOptOut>true</LogVerbosityOptOut> <LogVerbosityOptOut>true</LogVerbosityOptOut>
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType> <PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>
<!-- CA1512 - Use 'ArgumentOutOfRangeException.ThrowIfEqual'
Requires https://github.com/dotnet/aspnetcore/issues/47673 -->
<!-- CA1822 - Mark members as static
https://github.com/dotnet/aspnetcore/pull/48551 -->
<!-- CA1854 - Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method
https://github.com/dotnet/aspnetcore/issues/48052 -->
<!-- IDE0005 - Using directive is unnecessary: https://github.com/dotnet/aspnetcore/issues/47932 -->
<!-- IDE0059 - Unnecessary assignment of a value: https://github.com/dotnet/aspnetcore/pull/47931 -->
<!-- NETSDK1206 - Non-portable RID detected: https://github.com/dotnet/aspnetcore/issues/48842 -->
<RepoNoWarns>CA1512;CA1822;CA1854;IDE0005;IDE0059;NETSDK1206</RepoNoWarns>
</PropertyGroup> </PropertyGroup>
<ItemGroup>
<EnvironmentVariables Include="warn_as_error=false" />
</ItemGroup>
<ItemGroup> <ItemGroup>
<!-- <!--
From aspnetcore Versions.props: From aspnetcore Versions.props:

4
src/SourceBuild/content/repo-projects/format.proj
View file

@ -3,10 +3,6 @@
<PropertyGroup> <PropertyGroup>
<BuildCommand>$(ProjectDirectory)eng\common\build$(ShellExtension) $(StandardSourceBuildArgs)</BuildCommand> <BuildCommand>$(ProjectDirectory)eng\common\build$(ShellExtension) $(StandardSourceBuildArgs)</BuildCommand>
<!-- CS9057 - Caused by incoherency of analyzer assemblies during pre-release builds. -->
<RepoNoWarns>CS9057</RepoNoWarns>
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType> <PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>
</PropertyGroup> </PropertyGroup>

3
src/SourceBuild/content/repo-projects/installer.proj
View file

@ -44,9 +44,6 @@
<BuildCommand>$(StandardSourceBuildCommand) $(BuildCommandArgs)</BuildCommand> <BuildCommand>$(StandardSourceBuildCommand) $(BuildCommandArgs)</BuildCommand>
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType> <PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>
<!-- CS9057 - Caused by incoherency of analyzer assemblies during pre-release builds. -->
<RepoNoWarns>CS9057</RepoNoWarns>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

2
src/SourceBuild/content/repo-projects/nuget-client.proj
View file

@ -5,7 +5,7 @@
<NuGetKeyFilePath>$(KeysDir)NuGet.Client.snk</NuGetKeyFilePath> <NuGetKeyFilePath>$(KeysDir)NuGet.Client.snk</NuGetKeyFilePath>
<DeterministicBuildOptOut>true</DeterministicBuildOptOut> <DeterministicBuildOptOut>true</DeterministicBuildOptOut>
<!-- SYSLIB0051 - Type or member is obsolete: https://github.com/NuGet/Home/issues/12626 --> <!-- SYSLIB0051 - Type or member is obsolete: https://github.com/NuGet/Home/issues/12626 -->
<RepoNoWarns>CS9057;SYSLIB0051</RepoNoWarns> <RepoNoWarns>SYSLIB0051</RepoNoWarns>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

4
src/SourceBuild/content/repo-projects/razor.proj
View file

@ -4,10 +4,6 @@
<PropertyGroup> <PropertyGroup>
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType> <PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>
<BuildCommand>$(StandardSourceBuildCommand) $(StandardSourceBuildArgs)</BuildCommand> <BuildCommand>$(StandardSourceBuildCommand) $(StandardSourceBuildArgs)</BuildCommand>
<!-- NU1507 - https://github.com/dotnet/razor-compiler/issues/242
Occurs when using NuGet central package management without defining any Package Source Mappings. -->
<RepoNoWarns>NU1507</RepoNoWarns>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

6
src/SourceBuild/content/repo-projects/vstest.proj
View file

@ -5,13 +5,7 @@
<BuildCommandArgs>$(StandardSourceBuildArgs)</BuildCommandArgs> <BuildCommandArgs>$(StandardSourceBuildArgs)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /p:SemanticVersioningV1=true</BuildCommandArgs> <BuildCommandArgs>$(BuildCommandArgs) /p:SemanticVersioningV1=true</BuildCommandArgs>
<BuildCommand>$(ProjectDirectory)\eng\common\build$(ShellExtension) $(BuildCommandArgs)</BuildCommand> <BuildCommand>$(ProjectDirectory)\eng\common\build$(ShellExtension) $(BuildCommandArgs)</BuildCommand>
<DeterministicBuildOptOut>true</DeterministicBuildOptOut> <DeterministicBuildOptOut>true</DeterministicBuildOptOut>
<!-- IDE0059 - Unnecessary assignment of a value: https://github.com/microsoft/vstest/issues/4424 -->
<!-- SYSLIB0051 - Type or member is obsolete: https://github.com/microsoft/vstest/pull/4425 -->
<RepoNoWarns>IDE0059;SYSLIB0051</RepoNoWarns>
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType> <PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>
</PropertyGroup> </PropertyGroup>