diff --git a/.gitignore b/.gitignore index 185c4bcc1..260df47a9 100644 --- a/.gitignore +++ b/.gitignore @@ -125,7 +125,7 @@ bin/ *.scc # BinLog artifacts -msbuild.*.ProjectImports.zip +msbuild*ProjectImports.zip # Chutzpah Test files _Chutzpah* diff --git a/eng/Versions.props b/eng/Versions.props index 1b238caed..4d732176f 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -1,7 +1,7 @@ - 3.0.100-preview-009722 + 3.0.100-preview-009724 diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.thm b/src/redist/targets/packaging/windows/clisdk/bundle.thm index 797d2cab1..99a8a0f83 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.thm +++ b/src/redist/targets/packaging/windows/clisdk/bundle.thm @@ -2,7 +2,7 @@ #(loc.Caption) Segoe UI - Segoe UI + Segoe UI Segoe UI Segoe UI Segoe UI @@ -11,7 +11,7 @@ #(loc.Title) - + #(loc.HelpHeader) #(loc.HelpText) @@ -96,4 +96,4 @@ - \ No newline at end of file + diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.wxl b/src/redist/targets/packaging/windows/clisdk/bundle.wxl index dee03bb18..7546889a1 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.wxl +++ b/src/redist/targets/packaging/windows/clisdk/bundle.wxl @@ -5,13 +5,13 @@ Are you sure you want to cancel? Previous version Setup Help - /install | /repair | /uninstall | /layout [directory] - installs, repairs, uninstalls or - creates a complete local copy of the bundle in directory. Install is the default. + /install | /repair | /uninstall | /layout [\[]"directory"[\]] - installs, repairs, uninstalls + or creates a complete local copy of the bundle in directory. '/install' is the default. -/passive | /quiet - displays minimal UI with no prompts or displays no UI and +/passive | /quiet - displays minimal UI with no prompts or displays no UI and no prompts. By default UI and all prompts are displayed. -/norestart - suppress any attempts to restart. By default UI will prompt before restart. +/norestart - suppress any attempts to restart. By default UI will prompt before restart. /log log.txt - logs to a specific file. By default a log file is created in %TEMP%. &Close I &agree to the license terms and conditions @@ -49,7 +49,7 @@ &Cancel The installation was successful -The following were installed at [DOTNETHOME] +The following were installed at: '[DOTNETHOME]' • .NET Core SDK [DOTNETSDKVERSION] • .NET Core Runtime [DOTNETRUNTIMEVERSION] • ASP.NET Core Runtime [ASPNETCOREVERSION] diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.wxs b/src/redist/targets/packaging/windows/clisdk/bundle.wxs index af6482f3f..b1bd6fdde 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.wxs +++ b/src/redist/targets/packaging/windows/clisdk/bundle.wxs @@ -10,25 +10,93 @@ AboutUrl="https://dotnet.github.io/" Compressed="yes"> + + WixBundleInstalled OR ((NOT (DOTNETHOME_X64 ~= DOTNETHOME_X86)) OR DOTNETHOMESIMILARITYCHECKOVERRIDE) + + + ShowVersion="yes" /> - + + + + + + + + + + + + + + + + - - + + + @@ -41,9 +109,12 @@ - + + + + diff --git a/src/redist/targets/packaging/windows/clisdk/dotnet.wxs b/src/redist/targets/packaging/windows/clisdk/dotnet.wxs index fbcebfbbf..939059f6d 100644 --- a/src/redist/targets/packaging/windows/clisdk/dotnet.wxs +++ b/src/redist/targets/packaging/windows/clisdk/dotnet.wxs @@ -4,13 +4,17 @@ + + Installed OR ALLOWCLISDKMSIINSTALL + + - + diff --git a/src/redist/targets/packaging/windows/clisdk/registrykeys.wxs b/src/redist/targets/packaging/windows/clisdk/registrykeys.wxs index c8c7e91d5..318bb068b 100644 --- a/src/redist/targets/packaging/windows/clisdk/registrykeys.wxs +++ b/src/redist/targets/packaging/windows/clisdk/registrykeys.wxs @@ -2,12 +2,24 @@ - - + + + + VersionNT64 AND DOTNETHOME_X64 + + + + + + DOTNETHOME_X86 + + + + - \ No newline at end of file + diff --git a/src/redist/targets/packaging/windows/clisdk/variables.wxi b/src/redist/targets/packaging/windows/clisdk/variables.wxi index d76680561..bcef69b81 100644 --- a/src/redist/targets/packaging/windows/clisdk/variables.wxi +++ b/src/redist/targets/packaging/windows/clisdk/variables.wxi @@ -17,10 +17,12 @@ + +