From 2099d0fd30d3a3cb013db9242c418a86bf905da1 Mon Sep 17 00:00:00 2001
From: Matt Mitchell <mmitche@microsoft.com>
Date: Tue, 10 Jan 2023 17:07:21 -0800
Subject: [PATCH] Remove legacy source replacement (#15234)

---
 NuGet.config                                  |  6 +-
 .../repo-projects/Directory.Build.targets     | 68 -------------------
 .../content/repo-projects/installer.proj      |  3 -
 3 files changed, 1 insertion(+), 76 deletions(-)

diff --git a/NuGet.config b/NuGet.config
index cb866adcb..77050d5f1 100644
--- a/NuGet.config
+++ b/NuGet.config
@@ -11,12 +11,8 @@
     <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
     <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
     <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
-    <add key="general-testing" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/general-testing/nuget/v3/index.json" />
     <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
-    <add key="dotnet3-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3-transport/nuget/v3/index.json" />
-    <add key="dotnet3.1-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3.1-transport/nuget/v3/index.json" />
-    <add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-    <add key="dotnet5-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5-transport/nuget/v3/index.json" />
+    <add key="dotnet-eol-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eol-transport/nuget/v3/index.json" />
     <add key="dotnet6" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />
     <add key="dotnet6-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json" />
     <add key="dotnet7" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json" />
diff --git a/src/SourceBuild/content/repo-projects/Directory.Build.targets b/src/SourceBuild/content/repo-projects/Directory.Build.targets
index 888ab167b..64745b5d3 100644
--- a/src/SourceBuild/content/repo-projects/Directory.Build.targets
+++ b/src/SourceBuild/content/repo-projects/Directory.Build.targets
@@ -167,7 +167,6 @@
       <ReferencePackagesNuGetSourceName>reference-packages</ReferencePackagesNuGetSourceName>
       <SourceBuiltNuGetSourceName>source-built</SourceBuiltNuGetSourceName>
       <ExtraSourcesNuGetSourceName>ExtraSources</ExtraSourcesNuGetSourceName>
-      <DotNet5InternalTransportNuGetSourceName>dotnet5-internal-transport</DotNet5InternalTransportNuGetSourceName>
       <SourceBuildSources>$(PrebuiltNuGetSourceName);$(PreviouslySourceBuiltNuGetSourceName);$(ReferencePackagesNuGetSourceName);$(SourceBuiltNuGetSourceName)</SourceBuildSources>
       <SourceBuildSources Condition="'$(ExtraRestoreSourcePath)' != ''">$(SourceBuildSources);$(ExtraSourcesNuGetSourceName)</SourceBuildSources>
       <SourceBuildSources Condition="'$(VSS_NUGET_EXTERNAL_FEED_ENDPOINTS)' != '' and '$(SetUpInternalTransportFeed)' == 'true'">$(SourceBuildSources);$(DotNet5InternalTransportNuGetSourceName)</SourceBuildSources>
@@ -207,78 +206,11 @@
                             SourcePath="$(ExtraRestoreSourcePath)"
                             Condition="'$(ExtraRestoreSourcePath)' != ''" />
 
-    <!--
-      The internal transport feed is dynamically added by Arcade by a script called directly in the
-      official pipeline, so in some cases we need to do the same here.
-    -->
-    <AddSourceToNuGetConfig
-      Condition="
-        '$(VSS_NUGET_EXTERNAL_FEED_ENDPOINTS)' != '' and
-        '$(SetUpInternalTransportFeed)' == 'true'"
-      NuGetConfigFile="%(NuGetConfigFiles.Identity)"
-      SourceName="$(DotNet5InternalTransportNuGetSourceName)"
-      SourcePath="https://pkgs.dev.azure.com/dnceng/internal/_packaging/dotnet5-internal-transport/nuget/v3/index.json" />
-
     <UpdateNuGetConfigPackageSourcesMappings
       NuGetConfigFile="%(NuGetConfigFiles.Identity)"
       BuildWithOnlineSources="$(BuildWithOnlineSources)"
       SourceBuildSources="$(SourceBuildSources)" />
 
-    <!-- Update NuGet.Config files that have deprecated myget feeds -->
-    <ItemGroup>
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/nuget-build/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/nuget-build/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://www.myget.org/F/nugetbuild/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/nuget-build/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/dotnet-corefxlab/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json"
-        NewFeed="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/vstest/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/mstestv2/auth/1e768268-8c95-4e7e-9fd2-0eb1b1b69b18/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/roslyn/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/roslyn-analyzers/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/roslyn-master-nightly/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/symreader-converter/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/interactive-window/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/mstestv2/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/vsunittesting/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/msbuild/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
-      <LegacyFeedMapping
-        Include="https://dotnet.myget.org/F/dotnet-buildtools/api/v3/index.json"
-        NewFeed="https://pkgs.dev.azure.com/dnceng/public/_packaging/myget-legacy/nuget/v3/index.json" />
-    </ItemGroup>
-
-    <ReplaceFeedsInNugetConfig InputFile="%(NuGetConfigFiles.Identity)"
-                               FeedMapping="@(LegacyFeedMapping)" />
-
     <WriteLinesToFile File="$(RepoCompletedSemaphorePath)UpdateNuGetConfig.complete" Overwrite="true" />
   </Target>
 
diff --git a/src/SourceBuild/content/repo-projects/installer.proj b/src/SourceBuild/content/repo-projects/installer.proj
index 42ef91233..d41b97b78 100644
--- a/src/SourceBuild/content/repo-projects/installer.proj
+++ b/src/SourceBuild/content/repo-projects/installer.proj
@@ -49,9 +49,6 @@
 
     <NuGetConfigFile>$(ProjectDirectory)NuGet.config</NuGetConfigFile>
 
-    <!-- This repo uses text-only template packages from the internal transport feed. -->
-    <SetUpInternalTransportFeed>true</SetUpInternalTransportFeed>
-
     <!-- CS9057 - Caused by incoherency of analyzer assemblies during pre-release builds. -->
     <RepoNoWarns>CS9057</RepoNoWarns>
   </PropertyGroup>