mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

dotnet migrate uses the correct TreatWarningsAsErrors property (#5492)

Browse source
This commit is contained in:
Justin Goshi 2017-01-30 14:34:19 -10:00 • committed by Piotr Puszkiewicz
parent e8c5d23c29
commit 1c80899909
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs
View file

@ -55,7 +55,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Rules
compilerOptions => compilerOptions.PreserveCompilationContext != null && compilerOptions.PreserveCompilationContext.Value);
private AddPropertyTransform<CommonCompilerOptions> WarningsAsErrorsTransform =>
new AddPropertyTransform<CommonCompilerOptions>("WarningsAsErrors",
new AddPropertyTransform<CommonCompilerOptions>("TreatWarningsAsErrors",
compilerOptions => compilerOptions.WarningsAsErrors.ToString().ToLower(),
compilerOptions => compilerOptions.WarningsAsErrors != null && compilerOptions.WarningsAsErrors.Value);

6
test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateBuildOptions.cs
View file

@ -193,8 +193,8 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
}
}");
mockProj.Properties.Count(p => p.Name == "WarningsAsErrors").Should().Be(1);
mockProj.Properties.First(p => p.Name == "WarningsAsErrors").Value.Should().Be("true");
mockProj.Properties.Count(p => p.Name == "TreatWarningsAsErrors").Should().Be(1);
mockProj.Properties.First(p => p.Name == "TreatWarningsAsErrors").Value.Should().Be("true");
mockProj = RunBuildOptionsRuleOnPj(@"
{
@ -203,7 +203,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
}
}");
mockProj.Properties.Count(p => p.Name == "WarningsAsErrors").Should().Be(0);
mockProj.Properties.Count(p => p.Name == "TreatWarningsAsErrors").Should().Be(0);
}
[Fact]