mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Passwords/keys should not be passed in the environment via a docker file.

Browse source
This commit is contained in:
John Beisner 2017-07-26 10:34:50 -07:00
parent e7d5c6891b
commit 1bd48fde5c
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scripts/dockerrun.sh
View file

@ -115,24 +115,20 @@ echo "Running command: $BUILD_COMMAND"
echo "Using code from: $DOCKER_HOST_SHARE_DIR" echo "Using code from: $DOCKER_HOST_SHARE_DIR"
[ -z "$INTERACTIVE" ] || echo "Running Interactive" [ -z "$INTERACTIVE" ] || echo "Running Interactive"
# Note: passwords/keys should not be passed in the environment
docker run $INTERACTIVE -t --rm --sig-proxy=true \ docker run $INTERACTIVE -t --rm --sig-proxy=true \
--name $DOTNET_BUILD_CONTAINER_NAME \ --name $DOTNET_BUILD_CONTAINER_NAME \
-v $DOCKER_HOST_SHARE_DIR:/opt/code \ -v $DOCKER_HOST_SHARE_DIR:/opt/code \
-e CHANNEL \ -e CHANNEL \
-e CONNECTION_STRING \
-e REPO_ID \ -e REPO_ID \
-e REPO_USER \ -e REPO_USER \
-e REPO_PASS \
-e REPO_SERVER \ -e REPO_SERVER \
-e DOTNET_BUILD_SKIP_CROSSGEN \ -e DOTNET_BUILD_SKIP_CROSSGEN \
-e PUBLISH_TO_AZURE_BLOB \ -e PUBLISH_TO_AZURE_BLOB \
-e NUGET_FEED_URL \ -e NUGET_FEED_URL \
-e NUGET_API_KEY \ -e NUGET_API_KEY \
-e GITHUB_PASSWORD \
-e ARTIFACT_STORAGE_KEY \
-e ARTIFACT_STORAGE_ACCOUNT \ -e ARTIFACT_STORAGE_ACCOUNT \
-e ARTIFACT_STORAGE_CONTAINER \ -e ARTIFACT_STORAGE_CONTAINER \
-e CHECKSUM_STORAGE_KEY \
-e CHECKSUM_STORAGE_ACCOUNT \ -e CHECKSUM_STORAGE_ACCOUNT \
-e CHECKSUM_STORAGE_CONTAINER \ -e CHECKSUM_STORAGE_CONTAINER \
-e CLIBUILD_SKIP_TESTS \ -e CLIBUILD_SKIP_TESTS \
@ -141,10 +137,7 @@ docker run $INTERACTIVE -t --rm --sig-proxy=true \
-e RELEASESUFFIX \ -e RELEASESUFFIX \
-e COREFXAZURECONTAINER \ -e COREFXAZURECONTAINER \
-e AZUREACCOUNTNAME \ -e AZUREACCOUNTNAME \
-e AZUREACCESSTOKEN \
-e VSOPASSWORD \
-e RELEASETOOLSGITURL \ -e RELEASETOOLSGITURL \
-e CORESETUPBLOBROOTURL \ -e CORESETUPBLOBROOTURL \
-e CORESETUPBLOBACCESSTOKEN \
$DOTNET_BUILD_CONTAINER_TAG \ $DOTNET_BUILD_CONTAINER_TAG \
$BUILD_COMMAND "$@" $BUILD_COMMAND "$@"