Merge pull request #2812 from dotnet/pakrym/is-package-based
Remove IsPackageBased() workaround
This commit is contained in:
commit
18f9018eb9
4 changed files with 3 additions and 10 deletions
|
@ -417,7 +417,7 @@ namespace Microsoft.DotNet.ProjectModel
|
|||
if (package != null &&
|
||||
package.Resolved &&
|
||||
package.HasCompileTimePlaceholder &&
|
||||
!TargetFramework.IsPackageBased())
|
||||
!TargetFramework.IsPackageBased)
|
||||
{
|
||||
var newKey = new LibraryKey(library.Identity.Name, LibraryType.ReferenceAssembly);
|
||||
var dependency = new LibraryRange(library.Identity.Name, LibraryType.ReferenceAssembly);
|
||||
|
|
|
@ -83,7 +83,7 @@ namespace Microsoft.DotNet.ProjectModel.Resolution
|
|||
LibraryDependencyType.Default));
|
||||
}
|
||||
|
||||
if (!targetFramework.IsPackageBased())
|
||||
if (!targetFramework.IsPackageBased)
|
||||
{
|
||||
// Only add framework assemblies for non-package based frameworks.
|
||||
foreach (var frameworkAssembly in targetLibrary.FrameworkAssemblies)
|
||||
|
|
|
@ -138,7 +138,7 @@ namespace Microsoft.DotNet.ProjectModel.Resolution
|
|||
LibraryDependencyType.Default));
|
||||
}
|
||||
|
||||
if (!targetFramework.IsPackageBased())
|
||||
if (!targetFramework.IsPackageBased)
|
||||
{
|
||||
// Only add framework assemblies for non-package based frameworks.
|
||||
foreach (var frameworkAssembly in targetLibrary.FrameworkAssemblies)
|
||||
|
|
|
@ -56,12 +56,5 @@ namespace NuGet.Frameworks
|
|||
}
|
||||
return name + "-" + frameworkName.Profile;
|
||||
}
|
||||
|
||||
internal static bool IsPackageBased(this NuGetFramework self)
|
||||
{
|
||||
return self.IsPackageBased ||
|
||||
(self.Framework == FrameworkConstants.FrameworkIdentifiers.NetCore &&
|
||||
self.Version >= new Version(5, 0, 0, 0));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue