mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Code Review Feedback. Refactor Config Class Name

Browse source
This commit is contained in:
Bryan 2015-11-17 13:20:34 -08:00
parent 22b3b497e0
commit 17232e836d
12 changed files with 47 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/Microsoft.DotNet.Tools.Compiler.Native/IntermediateCompilation/Windows/WindowsCppCompileStep.cs
View file

@ -28,12 +28,12 @@ namespace Microsoft.DotNet.Tools.Compiler.Native
private string CompilerArgStr { get; set; }
public WindowsCppCompileStep(Config config)
public WindowsCppCompileStep(NativeCompileSettings config)
{
InitializeArgs(config);
}
public int Invoke(Config config)
public int Invoke(NativeCompileSettings config)
{
var result = WindowsCommon.SetVCVars();
if (result != 0)
@ -57,7 +57,7 @@ namespace Microsoft.DotNet.Tools.Compiler.Native
return !string.IsNullOrEmpty(vcInstallDir);
}
private void InitializeArgs(Config config)
private void InitializeArgs(NativeCompileSettings config)
{
var argsList = new List<string>();
@ -85,7 +85,7 @@ namespace Microsoft.DotNet.Tools.Compiler.Native
this.CompilerArgStr = string.Join(" ", argsList);
}
private int InvokeCompiler(Config config)
private int InvokeCompiler(NativeCompileSettings config)
{
var vcInstallDir = Environment.GetEnvironmentVariable("VS140COMNTOOLS");
var compilerPath = Path.Combine(vcInstallDir, VSBin, CompilerName);
@ -98,7 +98,7 @@ namespace Microsoft.DotNet.Tools.Compiler.Native
return result.ExitCode;
}
private string DetermineInFile(Config config)
private string DetermineInFile(NativeCompileSettings config)
{
var intermediateDirectory = config.IntermediateDirectory;
@ -109,7 +109,7 @@ namespace Microsoft.DotNet.Tools.Compiler.Native
return infile;
}
public string DetermineOutputFile(Config config)
public string DetermineOutputFile(NativeCompileSettings config)
{
var intermediateDirectory = config.IntermediateDirectory;