From 01566ce1546272f7505ff5aca3fa1ca83f45be07 Mon Sep 17 00:00:00 2001 From: jbeisner Date: Mon, 9 Sep 2019 12:38:32 -0700 Subject: [PATCH 1/3] Download the ASP.NET SharedFramework MSI and the Module V2 MSI --- src/redist/targets/GenerateLayout.targets | 30 +++++++++++++++++------ src/redist/targets/GenerateMSIs.targets | 2 +- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/src/redist/targets/GenerateLayout.targets b/src/redist/targets/GenerateLayout.targets index d2a0b6fd1..68d467140 100644 --- a/src/redist/targets/GenerateLayout.targets +++ b/src/redist/targets/GenerateLayout.targets @@ -46,8 +46,9 @@ $(CoreSetupRid) $(ProductMonikerRid) linux-$(Architecture) - dotnet-runtime-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) - + dotnet-runtime-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) + windowsdesktop-runtime-$(MicrosoftWindowsDesktopPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) + $(SharedFrameworkRid) linux-x64 $(AspNetCoreSharedFxInstallerRid) @@ -55,16 +56,15 @@ aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension) - aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid).wixlib + aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid).wixlib aspnetcore-targeting-pack-$(AspNetTargetingPackVersion)$(InstallerExtension) aspnetcore-targeting-pack-$(AspNetTargetingPackVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension) + aspnetcoremodule_$(Architecture)_en_v2$(InstallerExtension) aspnetcore-targeting-pack-$(AspNetCoreVersion)$(ArchiveExtension) aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxArchiveRid)$(ArchiveExtension) - windowsdesktop-runtime-$(MicrosoftWindowsDesktopPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) - aspnetcore_base_runtime.version - + $(CoreSetupBlobRootUrl)Runtime/ @@ -82,7 +82,7 @@ $(CoreSetupRootUrl)$(MicrosoftNETCoreAppPackageVersion) - $(CombinedFrameworkHostCompressedFileName) + $(CombinedFrameworkHostArchiveFileName) $(CoreSetupBlobAccessTokenParam) @@ -212,12 +212,26 @@ + Condition="'$(InstallerExtension)' != '.pkg' And '$(SkipBuildingInstallers)' != 'true' And '$(InstallerExtension)' != '' And !$(Architecture.StartsWith('arm'))"> $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) $(DownloadedAspNetCoreSharedFxInstallerFileName) $(CoreSetupBlobAccessTokenParam) + + $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) + $(DownloadedAspNetCoreSharedFxWixLibFileName) + $(CoreSetupBlobAccessTokenParam) + + + + $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) + $(DownloadedAspNetCoreV2ModuleInstallerFileName) + $(CoreSetupBlobAccessTokenParam) + + $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) diff --git a/src/redist/targets/GenerateMSIs.targets b/src/redist/targets/GenerateMSIs.targets index 2fd3ea9d3..82d619de0 100644 --- a/src/redist/targets/GenerateMSIs.targets +++ b/src/redist/targets/GenerateMSIs.targets @@ -231,7 +231,7 @@ $(RedistLayoutPath)sdk\$(SdkVersion)\ https://dotnetcli.azureedge.net/dotnet/ https://dotnetcli.blob.core.windows.net/dotnet/ https://dotnetfeed.blob.core.windows.net/dotnet-toolset/ - + $(HostRid) $(HostMonikerRid) @@ -48,7 +48,7 @@ linux-$(Architecture) dotnet-runtime-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) windowsdesktop-runtime-$(MicrosoftWindowsDesktopPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension) - + $(SharedFrameworkRid) linux-x64 $(AspNetCoreSharedFxInstallerRid) @@ -62,6 +62,7 @@ aspnetcoremodule_$(Architecture)_en_v2$(InstallerExtension) aspnetcore-targeting-pack-$(AspNetCoreVersion)$(ArchiveExtension) aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxArchiveRid)$(ArchiveExtension) + aspnetcore_base_runtime.version @@ -100,7 +101,7 @@ $(NetStandardTargetingPackTargetFramework) packs/%(PackageName)/%(PackageVersion) - + Microsoft.AspNetCore.App.Ref $(AspNetTargetingPackVersion) @@ -128,28 +129,28 @@ $(DownloadedRuntimeDepsInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + $(CoreSetupRootUrl)$(MicrosoftNETCoreAppPackageVersion) $(DownloadedSharedFrameworkInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + $(CoreSetupRootUrl)$(SharedHostVersion) $(DownloadedSharedHostInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + $(CoreSetupRootUrl)$(HostFxrVersion) $(DownloadedHostFxrInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + $(CoreSetupRootUrl)$(NetCoreAppTargetingPackVersion) @@ -170,7 +171,7 @@ $(DownloadedNetCoreAppHostPackInstallerFileName) $(CoreSetupBlobAccessTokenParam) - + $(CoreSetupRootUrl)$(WindowsDesktopTargetingPackVersion) @@ -203,7 +204,7 @@ $(CoreSetupBlobAccessTokenParam) - + $(AspNetCoreSharedFxRootUrl)$(AspNetTargetingPackVersion) @@ -219,14 +220,14 @@ + Condition="'$(SkipBuildingInstallers)' != 'true' And '$(InstallerExtension)' == '.msi' And !$(Architecture.StartsWith('arm'))"> $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) $(DownloadedAspNetCoreSharedFxWixLibFileName) $(CoreSetupBlobAccessTokenParam) + Condition="'$(SkipBuildingInstallers)' != 'true' And '$(InstallerExtension)' == '.msi' And !$(Architecture.StartsWith('arm'))"> $(AspNetCoreSharedFxRootUrl)$(AspNetCoreVersion) $(DownloadedAspNetCoreV2ModuleInstallerFileName) $(CoreSetupBlobAccessTokenParam) @@ -239,13 +240,13 @@ $(CoreSetupBlobAccessTokenParam) - + false true false - + Microsoft.WindowsDesktop.App.Ref @@ -282,7 +283,7 @@ true - + @@ -348,7 +349,7 @@ DestinationFiles="@(BundledLayoutPackageDownloadFilesWithDestination->'%(DestinationPath)')" SkipUnchangedFiles="true" /> - + @@ -365,13 +366,13 @@ ReplacementPatterns="$(ReplacementPattern)" ReplacementStrings="$(ReplacementString)" /> - + - + @@ -379,10 +380,10 @@ $(IntermediateOutputPath)AppHostRestore\ $(SdkOutputDirectory)AppHostTemplate - + - + @@ -420,9 +421,9 @@ - + - + - + - +