mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #11971 from bruno-garcia/ref/remove-unused-env-var

Browse source 
remove unused env var `DOTNET_SKIP_FIRST_TIME_EXPERIENCE`
This commit is contained in:
Marc Paine 2021-09-15 14:43:53 -07:00 • committed by GitHub
commit 0f436f500f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 0 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
eng/common/tools.ps1
View file

@ -157,9 +157,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
# Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism # Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism
$env:DOTNET_MULTILEVEL_LOOKUP=0 $env:DOTNET_MULTILEVEL_LOOKUP=0
# Disable first run since we do not need all ASP.NET packages restored.
$env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
# Disable telemetry on CI. # Disable telemetry on CI.
if ($ci) { if ($ci) {
$env:DOTNET_CLI_TELEMETRY_OPTOUT=1 $env:DOTNET_CLI_TELEMETRY_OPTOUT=1
@ -231,7 +228,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
Write-PipelinePrependPath -Path $dotnetRoot Write-PipelinePrependPath -Path $dotnetRoot
Write-PipelineSetVariable -Name 'DOTNET_MULTILEVEL_LOOKUP' -Value '0' Write-PipelineSetVariable -Name 'DOTNET_MULTILEVEL_LOOKUP' -Value '0'
Write-PipelineSetVariable -Name 'DOTNET_SKIP_FIRST_TIME_EXPERIENCE' -Value '1'
return $global:_DotNetInstallDir = $dotnetRoot return $global:_DotNetInstallDir = $dotnetRoot
} }

4
eng/common/tools.sh
View file

@ -111,9 +111,6 @@ function InitializeDotNetCli {
# Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism # Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism
export DOTNET_MULTILEVEL_LOOKUP=0 export DOTNET_MULTILEVEL_LOOKUP=0
# Disable first run since we want to control all package sources
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
# Disable telemetry on CI # Disable telemetry on CI
if [[ $ci == true ]]; then if [[ $ci == true ]]; then
export DOTNET_CLI_TELEMETRY_OPTOUT=1 export DOTNET_CLI_TELEMETRY_OPTOUT=1
@ -165,7 +162,6 @@ function InitializeDotNetCli {
Write-PipelinePrependPath -path "$dotnet_root" Write-PipelinePrependPath -path "$dotnet_root"
Write-PipelineSetVariable -name "DOTNET_MULTILEVEL_LOOKUP" -value "0" Write-PipelineSetVariable -name "DOTNET_MULTILEVEL_LOOKUP" -value "0"
Write-PipelineSetVariable -name "DOTNET_SKIP_FIRST_TIME_EXPERIENCE" -value "1"
# return value # return value
_InitializeDotNetCli="$dotnet_root" _InitializeDotNetCli="$dotnet_root"

1
eng/core-sdk-build-env.sh
View file

@ -37,5 +37,4 @@ export PATH=$REPO_ROOT/.dotnet$arcade_partition_suffix:$PATH
export DOTNET_INSTALL_DIR=$REPO_ROOT/.dotnet$arcade_partition_suffix export DOTNET_INSTALL_DIR=$REPO_ROOT/.dotnet$arcade_partition_suffix
export ArtifactsDir=$REPO_ROOT/artifacts$arcade_partition_suffix/ export ArtifactsDir=$REPO_ROOT/artifacts$arcade_partition_suffix/
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export DOTNET_MULTILEVEL_LOOKUP=0 export DOTNET_MULTILEVEL_LOOKUP=0

1
eng/core-sdk-test-env.bat
View file

@ -12,5 +12,4 @@ title Core SDK Test (%CLI_REPO_ROOT%)
REM Add Stage 2 CLI to path REM Add Stage 2 CLI to path
set PATH=%CLI_REPO_ROOT%artifacts\bin\redist\Debug\dotnet;%PATH% set PATH=%CLI_REPO_ROOT%artifacts\bin\redist\Debug\dotnet;%PATH%
set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
set DOTNET_MULTILEVEL_LOOKUP=0 set DOTNET_MULTILEVEL_LOOKUP=0

1
eng/core-sdk-test-env.sh
View file

@ -17,5 +17,4 @@ STAGE2_DIR=$REPO_ROOT/artifacts/bin/redist/Debug/dotnet
export PATH=$STAGE2_DIR:$PATH export PATH=$STAGE2_DIR:$PATH
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export DOTNET_MULTILEVEL_LOOKUP=0 export DOTNET_MULTILEVEL_LOOKUP=0

1
eng/restore-toolset.ps1
View file

@ -25,7 +25,6 @@ function CreateBuildEnvScript()
$scriptContents = @" $scriptContents = @"
@echo off @echo off
title Core SDK Build ($RepoRoot) title Core SDK Build ($RepoRoot)
set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
set DOTNET_MULTILEVEL_LOOKUP=0 set DOTNET_MULTILEVEL_LOOKUP=0
set PATH=$env:DOTNET_INSTALL_DIR;%PATH% set PATH=$env:DOTNET_INSTALL_DIR;%PATH%

1
src/SourceBuild/tarball/content/build.sh
View file

@ -152,7 +152,6 @@ fi
echo "Found bootstrap SDK $SDK_VERSION, bootstrap Arcade $ARCADE_BOOTSTRAP_VERSION, bootstrap SourceLink $SOURCE_LINK_BOOTSTRAP_VERSION" echo "Found bootstrap SDK $SDK_VERSION, bootstrap Arcade $ARCADE_BOOTSTRAP_VERSION, bootstrap SourceLink $SOURCE_LINK_BOOTSTRAP_VERSION"
export DOTNET_CLI_TELEMETRY_OPTOUT=1 export DOTNET_CLI_TELEMETRY_OPTOUT=1
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export NUGET_PACKAGES=$restoredPackagesDir/ export NUGET_PACKAGES=$restoredPackagesDir/
if [ "$alternateTarget" == "true" ]; then if [ "$alternateTarget" == "true" ]; then

1
src/SourceBuild/tarball/content/smoke-test.sh
View file

@ -11,7 +11,6 @@ __ROOT_REPO=$(sed 's/\r$//' "$SCRIPT_ROOT/artifacts/obj/rootrepo.txt") # remove
executingUserHome=${HOME:-} executingUserHome=${HOME:-}
export DOTNET_CLI_TELEMETRY_OPTOUT=1 export DOTNET_CLI_TELEMETRY_OPTOUT=1
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
# Use uname to determine what the CPU is. # Use uname to determine what the CPU is.
cpuName=$(uname -p) cpuName=$(uname -p)

1
src/core-sdk-tasks/EnvironmentVariableFilter.cs
View file

@ -31,7 +31,6 @@ namespace Microsoft.DotNet.Cli.Build
"DOTNET_CLI_UI_LANGUAGE", "DOTNET_CLI_UI_LANGUAGE",
"DOTNET_MULTILEVEL_LOOKUP", "DOTNET_MULTILEVEL_LOOKUP",
"DOTNET_RUNTIME_ID", "DOTNET_RUNTIME_ID",
"DOTNET_SKIP_FIRST_TIME_EXPERIENCE",
"NUGET_PACKAGES" "NUGET_PACKAGES"
}; };

1
src/redist/targets/packaging/windows/clisdk/Init.cmd
View file

@ -1,6 +1,5 @@
@echo off @echo off
set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
set DOTNET_MULTILEVEL_LOOKUP=0 set DOTNET_MULTILEVEL_LOOKUP=0
set PATH=%~dp0;%PATH% set PATH=%~dp0;%PATH%

1
test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/TestCommand.cs
View file

@ -143,7 +143,6 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
RemoveCliGeneratedEnvironmentVariablesFrom(psi); RemoveCliGeneratedEnvironmentVariablesFrom(psi);
psi.Environment["DOTNET_MULTILEVEL_LOOKUP"] = "0"; psi.Environment["DOTNET_MULTILEVEL_LOOKUP"] = "0";
psi.Environment["DOTNET_SKIP_FIRST_TIME_EXPERIENCE"] = "1";
// Set DOTNET_ROOT to ensure sub process find the same host fxr // Set DOTNET_ROOT to ensure sub process find the same host fxr
string dotnetDirectoryPath = Path.GetDirectoryName(RepoDirectoriesProvider.DotnetUnderTest); string dotnetDirectoryPath = Path.GetDirectoryName(RepoDirectoriesProvider.DotnetUnderTest);