Merge pull request #11971 from bruno-garcia/ref/remove-unused-env-var

remove unused env var `DOTNET_SKIP_FIRST_TIME_EXPERIENCE`

eng/common/tools.ps1

@@ -157,9 +157,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
   # Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism
   $env:DOTNET_MULTILEVEL_LOOKUP=0
 
-  # Disable first run since we do not need all ASP.NET packages restored.
-  $env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
-
   # Disable telemetry on CI.
   if ($ci) {
     $env:DOTNET_CLI_TELEMETRY_OPTOUT=1
@@ -231,7 +228,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
   Write-PipelinePrependPath -Path $dotnetRoot
 
   Write-PipelineSetVariable -Name 'DOTNET_MULTILEVEL_LOOKUP' -Value '0'
-  Write-PipelineSetVariable -Name 'DOTNET_SKIP_FIRST_TIME_EXPERIENCE' -Value '1'
 
   return $global:_DotNetInstallDir = $dotnetRoot
 }

eng/common/tools.sh

@@ -111,9 +111,6 @@ function InitializeDotNetCli {
   # Don't resolve runtime, shared framework, or SDK from other locations to ensure build determinism
   export DOTNET_MULTILEVEL_LOOKUP=0
 
-  # Disable first run since we want to control all package sources
-  export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
-
   # Disable telemetry on CI
   if [[ $ci == true ]]; then
     export DOTNET_CLI_TELEMETRY_OPTOUT=1
@@ -165,7 +162,6 @@ function InitializeDotNetCli {
   Write-PipelinePrependPath -path "$dotnet_root"
 
   Write-PipelineSetVariable -name "DOTNET_MULTILEVEL_LOOKUP" -value "0"
-  Write-PipelineSetVariable -name "DOTNET_SKIP_FIRST_TIME_EXPERIENCE" -value "1"
 
   # return value
   _InitializeDotNetCli="$dotnet_root"

eng/core-sdk-build-env.sh

@@ -37,5 +37,4 @@ export PATH=$REPO_ROOT/.dotnet$arcade_partition_suffix:$PATH
 export DOTNET_INSTALL_DIR=$REPO_ROOT/.dotnet$arcade_partition_suffix
 export ArtifactsDir=$REPO_ROOT/artifacts$arcade_partition_suffix/
 
-export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 export DOTNET_MULTILEVEL_LOOKUP=0

eng/core-sdk-test-env.bat

@@ -12,5 +12,4 @@ title Core SDK Test (%CLI_REPO_ROOT%)
 REM Add Stage 2 CLI to path
 set PATH=%CLI_REPO_ROOT%artifacts\bin\redist\Debug\dotnet;%PATH%
 
-set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 set DOTNET_MULTILEVEL_LOOKUP=0

eng/core-sdk-test-env.sh

@@ -17,5 +17,4 @@ STAGE2_DIR=$REPO_ROOT/artifacts/bin/redist/Debug/dotnet
 
 export PATH=$STAGE2_DIR:$PATH
 
-export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 export DOTNET_MULTILEVEL_LOOKUP=0

eng/restore-toolset.ps1

@@ -25,7 +25,6 @@ function CreateBuildEnvScript()
   $scriptContents = @"
 @echo off
 title Core SDK Build ($RepoRoot)
-set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 set DOTNET_MULTILEVEL_LOOKUP=0
 
 set PATH=$env:DOTNET_INSTALL_DIR;%PATH%

src/SourceBuild/tarball/content/build.sh

@@ -152,7 +152,6 @@ fi
 echo "Found bootstrap SDK $SDK_VERSION, bootstrap Arcade $ARCADE_BOOTSTRAP_VERSION, bootstrap SourceLink $SOURCE_LINK_BOOTSTRAP_VERSION"
 
 export DOTNET_CLI_TELEMETRY_OPTOUT=1
-export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 export NUGET_PACKAGES=$restoredPackagesDir/
 
 if [ "$alternateTarget" == "true" ]; then

src/SourceBuild/tarball/content/smoke-test.sh

@@ -11,7 +11,6 @@ __ROOT_REPO=$(sed 's/\r$//' "$SCRIPT_ROOT/artifacts/obj/rootrepo.txt") # remove
 executingUserHome=${HOME:-}
 
 export DOTNET_CLI_TELEMETRY_OPTOUT=1
-export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 
 # Use uname to determine what the CPU is.
 cpuName=$(uname -p)

src/core-sdk-tasks/EnvironmentVariableFilter.cs

@@ -31,7 +31,6 @@ namespace Microsoft.DotNet.Cli.Build
             "DOTNET_CLI_UI_LANGUAGE",
             "DOTNET_MULTILEVEL_LOOKUP",
             "DOTNET_RUNTIME_ID",
-            "DOTNET_SKIP_FIRST_TIME_EXPERIENCE",
             "NUGET_PACKAGES"
         };
 

src/redist/targets/packaging/windows/clisdk/Init.cmd

@@ -1,6 +1,5 @@
 @echo off
 
-set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 set DOTNET_MULTILEVEL_LOOKUP=0
 set PATH=%~dp0;%PATH%
 

test/Microsoft.DotNet.Tools.Tests.Utilities/Commands/TestCommand.cs

@@ -143,7 +143,6 @@ namespace Microsoft.DotNet.Tools.Test.Utilities
             RemoveCliGeneratedEnvironmentVariablesFrom(psi);
 
             psi.Environment["DOTNET_MULTILEVEL_LOOKUP"] = "0";
-            psi.Environment["DOTNET_SKIP_FIRST_TIME_EXPERIENCE"] = "1";
 
             // Set DOTNET_ROOT to ensure sub process find the same host fxr
             string dotnetDirectoryPath = Path.GetDirectoryName(RepoDirectoriesProvider.DotnetUnderTest);