mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #8942 from wli3/better-error-message

Browse source 
Show version guide only when restore fails
This commit is contained in:
Livar 2018-04-02 21:35:55 -07:00 committed by GitHub
commit 0ca2c9fdc8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 188 additions and 94 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx
View file

@ -161,6 +161,9 @@ Tool '{1}' (version '{2}') was successfully installed.</value>
<value>The settings file in the tool's NuGet package is invalid: {0}</value>
</data>
<data name="ToolInstallationFailed" xml:space="preserve">
<value>Tool '{0}' failed to install.</value>
</data>
<data name="ToolInstallationFailedWithExplicitVersionGuide" xml:space="preserve">
<value>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</value>
@ -189,4 +192,4 @@ Tool '{1}' (version '{2}') was successfully installed.</value>
<data name="ToolPathDescription" xml:space="preserve">
<value>Location where the tool will be installed.</value>
</data>
</root>
</root>

2
src/dotnet/commands/dotnet-tool/install/ToolInstallCommandLowLevelErrorConverter.cs
View file

@ -18,7 +18,7 @@ namespace Microsoft.DotNet.Tools.Tool.Install
userFacingMessages = new[]
{
ex.Message,
string.Format(LocalizableStrings.ToolInstallationFailed, packageId),
string.Format(LocalizableStrings.ToolInstallationFailedWithExplicitVersionGuide, packageId),
};
}
else if (ex is ToolConfigurationException)

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.cs.xlf
View file

@ -59,13 +59,6 @@ Nástroj {1} (verze {2}) byl úspěšně nainstalován.</target>
<target state="translated">Soubor nastavení v balíčku NuGet nástroje je neplatný: {0}.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Nástroj {0} se nepodařilo nainstalovat.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Nástroj {0} se nepodařilo nainstalovat. Obraťte se prosím s žádostí o pomoc na autora nástroje.</target>
@ -121,6 +114,20 @@ Nástroj {1} (verze {2}) byl úspěšně nainstalován.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.de.xlf
View file

@ -59,13 +59,6 @@ Das Tool "{1}" (Version "{2}") wurde erfolgreich installiert.</target>
<target state="translated">Die Einstellungsdatei im NuGet-Paket des Tools ist ungültig: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Fehler bei der Installation des Tools "{0}".</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Fehler bei der Installation des Tools "{0}". Wenden Sie sich an den Verfasser des Tools, um Unterstützung zu erhalten.</target>
@ -121,6 +114,20 @@ Das Tool "{1}" (Version "{2}") wurde erfolgreich installiert.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.es.xlf
View file

@ -59,13 +59,6 @@ La herramienta "{1}" (versión "{2}") se instaló correctamente.</target>
<target state="translated">El archivo de configuración del paquete NuGet de la herramienta no es válido: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">No se pudo instalar la herramienta “{0}”.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">No se pudo instalar la herramienta “{0}”. Póngase en contacto con su creador para obtener asistencia.</target>
@ -121,6 +114,20 @@ La herramienta "{1}" (versión "{2}") se instaló correctamente.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.fr.xlf
View file

@ -59,13 +59,6 @@ L'outil '{1}' (version '{2}') a été installé.</target>
<target state="translated">Le fichier de paramètres dans le package NuGet de l'outil n'est pas valide : {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Impossible d'installer l'outil '{0}'.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Impossible d'installer l'outil '{0}'. Contactez le créateur de l'outil pour obtenir de l'aide.</target>
@ -121,6 +114,20 @@ L'outil '{1}' (version '{2}') a été installé.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.it.xlf
View file

@ -59,13 +59,6 @@ Lo strumento '{1}' (versione '{2}') è stato installato.</target>
<target state="translated">Il file di impostazioni nel pacchetto NuGet dello strumento non è valido: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Non è stato possibile installare lo strumento '{0}'.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Non è stato possibile installare lo strumento '{0}'. Per assistenza, contattare l'autore dello strumento.</target>
@ -121,6 +114,20 @@ Lo strumento '{1}' (versione '{2}') è stato installato.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ja.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">ツールの NuGet パッケージ内の設定ファイルが無効です: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">ツール '{0}' をインストールできませんでした。</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">ツール '{0}' をインストールできませんでした。ツールの作成者にお問い合わせください。</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ko.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">도구의 NuGet 패키지에 있는 설정 파일이 잘못되었습니다. {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">'{0}' 도구를 설치하지 못했습니다.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">'{0}' 도구를 설치하지 못했습니다. 도구 작성자에게 문의하세요.</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.pl.xlf
View file

@ -59,13 +59,6 @@ Pomyślnie zainstalowano narzędzie „{1}” (wersja: „{2}”).</target>
<target state="translated">Plik ustawień w pakiecie NuGet narzędzia jest nieprawidłowy: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Zainstalowanie narzędzia „{0}” nie powiodło się.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Zainstalowanie narzędzia „{0}” nie powiodło się. Skontaktuj się z autorem narzędzia w celu uzyskania pomocy.</target>
@ -121,6 +114,20 @@ Pomyślnie zainstalowano narzędzie „{1}” (wersja: „{2}”).</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.pt-BR.xlf
View file

@ -59,13 +59,6 @@ A ferramenta '{1}' (versão '{2}') foi instalada com êxito.</target>
<target state="translated">O arquivo de configurações no pacote NuGet da ferramenta é inválido: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Não foi possível instalar a ferramenta '{0}'.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Não foi possível instalar a ferramenta '{0}'. Entre em contato com o autor da ferramenta para obter assistência.</target>
@ -121,6 +114,20 @@ A ferramenta '{1}' (versão '{2}') foi instalada com êxito.</target>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ru.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">Недопустимый файл параметров в пакете NuGet инструмента: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">Не удалось установить инструмент "{0}".</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">Не удалось установить инструмент "{0}". Обратитесь за помощью к его разработчику.</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.tr.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">Aracın NuGet paketindeki ayar dosyası geçersiz: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">'{0}' aracı yüklenemedi.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">'{0}' aracı yüklenemedi. Lütfen yardım için araç sahibiyle iletişime geçin.</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.zh-Hans.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">工具的 NuGet 包中的设置文件无效: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">工具“{0}”安装失败。</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">工具“{0}”安装失败。请联系工具作者获取帮助。</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

21
src/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.zh-Hant.xlf
View file

@ -59,13 +59,6 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="translated">工具之 NuGet 套件中的設定檔案無效: {0}</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="needs-review-translation">工具 '{0}' 無法安裝。</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedContactAuthor">
<source>Tool '{0}' failed to install. Please contact the tool author for assistance.</source>
<target state="translated">工具 '{0}' 無法安裝。請連絡工具作者尋求協助。</target>
@ -121,6 +114,20 @@ Tool '{1}' (version '{2}') was successfully installed.</source>
<target state="new">SOURCE_FEED</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailed">
<source>Tool '{0}' failed to install.</source>
<target state="new">Tool '{0}' failed to install.</target>
<note />
</trans-unit>
<trans-unit id="ToolInstallationFailedWithExplicitVersionGuide">
<source>Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</source>
<target state="new">Tool '{0}' failed to install. You may need to specify the version using
dotnet tool install -g {0} --version &lt;version&gt;</target>
<note />
</trans-unit>
</body>
</file>
</xliff>

2
test/dotnet.Tests/CommandTests/ToolInstallCommandTests.cs
View file

@ -360,7 +360,7 @@ namespace Microsoft.DotNet.Tests.Commands
a.ShouldThrow<GracefulException>().And.Message
.Should().Contain(
LocalizableStrings.ToolInstallationRestoreFailed +
Environment.NewLine + string.Format(LocalizableStrings.ToolInstallationFailed, PackageId));
Environment.NewLine + string.Format(LocalizableStrings.ToolInstallationFailedWithExplicitVersionGuide, PackageId));
_fileSystem.Directory.Exists(Path.Combine(PathToPlacePackages, PackageId)).Should().BeFalse();
}