From 084c161943ff64e03cd3952ac635db4bf72d3f5f Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Wed, 8 Nov 2023 17:34:45 -0600 Subject: [PATCH] Remove redundant xml doc test (#17734) --- .../XmlDocTests.cs | 48 ----- .../assets/baselines/MissingXmlDoc.txt | 175 ------------------ 2 files changed, 223 deletions(-) delete mode 100644 src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/XmlDocTests.cs delete mode 100644 src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/baselines/MissingXmlDoc.txt diff --git a/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/XmlDocTests.cs b/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/XmlDocTests.cs deleted file mode 100644 index f8f4f2c8b..000000000 --- a/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/XmlDocTests.cs +++ /dev/null @@ -1,48 +0,0 @@ -// Licensed to the .NET Foundation under one or more agreements. -// The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. - -using System.Collections.Generic; -using System.IO; -using System.Linq; -using Xunit; -using Xunit.Abstractions; - -namespace Microsoft.DotNet.SourceBuild.SmokeTests; - -public class XmlDocTests : SmokeTests -{ - public XmlDocTests(ITestOutputHelper outputHelper) : base(outputHelper) { } - - /// - /// Verifies every targeting pack assembly has a xml doc file. - /// There are exceptions which are specified in baselines/XmlDocIgnore.*.txt. - /// - // Re-enable when fixing https://github.com/dotnet/source-build/issues/3660 - //[Fact] - public void VerifyTargetingPacksHaveDoc() - { - List missingXmlDoc = new(); - - string targetingPacksDirectory = Path.Combine(Config.DotNetDirectory, "packs"); - foreach (string targetingPackAssembly in Directory.EnumerateFiles(targetingPacksDirectory, "*.dll", SearchOption.AllDirectories)) - { - if (targetingPackAssembly.EndsWith("resources.dll")) - { - continue; - } - - string xmlFile = Path.ChangeExtension(targetingPackAssembly, ".xml"); - if (!File.Exists(xmlFile)) - { - string pathWithoutPacksPrefix = xmlFile[(targetingPacksDirectory.Length + 1)..]; - string[] pathParts = pathWithoutPacksPrefix.Split(Path.DirectorySeparatorChar); - string pathWithoutVersion = string.Join(Path.DirectorySeparatorChar, pathParts.Take(1).Concat(pathParts.Skip(2))); - pathWithoutVersion = BaselineHelper.RemoveNetTfmPaths(pathWithoutVersion); - missingXmlDoc.Add(pathWithoutVersion); - } - } - - BaselineHelper.CompareEntries("MissingXmlDoc.txt", missingXmlDoc.OrderBy(entry => entry)); - } -} diff --git a/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/baselines/MissingXmlDoc.txt b/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/baselines/MissingXmlDoc.txt deleted file mode 100644 index 38f80e186..000000000 --- a/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/baselines/MissingXmlDoc.txt +++ /dev/null @@ -1,175 +0,0 @@ -Microsoft.AspNetCore.App.Ref/analyzers/dotnet/cs/Microsoft.AspNetCore.App.Analyzers.xml -Microsoft.AspNetCore.App.Ref/analyzers/dotnet/cs/Microsoft.AspNetCore.App.CodeFixes.xml -Microsoft.AspNetCore.App.Ref/analyzers/dotnet/roslyn4.0/cs/Microsoft.Extensions.Logging.Generators.xml -Microsoft.NETCore.App.Ref/analyzers/dotnet/cs/System.Text.Json.SourceGeneration.xml -Microsoft.NETCore.App.Ref/ref/netx.y/Microsoft.VisualBasic.xml -Microsoft.NETCore.App.Ref/ref/netx.y/mscorlib.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.AppContext.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Buffers.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.ComponentModel.DataAnnotations.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Configuration.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Core.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Data.DataSetExtensions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Data.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Diagnostics.Debug.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Diagnostics.Tools.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Drawing.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Dynamic.Runtime.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Globalization.Calendars.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Globalization.Extensions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Globalization.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.Compression.Brotli.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.Compression.FileSystem.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.FileSystem.Primitives.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.FileSystem.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.UnmanagedMemoryStream.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.IO.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Net.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Numerics.Vectors.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Numerics.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Reflection.Extensions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Reflection.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Resources.Reader.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Resources.ResourceManager.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Runtime.Extensions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Runtime.Handles.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Runtime.Serialization.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Security.Principal.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Security.SecureString.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Security.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.ServiceModel.Web.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.ServiceProcess.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Text.Encoding.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Threading.Tasks.Extensions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Threading.Tasks.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Threading.Timer.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Transactions.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.ValueTuple.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Web.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Windows.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Xml.Linq.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Xml.Serialization.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Xml.xml -Microsoft.NETCore.App.Ref/ref/netx.y/System.Xml.XmlDocument.xml -Microsoft.NETCore.App.Ref/ref/netx.y/WindowsBase.xml -NETStandard.Library.Ref/ref/netstandard2.1/Microsoft.Win32.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/mscorlib.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.AppContext.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Buffers.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Collections.Concurrent.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Collections.NonGeneric.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Collections.Specialized.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Collections.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ComponentModel.Composition.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ComponentModel.EventBasedAsync.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ComponentModel.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ComponentModel.TypeConverter.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ComponentModel.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Console.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Core.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Data.Common.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Data.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.Contracts.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.Debug.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.FileVersionInfo.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.Process.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.StackTrace.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.TextWriterTraceListener.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.Tools.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.TraceSource.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Diagnostics.Tracing.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Drawing.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Drawing.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Dynamic.Runtime.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Globalization.Calendars.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Globalization.Extensions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Globalization.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.Compression.FileSystem.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.Compression.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.Compression.ZipFile.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.FileSystem.DriveInfo.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.FileSystem.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.FileSystem.Watcher.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.FileSystem.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.IsolatedStorage.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.MemoryMappedFiles.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.Pipes.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.UnmanagedMemoryStream.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.IO.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Linq.Expressions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Linq.Parallel.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Linq.Queryable.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Linq.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Memory.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Http.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.NameResolution.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.NetworkInformation.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Ping.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Requests.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Security.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.Sockets.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.WebHeaderCollection.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.WebSockets.Client.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.WebSockets.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Net.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Numerics.Vectors.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Numerics.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ObjectModel.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.DispatchProxy.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.Emit.ILGeneration.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.Emit.Lightweight.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.Emit.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.Extensions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Reflection.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Resources.Reader.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Resources.ResourceManager.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Resources.Writer.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.CompilerServices.VisualC.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Extensions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Handles.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.InteropServices.RuntimeInformation.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.InteropServices.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Numerics.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Serialization.Formatters.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Serialization.Json.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Serialization.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Serialization.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.Serialization.Xml.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Runtime.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Claims.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Cryptography.Algorithms.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Cryptography.Csp.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Cryptography.Encoding.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Cryptography.Primitives.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Cryptography.X509Certificates.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.Principal.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Security.SecureString.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ServiceModel.Web.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Text.Encoding.Extensions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Text.Encoding.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Text.RegularExpressions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Overlapped.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Tasks.Extensions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Tasks.Parallel.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Tasks.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Thread.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.ThreadPool.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.Timer.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Threading.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Transactions.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.ValueTuple.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Web.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Windows.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.Linq.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.ReaderWriter.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.Serialization.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.XDocument.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.XmlDocument.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.XmlSerializer.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.XPath.XDocument.xml -NETStandard.Library.Ref/ref/netstandard2.1/System.Xml.XPath.xml