From 07b074acf7d9964103754e44584e501b6e6efee8 Mon Sep 17 00:00:00 2001 From: John Beisner Date: Wed, 17 Apr 2019 12:53:05 -0700 Subject: [PATCH] adding .Net core AppHost pack (#1519) * adding .Net core AppHost pack --- eng/Versions.props | 1 + src/redist/targets/Branding.targets | 1 + src/redist/targets/GenerateDebs.targets | 13 ++++++++++ src/redist/targets/GenerateLayout.targets | 20 +++++++++----- src/redist/targets/GenerateMSIs.targets | 1 + src/redist/targets/GeneratePKG.targets | 15 +++++++++-- src/redist/targets/GenerateRPMs.targets | 11 ++++++++ .../packaging/deb/dotnet-debian_config.json | 1 + .../osx/clisdk/Distribution-Template | 5 ++++ .../targets/packaging/rpm/dotnet-config.json | 4 +++ .../packaging/windows/clisdk/bundle.wxs | 3 +++ .../windows/clisdk/generatebundle.ps1 | 26 ++++++++++++------- 12 files changed, 83 insertions(+), 18 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index a880a6ce5..269e096b4 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -49,6 +49,7 @@ $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftNETCoreAppPackageVersion) + $(MicrosoftNETCoreAppPackageVersion) 2.1.0-preview5-27617-04 $(MicrosoftNETCoreAppPackageVersion) $(MicrosoftAspNetCoreAppRuntimeWinX64PackageVersion) diff --git a/src/redist/targets/Branding.targets b/src/redist/targets/Branding.targets index ee93a70c0..9f81239cd 100644 --- a/src/redist/targets/Branding.targets +++ b/src/redist/targets/Branding.targets @@ -7,6 +7,7 @@ Microsoft .NET Core Runtime $(MicrosoftNETCoreAppPackageVersion) Microsoft .NET Core Targeting Pack $(MicrosoftNETCoreAppPackageVersion) Microsoft .NET Standard 2.1 Targeting Pack $(MicrosoftNETCoreAppPackageVersion) + Microsoft .NET AppHost Pack $(MicrosoftNETCoreAppPackageVersion) Microsoft .NET Core Host $(MicrosoftNETCoreAppPackageVersion) Microsoft .NET Core Host FX Resolver $(MicrosoftNETCoreAppPackageVersion) Microsoft.NETCore.App diff --git a/src/redist/targets/GenerateDebs.targets b/src/redist/targets/GenerateDebs.targets index 096596c28..5b9254aa2 100644 --- a/src/redist/targets/GenerateDebs.targets +++ b/src/redist/targets/GenerateDebs.targets @@ -53,6 +53,11 @@ netstandard-targeting-pack-$(NETStandardLibraryRefPackageVersion.Split('.')[0]).$(NETStandardLibraryRefPackageVersion.Split('.')[1]) $(NetStandardTargetingPackDebianPackageName.ToLower()) $(DownloadsFolder)$(DownloadedNetStandardTargetingPackInstallerFileName) + dotnet-apphost-pack-$(SharedFxDebianPackageFileVersion) + $(NetCoreAppHostPackDebianPackageFileName.ToLower()) + dotnet-apphost-pack-$(SharedFxDebianPackageVersion) + $(NetCoreAppHostPackDebianPackageName.ToLower()) + $(DownloadsFolder)$(DownloadedNetCoreAppHostPackInstallerFileName) dotnet-hostfxr-$(HostFxrVersion) $(HostFxrDebianPackageFileName.ToLower()) dotnet-hostfxr-$(HostFxrMajorMinorVersion) @@ -125,6 +130,9 @@ $(NetCoreAppTargetingPackDebianPackageName) + + $(NetCoreAppHostPackDebianPackageName) + $(NetStandardTargetingPackDebianPackageName) @@ -222,6 +230,7 @@ Inputs="@(CLISdkFiles)" Outputs="$(SdkDebInstallerFile)" > + @@ -305,6 +314,7 @@ + @@ -316,6 +326,7 @@ Condition=" '$(CLIBUILD_SKIP_TESTS)' != 'true' and '$(IsDebianBaseDistro)' == 'True' and '$(DebuildPresent)' == 'true' " DependsOnTargets="GetAspNetSharedFxInstallArgs" Inputs="$(DownloadedRuntimeDepsInstallerFile); + $(DownloadedNetCoreAppHostPackInstallerFile); $(DownloadedNetCoreAppTargetingPackInstallerFile); $(DownloadedNetStandardTargetingPackInstallerFile); $(DownloadedAspNetTargetingPackInstallerFile); @@ -329,6 +340,7 @@ + @@ -359,6 +371,7 @@ + diff --git a/src/redist/targets/GenerateLayout.targets b/src/redist/targets/GenerateLayout.targets index b0afc9f1a..50b4e54c8 100644 --- a/src/redist/targets/GenerateLayout.targets +++ b/src/redist/targets/GenerateLayout.targets @@ -29,6 +29,7 @@ dotnet-runtime$(InstallerStartSuffix)-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) windowsdesktop-runtime-$(MicrosoftWindowsDesktopPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) dotnet-targeting-pack-$(NetCoreAppTargetingPackVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) + dotnet-apphost-pack-$(NetCoreAppHostPackVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) windowsdesktop-targeting-pack-$(WindowsDesktopTargetingPackVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) netstandard-targeting-pack-$(NETStandardLibraryRefPackageVersion)-$(SharedFrameworkInstallerFileRid)$(InstallerExtension) netstandard$(NETStandardLibraryRefPackageVersion.Split('.')[0])$(NETStandardLibraryRefPackageVersion.Split('.')[1]) @@ -71,7 +72,7 @@ win-x64 win-x86 - + $(CoreSetupRootUrl)$(MicrosoftNETCoreAppPackageVersion) @@ -109,15 +110,15 @@ - runtime.$(SharedFrameworkRid).Microsoft.NETCore.DotNetAppHost - $(NetCoreAppTargetingPackVersion) + Microsoft.NETCore.App.Host.$(SharedFrameworkRid) + $(NetCoreAppHostPackVersion) $(TargetFramework) packs/%(PackageName)/%(PackageVersion) - - runtime.$(AlternateAppHostRid).Microsoft.NETCore.DotNetAppHost - $(NetCoreAppTargetingPackVersion) + + Microsoft.NETCore.App.Host.$(AlternateAppHostRid) + $(NetCoreAppHostPackVersion) $(TargetFramework) packs/%(PackageName)/%(PackageVersion) @@ -163,6 +164,13 @@ $(DownloadedNetStandardTargetingPackInstallerFileName) $(CoreSetupBlobAccessTokenParam) + + + $(CoreSetupRootUrl)$(MicrosoftNETCoreAppPackageVersion) + $(DownloadedNetCoreAppHostPackInstallerFileName) + $(CoreSetupBlobAccessTokenParam) + diff --git a/src/redist/targets/GenerateMSIs.targets b/src/redist/targets/GenerateMSIs.targets index 39b25f31b..77a06cef1 100644 --- a/src/redist/targets/GenerateMSIs.targets +++ b/src/redist/targets/GenerateMSIs.targets @@ -140,6 +140,7 @@ '$(DownloadsFolder)$(DownloadedWinFormsAndWpfSharedFrameworkInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedNetCoreAppTargetingPackInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedNetStandardTargetingPackInstallerFileName)' ^ + '$(DownloadsFolder)$(DownloadedNetCoreAppHostPackInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedAspNetTargetingPackInstallerFileName)' ^ '$(DownloadsFolder)$(DownloadedWindowsDesktopTargetingPackInstallerFileName)' ^ '$(CombinedFrameworkSdkHostMSIInstallerFile)' ^ diff --git a/src/redist/targets/GeneratePKG.targets b/src/redist/targets/GeneratePKG.targets index 55f132b97..9add88c7f 100644 --- a/src/redist/targets/GeneratePKG.targets +++ b/src/redist/targets/GeneratePKG.targets @@ -7,8 +7,9 @@ com.microsoft.dotnet.sharedhost.$(SharedHostVersion).component.osx.x64 com.microsoft.dotnet.hostfxr.$(HostFxrVersion).component.osx.x64 com.microsoft.dotnet.sharedframework.$(SharedFrameworkNugetName).$(MicrosoftNETCoreAppPackageVersion).component.osx.x64 - com.microsoft.dotnet.pack.targeting.$(MicrosoftNETCoreAppPackageVersion).component.osx.x64 - com.microsoft.standard.pack.targeting.$(MicrosoftNETCoreAppPackageVersion).component.osx.x64 + com.microsoft.dotnet.pack.targeting.$(NetCoreAppTargetingPackVersion).component.osx.x64 + com.microsoft.dotnet.pack.apphost.$(NetCoreAppHostPackVersion).component.osx.x64 + com.microsoft.standard.pack.targeting.$(NETStandardLibraryRefPackageVersion).component.osx.x64 com.microsoft.dotnet.dev.$(SdkVersion).component.osx.x64 com.microsoft.dotnet.dev.$(SdkVersion).osx.x64 @@ -27,6 +28,7 @@ $(PkgIntermediateDirectory)/$(SdkComponentId).pkg $(PkgIntermediateDirectory)/$(SharedFrameworkComponentId).pkg $(PkgIntermediateDirectory)/$(NetCoreAppTargetingPackComponentId).pkg + $(PkgIntermediateDirectory)/$(NetCoreAppHostPackComponentId).pkg $(PkgIntermediateDirectory)/$(NetStandardTargetingPackComponentId).pkg $(PkgIntermediateDirectory)/$(SharedHostComponentId).pkg $(PkgIntermediateDirectory)/$(HostFxrComponentId).pkg @@ -47,6 +49,9 @@ $(NetStandardTargetingPackComponentId) + + $(NetCoreAppHostPackComponentId) + $(SharedHostComponentId) @@ -68,6 +73,9 @@ $(NetCoreAppTargetingPackBrandName) + + $(NetCoreAppHostPackBrandName) + $(NetStandardTargetingPackBrandName) @@ -107,6 +115,7 @@ + @@ -161,12 +170,14 @@ diff --git a/src/redist/targets/GenerateRPMs.targets b/src/redist/targets/GenerateRPMs.targets index 82f54461a..bfec4fdc4 100644 --- a/src/redist/targets/GenerateRPMs.targets +++ b/src/redist/targets/GenerateRPMs.targets @@ -85,6 +85,9 @@ $(NetCoreAppTargetingPackRpmPackageName) + + $(NetCoreAppHostPackRpmPackageName) + $(NetStandardTargetingPackRpmPackageName) @@ -196,6 +199,10 @@ $(NetCoreAppTargetingPackRpmPackageName.ToLower()) dotnet-targeting-pack-$(SharedFxRpmPackageFileVersion) $(NetCoreAppTargetingPackRpmPackageFileName.ToLower()) + dotnet-apphost-pack-$(SharedFxRpmPackageVersion) + $(NetCoreAppHostPackRpmPackageName.ToLower()) + dotnet-apphost-pack-$(SharedFxRpmPackageFileVersion) + $(NetCoreAppHostPackRpmPackageFileName.ToLower()) netstandard-targeting-pack-$(NETStandardLibraryRefPackageVersion.Split('.')[0]).$(NETStandardLibraryRefPackageVersion.Split('.')[1]) $(NetStandardTargetingPackRpmPackageName.ToLower()) netstandard-targeting-pack-$(NETStandardLibraryRefPackageVersion) @@ -220,6 +227,7 @@ $(DownloadsFolder)$(DownloadedNetCoreAppTargetingPackInstallerFileName) $(DownloadsFolder)$(DownloadedNetStandardTargetingPackInstallerFileName) + $(DownloadsFolder)$(DownloadedNetCoreAppHostPackInstallerFileName) $(DownloadsFolder)$(DownloadedAspNetTargetingPackInstallerFileName) $(DownloadsFolder)$(DownloadedRuntimeDepsInstallerFileName) $(DownloadsFolder)$(DownloadedSharedHostInstallerFileName) @@ -253,6 +261,7 @@ Condition=" '$(CLIBUILD_SKIP_TESTS)' != 'true' and '$(IsRPMBasedDistro)' == 'True' and '$(FPMPresent)' == 'True' " Inputs="$(DownloadedNetCoreAppTargetingPackInstallerFile); $(DownloadedNetStandardTargetingPackInstallerFile); + $(DownloadedNetCoreAppHostPackInstallerFile); $(DownloadedAspNetTargetingPackInstallerFile); $(DownloadedRuntimeDepsInstallerFile); $(DownloadedSharedHostInstallerFile); @@ -265,6 +274,7 @@ + @@ -292,6 +302,7 @@ + diff --git a/src/redist/targets/packaging/deb/dotnet-debian_config.json b/src/redist/targets/packaging/deb/dotnet-debian_config.json index 1c8b64dae..35a0f433f 100644 --- a/src/redist/targets/packaging/deb/dotnet-debian_config.json +++ b/src/redist/targets/packaging/deb/dotnet-debian_config.json @@ -31,6 +31,7 @@ "debian_dependencies":{ "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_NAME%": { "package_version": "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_VERSION%" }%SHARED_FRAMEWORK_DEBIAN_PACKAGE_ADDITIONAL_DEPENDENCY%, "%NETCOREAPP_TARGETING_PACK_DEBIAN_PACKAGE_NAME%": { "package_version": "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_VERSION%" }, + "%NETCORE_APPHOST_PACK_DEBIAN_PACKAGE_NAME%": { "package_version": "%SHARED_FRAMEWORK_DEBIAN_PACKAGE_VERSION%" }, "%NETSTANDARD_TARGETING_PACK_DEBIAN_PACKAGE_NAME%": { "package_version": "%NET_STANDARD_DEBIAN_PACKAGE_VERSION%" }, "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_NAME%": { "package_version": "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_VERSION%" }, "%ASPNET_TARGETING_PACK_DEBIAN_PACKAGE_NAME%": { "package_version": "%ASPNETCORE_SHAREDFX_DEBIAN_PACKAGE_VERSION%" } diff --git a/src/redist/targets/packaging/osx/clisdk/Distribution-Template b/src/redist/targets/packaging/osx/clisdk/Distribution-Template index 912876cbe..036710240 100644 --- a/src/redist/targets/packaging/osx/clisdk/Distribution-Template +++ b/src/redist/targets/packaging/osx/clisdk/Distribution-Template @@ -13,6 +13,7 @@ + @@ -24,6 +25,9 @@ + + + @@ -38,6 +42,7 @@ {NetCoreAppTargetingPackComponentId}.pkg {NetStandardTargetingPackComponentId}.pkg + {NetCoreAppHostPackComponentId}.pkg {SharedFxComponentId}.pkg {HostFxrComponentId}.pkg {SharedHostComponentId}.pkg diff --git a/src/redist/targets/packaging/rpm/dotnet-config.json b/src/redist/targets/packaging/rpm/dotnet-config.json index 8128e9a9a..fd090e2d8 100644 --- a/src/redist/targets/packaging/rpm/dotnet-config.json +++ b/src/redist/targets/packaging/rpm/dotnet-config.json @@ -30,6 +30,10 @@ "package_name": "%NETCOREAPP_TARGETING_PACK_RPM_PACKAGE_NAME%", "package_version": "%SHARED_FRAMEWORK_RPM_PACKAGE_VERSION%" }, + { + "package_name": "%NETCORE_APPHOST_PACK_RPM_PACKAGE_NAME%", + "package_version": "%SHARED_FRAMEWORK_RPM_PACKAGE_VERSION%" + }, { "package_name": "%NETSTANDARD_TARGETING_PACK_RPM_PACKAGE_NAME%", "package_version": "%NETSTANDARD_TARGETING_PACK_RPM_PACKAGE_VERSION%" diff --git a/src/redist/targets/packaging/windows/clisdk/bundle.wxs b/src/redist/targets/packaging/windows/clisdk/bundle.wxs index 3225f7a5a..e7f2020c7 100644 --- a/src/redist/targets/packaging/windows/clisdk/bundle.wxs +++ b/src/redist/targets/packaging/windows/clisdk/bundle.wxs @@ -130,6 +130,9 @@ + + + diff --git a/src/redist/targets/packaging/windows/clisdk/generatebundle.ps1 b/src/redist/targets/packaging/windows/clisdk/generatebundle.ps1 index 5d1219af3..94910f6e6 100644 --- a/src/redist/targets/packaging/windows/clisdk/generatebundle.ps1 +++ b/src/redist/targets/packaging/windows/clisdk/generatebundle.ps1 @@ -9,6 +9,7 @@ param( [Parameter(Mandatory=$true)][string]$SharedHostMSIFile, [Parameter(Mandatory=$true)][string]$WinFormsAndWpfMSIFile, [Parameter(Mandatory=$true)][string]$NetCoreAppTargetingPackMSIFile, + [Parameter(Mandatory=$true)][string]$NetCoreAppHostPackMSIFile, [Parameter(Mandatory=$true)][string]$NetStandardTargetingPackMSIFile, [Parameter(Mandatory=$true)][string]$AspNetTargetingPackMSIFile, [Parameter(Mandatory=$true)][string]$WindowsDesktopTargetingPackMSIFile, @@ -31,10 +32,10 @@ function RunCandleForBundle $result = $true pushd "$WixRoot" - Write-Output Running candle for bundle.. + Write-Information "Running candle for bundle.." $AuthWsxRoot = $PSScriptRoot - .\candle.exe -nologo ` + $candleOutput = .\candle.exe -nologo ` -dDotnetSrc="$inputDir" ` -dMicrosoftEula="$PSScriptRoot\dummyeula.rtf" ` -dProductMoniker="$ProductMoniker" ` @@ -49,6 +50,7 @@ function RunCandleForBundle -dSharedHostMsiSourcePath="$SharedHostMSIFile" ` -dWinFormsAndWpfMsiSourcePath="$WinFormsAndWpfMSIFile" ` -dNetCoreAppTargetingPackMsiSourcePath="$NetCoreAppTargetingPackMSIFile" ` + -dNetCoreAppHostPackMsiSourcePath="$NetCoreAppHostPackMSIFile" ` -dNetStandardTargetingPackMsiSourcePath="$NetStandardTargetingPackMSIFile" ` -dAspNetTargetingPackMsiSourcePath="$AspNetTargetingPackMSIFile" ` -dWindowsDesktopTargetingPackMsiSourcePath="$WindowsDesktopTargetingPackMSIFile" ` @@ -62,12 +64,14 @@ function RunCandleForBundle -ext WixBalExtension.dll ` -ext WixUtilExtension.dll ` -ext WixTagExtension.dll ` - "$AuthWsxRoot\bundle.wxs" | Out-Host + "$AuthWsxRoot\bundle.wxs" + + Write-Information "Candle output: $candleOutput" if($LastExitCode -ne 0) { $result = $false - Write-Output "Candle failed with exit code $LastExitCode." + Write-Information "Candle failed with exit code $LastExitCode." } popd @@ -79,10 +83,10 @@ function RunLightForBundle $result = $true pushd "$WixRoot" - Write-Output Running light for bundle.. + Write-Information "Running light for bundle.." $AuthWsxRoot = $PSScriptRoot - .\light.exe -nologo ` + $lightOutput = .\light.exe -nologo ` -cultures:en-us ` bundle.wixobj ` $ASPNETRuntimeWixlibFile ` @@ -90,12 +94,14 @@ function RunLightForBundle -ext WixUtilExtension.dll ` -ext WixTagExtension.dll ` -b "$AuthWsxRoot" ` - -out $DotnetBundleOutput | Out-Host + -out $DotnetBundleOutput + + Write-Information "Light output: $lightOutput" if($LastExitCode -ne 0) { $result = $false - Write-Output "Light failed with exit code $LastExitCode." + Write-Information "Light failed with exit code $LastExitCode." } popd @@ -113,7 +119,7 @@ if(!(Test-Path $ASPNETRuntimeWixLibFile)) throw "$ASPNETRuntimeWixLibFile not found" } -Write-Output "Creating dotnet Bundle at $DotnetBundleOutput" +Write-Information "Creating dotnet Bundle at $DotnetBundleOutput" if([string]::IsNullOrEmpty($WixRoot)) { @@ -136,6 +142,6 @@ if(!(Test-Path $DotnetBundleOutput)) Exit -1 } -Write-Output "Successfully created dotnet bundle - $DotnetBundleOutput" +Write-Information "Successfully created dotnet bundle - $DotnetBundleOutput" exit $LastExitCode