From cea92349d3002ced48cc768cd35e5fb3472f6092 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Thu, 25 Feb 2021 11:30:48 -0800 Subject: [PATCH 1/2] Update branding for 5.0.2xx 5.0.2xx --- eng/Versions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index 107bfe842..48e2766dc 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -8,7 +8,7 @@ 5 0 2 - 00 + 02 $(VersionMajor).$(VersionMinor).$(VersionSDKMinor)$(VersionFeature) servicing $(VersionMajor).$(VersionMinor) From beafdfb94215e62ab01f3b1825b7e810ef04f150 Mon Sep 17 00:00:00 2001 From: William Li Date: Thu, 10 Dec 2020 13:51:19 -0800 Subject: [PATCH 2/2] Update implicit versions Disable and fix tests do not work with non-existent LastRuntimeFrameworkVersion --- ...venWeWantToRequireWindowsForDesktopApps.cs | 20 ++++++++++++++- test/SdkTests/TestConfig.xml | 25 +++++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs b/test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs index f6d55f644..235e8a4cf 100644 --- a/test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs +++ b/test/EndToEnd/GivenWeWantToRequireWindowsForDesktopApps.cs @@ -3,6 +3,7 @@ using System; using System.IO; +using System.Xml.Linq; using EndToEnd; using FluentAssertions; using Microsoft.DotNet.Tools.Test.Utilities; @@ -48,7 +49,24 @@ namespace Microsoft.DotNet.Tests.EndToEnd testProjectCreator.AdditionalProperties["OutputType"] = "exe"; testProjectCreator.AdditionalProperties["RuntimeIdentifier"] = Rid; - var testInstance = testProjectCreator.Create(); + // At certain point of the release cycle LatestRuntimeFrameworkVersion in eng folder may not exist on the nuget feed + static void overrideLastRuntimeFrameworkVersionToExistingOlderVersion(XDocument project) + { + XNamespace ns = project.Root.Name.Namespace; + var target = XElement.Parse(@" + + 3.1.10 + + + + 3.1.10 + + "); + target.Name = ns + target.Name.LocalName; + project.Root.Add(target); + } + TestFramework.TestAssetInstance testInstance + = testProjectCreator.Create().WithProjectChanges(overrideLastRuntimeFrameworkVersionToExistingOlderVersion); new PublishCommand() .WithWorkingDirectory(testInstance.Root.FullName) diff --git a/test/SdkTests/TestConfig.xml b/test/SdkTests/TestConfig.xml index 794dd1478..b652d18ae 100644 --- a/test/SdkTests/TestConfig.xml +++ b/test/SdkTests/TestConfig.xml @@ -141,5 +141,30 @@ Skip="true" Issue="" Reason="Need all .NET core runtime"/> + + + + + + +