From 1752be0f1cceb71df731d721b4347d2767837652 Mon Sep 17 00:00:00 2001 From: William Li Date: Tue, 14 Aug 2018 15:43:31 -0700 Subject: [PATCH 1/4] Revert "Disabled MSBuildTreatWarningsAsErrors" This reverts commit 5635f0d0648e9eb3b6a8f150d5589846da021cae. --- build/BuildDefaults.props | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build/BuildDefaults.props b/build/BuildDefaults.props index 053ea0a83..1f26ed860 100644 --- a/build/BuildDefaults.props +++ b/build/BuildDefaults.props @@ -33,7 +33,6 @@ NU1701;NU5104 true - - + true From cae6528834e7f9d538a7926656ead825f213d404 Mon Sep 17 00:00:00 2001 From: William Li Date: Tue, 14 Aug 2018 15:48:15 -0700 Subject: [PATCH 2/4] Use prebuild image --- scripts/docker/debian/Dockerfile | 34 +------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/scripts/docker/debian/Dockerfile b/scripts/docker/debian/Dockerfile index d54afeb0e..281778513 100644 --- a/scripts/docker/debian/Dockerfile +++ b/scripts/docker/debian/Dockerfile @@ -4,47 +4,15 @@ # # Dockerfile that creates a container suitable to build dotnet-cli -FROM debian:jessie +FROM microsoft/dotnet-buildtools-prereqs:debian-8.2-debpkg-d770b8b-20180628122423 # Misc Dependencies for build RUN apt-get update && \ apt-get -qqy install \ - curl \ - unzip \ - gettext \ sudo && \ apt-get clean && \ rm -rf /var/lib/apt/lists/* -# This could become a "microsoft/coreclr" image, since it just installs the dependencies for CoreCLR (and stdlib) -RUN apt-get update &&\ - apt-get -qqy install \ - libunwind8 \ - libkrb5-3 \ - libicu52 \ - liblttng-ust0 \ - libssl1.0.0 \ - zlib1g \ - libuuid1 && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists/* - -# Install Build Prereqs -RUN apt-get update && \ - apt-get -qqy install \ - debhelper \ - build-essential \ - devscripts \ - git \ - cmake \ - clang-3.5 && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists/* - -# Use clang as c++ compiler -RUN update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++-3.5 100 -RUN update-alternatives --set c++ /usr/bin/clang++-3.5 - # Setup User to match Host User, and give superuser permissions ARG USER_ID=0 RUN useradd -m code_executor -u ${USER_ID} -g sudo From 25509d31b174b746e7c32777b987c7832c2e77db Mon Sep 17 00:00:00 2001 From: William Li Date: Wed, 15 Aug 2018 12:40:09 -0700 Subject: [PATCH 3/4] Remove redundent call, ensure no apt list --- build/package/Installer.DEB.proj | 1 - scripts/docker/debian/Dockerfile | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build/package/Installer.DEB.proj b/build/package/Installer.DEB.proj index 51de5c615..20f02b662 100644 --- a/build/package/Installer.DEB.proj +++ b/build/package/Installer.DEB.proj @@ -94,7 +94,6 @@ UseHardlinksIfPossible="False" /> - diff --git a/scripts/docker/debian/Dockerfile b/scripts/docker/debian/Dockerfile index 281778513..4b5515ec0 100644 --- a/scripts/docker/debian/Dockerfile +++ b/scripts/docker/debian/Dockerfile @@ -7,7 +7,8 @@ FROM microsoft/dotnet-buildtools-prereqs:debian-8.2-debpkg-d770b8b-20180628122423 # Misc Dependencies for build -RUN apt-get update && \ +RUN rm -rf /var/lib/apt/lists/* && \ + apt-get update && \ apt-get -qqy install \ sudo && \ apt-get clean && \ From d2740ce0b679911310353f00d662437b94cc320f Mon Sep 17 00:00:00 2001 From: William Li Date: Wed, 15 Aug 2018 14:13:07 -0700 Subject: [PATCH 4/4] Remove fallback folder --- build/package/Installer.DEB.proj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/build/package/Installer.DEB.proj b/build/package/Installer.DEB.proj index 20f02b662..a8c00c921 100644 --- a/build/package/Installer.DEB.proj +++ b/build/package/Installer.DEB.proj @@ -128,6 +128,9 @@ ToolPath="$(DebianInstalledDirectory)" /> + + +