mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Pass "PB_AssetRootUrl" explictly on the MSBuild call; we are looking for Microsoft.NETCore.App "2.1.0" or "2.1.1*"

Browse source
This commit is contained in:
jbeisner 2018-06-05 16:51:32 +00:00
parent 05348ce78f
commit 0015821db6
3 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
build/Test.targets
View file

@ -89,7 +89,7 @@
</Target> </Target>
<Target Name="TestsForBuildItself"> <Target Name="TestsForBuildItself">
<DotNetMSBuild Arguments="/v:diag $(RepoRoot)/test/MsBuildScript.Tests/runtests.target" <DotNetMSBuild Arguments="/v:diag $(RepoRoot)/test/MsBuildScript.Tests/runtests.target /p:PB_AssetRootUrl=$(PB_AssetRootUrl)"
ToolPath="$(PreviousStageDirectory)" /> ToolPath="$(PreviousStageDirectory)" />
</Target> </Target>

2
test/Microsoft.DotNet.Cli.Utils.Tests/GivenAProjectToolsCommandResolver.cs
View file

@ -304,7 +304,7 @@ namespace Microsoft.DotNet.Tests
result.Should().NotBeNull(); result.Should().NotBeNull();
result.Args.Should().Contain("--fx-version 2.1.0"); result.Args.Should().Contain("--fx-version 2.1.");
} }
[Fact] [Fact]

5
test/dotnet-new.Tests/GivenThatIWantANewApp.cs
View file

@ -75,8 +75,7 @@ namespace Microsoft.DotNet.New.Tests
} }
[Theory] [Theory]
[InlineData("console", "microsoft.netcore.app")] // [InlineData("console", "microsoft.netcore.app")] re-enable when this issue is resolved: "https://github.com/dotnet/cli/issues/9420"
// re-enable when this bug is resolved: https://github.com/dotnet/cli/issues/7574
[InlineData("classlib", "netstandard.library")] [InlineData("classlib", "netstandard.library")]
public void NewProjectRestoresCorrectPackageVersion(string type, string packageName) public void NewProjectRestoresCorrectPackageVersion(string type, string packageName)
{ {
@ -107,7 +106,7 @@ namespace Microsoft.DotNet.New.Tests
var sharedFxDir = dotnetDir var sharedFxDir = dotnetDir
.GetDirectory("shared", "Microsoft.NETCore.App") .GetDirectory("shared", "Microsoft.NETCore.App")
.EnumerateDirectories() .EnumerateDirectories()
.Single(d => d.Name.StartsWith("2.1.0")); .Single(d => d.Name.StartsWith("2.1."));
if (packageName == "microsoft.netcore.app") if (packageName == "microsoft.netcore.app")
{ {