dotnet-installer/src/dotnet/DotNetCommandFactory.cs

// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.Collections.Generic;
using System.Diagnostics;
using Microsoft.DotNet.Cli.Utils;
using NuGet.Frameworks;

namespace Microsoft.DotNet.Cli
{
    public class DotNetCommandFactory : ICommandFactory
    {
        public ICommand Create(
        	string commandName, 
        	IEnumerable<string> args, 
        	NuGetFramework framework = null, 
        	string configuration = Constants.DefaultConfiguration)
        {
            Func<string[], int> builtInCommand;
            if (Program.TryGetBuiltInCommand(commandName, out builtInCommand))
            {
                Debug.Assert(framework == null, "BuiltInCommand doesn't support the 'framework' argument.");
                Debug.Assert(configuration == Constants.DefaultConfiguration, "BuiltInCommand doesn't support the 'configuration' argument.");

                return new BuiltInCommand(commandName, args, builtInCommand);
            }

            return Command.CreateDotNet(commandName, args, framework, configuration);
        }
    }
}
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								// Copyright (c) .NET Foundation and contributors. All rights reserved.
 								// Licensed under the MIT license. See LICENSE file in the project root for full license information.
-												Invoke compile-csc in-proc

Since processes are expensive, suppress spawning a new process when dotnet-compile is invoking dotnet-compile-csc.

											
										
										
											2016-04-15 04:33:41 +00:00
+								using System;
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								using System.Collections.Generic;
-												Invoke compile-csc in-proc

Since processes are expensive, suppress spawning a new process when dotnet-compile is invoking dotnet-compile-csc.

											
										
										
											2016-04-15 04:33:41 +00:00
+								using System.Diagnostics;
 								using Microsoft.DotNet.Cli.Utils;
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								using NuGet.Frameworks;
-												Invoke compile-csc in-proc

Since processes are expensive, suppress spawning a new process when dotnet-compile is invoking dotnet-compile-csc.

											
										
										
											2016-04-15 04:33:41 +00:00
+								namespace Microsoft.DotNet.Cli
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								{
 								    public class DotNetCommandFactory : ICommandFactory
 								    {
-												Pipe configuration through CommandResolver

script changes to pipe configuration to test.ps1

debug commit, remove this commit

Change dotnet-test to invoke dotnet-test-xunit directly

build tests with configuration, framework, runtime in windows

Update testtargets in new build scripts

make configuration first arg to dotnet test

PR Feedback

update command factory

fix interface

test update

											
										
										
											2016-02-06 02:55:15 +00:00
+								        public ICommand Create(
 								        	string commandName,
 								        	IEnumerable<string> args,
 								        	NuGetFramework framework = null,
 								        	string configuration = Constants.DefaultConfiguration)
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								        {
-												Invoke compile-csc in-proc

Since processes are expensive, suppress spawning a new process when dotnet-compile is invoking dotnet-compile-csc.

											
										
										
											2016-04-15 04:33:41 +00:00
+								            Func<string[], int> builtInCommand;
 								            if (Program.TryGetBuiltInCommand(commandName, out builtInCommand))
 								            {
 								                Debug.Assert(framework == null, "BuiltInCommand doesn't support the 'framework' argument.");
 								                Debug.Assert(configuration == Constants.DefaultConfiguration, "BuiltInCommand doesn't support the 'configuration' argument.");
 								                return new BuiltInCommand(commandName, args, builtInCommand);
 								            }
-												Pipe configuration through CommandResolver

script changes to pipe configuration to test.ps1

debug commit, remove this commit

Change dotnet-test to invoke dotnet-test-xunit directly

build tests with configuration, framework, runtime in windows

Update testtargets in new build scripts

make configuration first arg to dotnet test

PR Feedback

update command factory

fix interface

test update

											
										
										
											2016-02-06 02:55:15 +00:00
+								            return Command.CreateDotNet(commandName, args, framework, configuration);
-												Refactoring dotnet-compile to make adding the script variable testable. So far, moved it to have a compiler controller and two separate compilers: native and managed. Also moved the script runner to its own class so that we can mock it into the managed controller.

Adding a ICommand interface and factory that we can use to mock Commands and avoid actually running them in unit tests.

											
										
										
											2016-02-10 00:35:43 +00:00
+								        }
 								    }
 								}