dotnet-installer/src/dotnet/ShellShim/IShellShimMaker.cs

using Microsoft.Extensions.EnvironmentAbstractions;

namespace Microsoft.DotNet.ShellShim
{
    public interface IShellShimMaker
    {
        void CreateShim(FilePath packageExecutable, string shellCommandName);
        void EnsureCommandNameUniqueness(string shellCommandName);
    }
}
-												replace string with FilePath (#8494)


											
										
										
											2018-01-30 15:41:39 -08:00
+								using Microsoft.Extensions.EnvironmentAbstractions;
 								namespace Microsoft.DotNet.ShellShim
-												Use rich mock to test InstallCommand (#8402)

To ensure the mock has the same behavior the component has, run mock under the same tests the adapter has.
It is a common problem that moq has -- "everything is mocked out, you are not test anything"
											
										
										
											2018-01-24 10:16:27 -08:00
+								{
 								    public interface IShellShimMaker
 								    {
-												replace string with FilePath (#8494)


											
										
										
											2018-01-30 15:41:39 -08:00
+								        void CreateShim(FilePath packageExecutable, string shellCommandName);
-												Use rich mock to test InstallCommand (#8402)

To ensure the mock has the same behavior the component has, run mock under the same tests the adapter has.
It is a common problem that moq has -- "everything is mocked out, you are not test anything"
											
										
										
											2018-01-24 10:16:27 -08:00
+								        void EnsureCommandNameUniqueness(string shellCommandName);
 								    }
 								}