mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
dotnet-installer/test/Microsoft.DotNet.Configurer.UnitTests/GivenADotnetFirstTimeUseConfigurer.cs

558 lines
25 KiB
C#
Raw Normal View History

Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
using FluentAssertions;
using Microsoft.DotNet.Cli.Utils;
using Microsoft.DotNet.Configurer;
using Microsoft.DotNet.Tools.Test;
using Microsoft.Extensions.DependencyModel.Tests;
using Moq;
using Xunit;
namespace Microsoft.DotNet.Configurer.UnitTests
{
public class GivenADotnetFirstTimeUseConfigurer
{
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
private const string CliFallbackFolderPath = "some path";
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
private Mock<INuGetCachePrimer> _nugetCachePrimerMock;
Adding a separate abstraction for the NuGet sentinel.
2016-06-06 17:39:05 +00:00
private Mock<INuGetCacheSentinel> _nugetCacheSentinelMock;
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
private Mock<IFirstTimeUseNoticeSentinel> _firstTimeUseNoticeSentinelMock;
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
private Mock<IAspNetCertificateSentinel> _aspNetCertificateSentinelMock;
private Mock<IAspNetCoreCertificateGenerator> _aspNetCoreCertificateGeneratorMock;
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
private Mock<IFileSentinel> _toolPathSentinelMock;
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
private Mock<IEnvironmentProvider> _environmentProviderMock;
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
private Mock<IReporter> _reporterMock;
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
private Mock<IEnvironmentPath> _pathAdderMock;
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
public GivenADotnetFirstTimeUseConfigurer()
{
_nugetCachePrimerMock = new Mock<INuGetCachePrimer>();
Adding a separate abstraction for the NuGet sentinel.
2016-06-06 17:39:05 +00:00
_nugetCacheSentinelMock = new Mock<INuGetCacheSentinel>();
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_firstTimeUseNoticeSentinelMock = new Mock<IFirstTimeUseNoticeSentinel>();
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock = new Mock<IAspNetCertificateSentinel>();
_aspNetCoreCertificateGeneratorMock = new Mock<IAspNetCoreCertificateGenerator>();
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock = new Mock<IFileSentinel>();
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
_environmentProviderMock = new Mock<IEnvironmentProvider>();
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_reporterMock = new Mock<IReporter>();
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock = new Mock<IEnvironmentPath>();
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_SKIP_FIRST_TIME_EXPERIENCE", false))
.Returns(false);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_PRINT_TELEMETRY_MESSAGE", true))
.Returns(true);
}
[Fact]
public void It_does_not_print_the_first_time_use_notice_if_the_sentinel_exists()
{
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Make configurer unit tests pass on localized setup
2017-06-21 19:44:17 +00:00
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)), Times.Never);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
[Fact]
public void It_does_not_print_the_first_time_use_notice_when_the_user_has_set_the_DOTNET_SKIP_FIRST_TIME_EXPERIENCE_environemnt_variable()
{
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_SKIP_FIRST_TIME_EXPERIENCE", false))
.Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Make configurer unit tests pass on localized setup
2017-06-21 19:44:17 +00:00
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)), Times.Never);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
[Fact]
public void It_does_not_print_the_first_time_use_notice_when_the_user_has_set_the_DOTNET_PRINT_TELEMETRY_MESSAGE_environemnt_variable()
{
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_PRINT_TELEMETRY_MESSAGE", true))
.Returns(false);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Make configurer unit tests pass on localized setup
2017-06-21 19:44:17 +00:00
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)), Times.Never);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
[Fact]
public void It_prints_the_telemetry_if_the_sentinel_does_not_exist()
{
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(false);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Make configurer unit tests pass on localized setup
2017-06-21 19:44:17 +00:00
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)));
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
}
[Fact]
public void It_does_not_prime_the_cache_if_the_sentinel_exists()
{
Adding a separate abstraction for the NuGet sentinel.
2016-06-06 17:39:05 +00:00
_nugetCacheSentinelMock.Setup(n => n.Exists()).Returns(true);
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
_nugetCacheSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Never);
}
Introducing a in progress sentinel that gets verified before running the first time experience. If we can get a handle for this sentinel, we proceed with the first time run, otherwise, it means there is a first time experience running already, in which case we continue running dotnet normally, even though the final (real) sentinel is not present yet. This prevents multiple dotnet commands from running the first time experience in parallel and prevents us from running into parallel nuget restores.
2016-06-10 22:06:48 +00:00
[Fact]
public void It_does_not_prime_the_cache_if_first_run_experience_is_already_happening()
{
_nugetCacheSentinelMock.Setup(n => n.InProgressSentinelAlreadyExists()).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Never);
}
[Fact]
public void It_does_not_prime_the_cache_if_cache_is_missing()
{
_nugetCachePrimerMock.Setup(n => n.SkipPrimingTheCache()).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Introducing a in progress sentinel that gets verified before running the first time experience. If we can get a handle for this sentinel, we proceed with the first time run, otherwise, it means there is a first time experience running already, in which case we continue running dotnet normally, even though the final (real) sentinel is not present yet. This prevents multiple dotnet commands from running the first time experience in parallel and prevents us from running into parallel nuget restores.
2016-06-10 22:06:48 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Never);
}
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
[Fact]
public void It_does_not_prime_the_cache_if_the_sentinel_exists_but_the_user_has_set_the_DOTNET_SKIP_FIRST_TIME_EXPERIENCE_environemnt_variable()
{
_nugetCacheSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_SKIP_FIRST_TIME_EXPERIENCE", false))
.Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Never);
}
[Fact]
public void It_primes_the_cache_if_the_sentinel_does_not_exist()
{
Adding a separate abstraction for the NuGet sentinel.
2016-06-06 17:39:05 +00:00
_nugetCacheSentinelMock.Setup(n => n.Exists()).Returns(false);
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
Addressing code review comments and adding a DOTNET_SKIP_FIRST_TIME_EXPERIENCE env variable to have a way to turn off the feature.
2016-06-10 20:02:48 +00:00
_nugetCacheSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Once);
Introducing a in progress sentinel that gets verified before running the first time experience. If we can get a handle for this sentinel, we proceed with the first time run, otherwise, it means there is a first time experience running already, in which case we continue running dotnet normally, even though the final (real) sentinel is not present yet. This prevents multiple dotnet commands from running the first time experience in parallel and prevents us from running into parallel nuget restores.
2016-06-10 22:06:48 +00:00
}
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
[Fact]
public void It_prints_first_use_notice_and_primes_the_cache_if_the_sentinels_do_not_exist()
{
_nugetCacheSentinelMock.Setup(n => n.Exists()).Returns(false);
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(false);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_environmentProviderMock.Object,
Moving the expanding fallback folder to the dotnet folder hive. The folder will be expanded at sdk/NuGetFallbackFolder.
2017-05-31 20:44:03 +00:00
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Make configurer unit tests pass on localized setup
2017-06-21 19:44:17 +00:00
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)));
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.NugetCachePrimeMessage)));
Avoid repeating the first-run message if lzma archive is missing If the LZMA archive is missing, the first-run message is printed every time. This commit fixes that. Split the first-run message into two pieces: - The first-run (welcome and telemetry) message is printed only once, no matter whether the cache was primed or not. - The cache-priming message is printed only if the cache is avaialble. Otherwise skip the cache introduction and the ccache priming operation.
2017-06-14 16:09:06 +00:00
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Once);
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
[Fact]
public void It_prints_the_first_time_use_notice_if_the_cache_sentinel_exists_but_the_first_notice_sentinel_does_not()
{
_nugetCacheSentinelMock.Setup(n => n.Exists()).Returns(true);
_firstTimeUseNoticeSentinelMock.Setup(n => n.Exists()).Returns(false);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r =>
r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)));
_reporterMock.Verify(
r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.NugetCachePrimeMessage)),
Times.Never);
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
[Fact]
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
public void It_adds_the_tool_path_to_the_environment_if_the_tool_path_sentinel_does_not_exist()
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
{
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Setup(s => s.Exists()).Returns(false);
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
dotnetFirstTimeUseConfigurer.Configure();
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Verify(s => s.Create(), Times.Once);
_pathAdderMock.Verify(p => p.AddPackageExecutablePathToUserPath(), Times.Once);
}
[Fact]
public void It_does_not_add_the_tool_path_to_the_environment_if_the_tool_path_sentinel_exists()
{
_toolPathSentinelMock.Setup(s => s.Exists()).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
_toolPathSentinelMock.Object,
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
_pathAdderMock.Object);
dotnetFirstTimeUseConfigurer.Configure();
_toolPathSentinelMock.Verify(s => s.Create(), Times.Never);
_pathAdderMock.Verify(p => p.AddPackageExecutablePathToUserPath(), Times.Never);
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
}
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
[Fact]
public void It_prints_the_unauthorized_notice_if_the_cache_sentinel_reports_Unauthorized()
{
_nugetCacheSentinelMock.Setup(n => n.UnauthorizedAccess).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r =>
r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)));
_reporterMock.Verify(r =>
r.WriteLine(It.Is<string>(str =>
str == string.Format(LocalizableStrings.UnauthorizedAccessMessage, CliFallbackFolderPath))));
_reporterMock.Verify(
r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.NugetCachePrimeMessage)),
Times.Never);
_reporterMock.Verify(r => r.Write(It.IsAny<string>()), Times.Never);
}
[Fact]
public void It_does_not_prime_the_cache_if_the_cache_sentinel_reports_Unauthorized()
{
_nugetCacheSentinelMock.Setup(n => n.UnauthorizedAccess).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
Making a change that will cause the first run notice to always show up in the first run of the CLI, even when it is installed by native installers.
2017-07-26 05:30:36 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_nugetCachePrimerMock.Verify(r => r.PrimeCache(), Times.Never);
}
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
[Fact]
public void It_does_not_generate_the_aspnet_https_development_certificate_if_the_sentinel_exists()
{
_aspNetCertificateSentinelMock.Setup(n => n.Exists()).Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.AspNetCertificateInstalled)), Times.Never);
_aspNetCoreCertificateGeneratorMock.Verify(s => s.GenerateAspNetCoreDevelopmentCertificate(), Times.Never);
}
[Fact]
public void It_does_not_generate_the_aspnet_https_development_certificate_when_the_user_has_set_the_DOTNET_SKIP_FIRST_TIME_EXPERIENCE_environment_variable()
{
_aspNetCertificateSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_SKIP_FIRST_TIME_EXPERIENCE", false))
.Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.AspNetCertificateInstalled)), Times.Never);
_aspNetCoreCertificateGeneratorMock.Verify(s => s.GenerateAspNetCoreDevelopmentCertificate(), Times.Never);
}
[Fact]
public void It_does_not_generate_the_aspnet_https_development_certificate_when_the_user_has_set_the_DOTNET_GENERATE_ASPNET_CERTIFICATE_environment_variable()
{
_aspNetCertificateSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_GENERATE_ASPNET_CERTIFICATE", true))
.Returns(false);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.AspNetCertificateInstalled)), Times.Never);
_aspNetCoreCertificateGeneratorMock.Verify(s => s.GenerateAspNetCoreDevelopmentCertificate(), Times.Never);
}
[Fact]
public void It_generates_the_aspnet_https_development_certificate_if_the_sentinel_does_not_exist()
{
_aspNetCertificateSentinelMock.Setup(n => n.Exists()).Returns(false);
_environmentProviderMock.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_GENERATE_ASPNET_CERTIFICATE", true))
.Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_toolPathSentinelMock.Object,
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_pathAdderMock.Object);
ASP.NET Core HTTPS development certificate support * Added support for generating the HTTPS development certificate on the CLI first run experience. * On first run, an HTTPS certificate will be set up on the current user local store. * The environment variable DOTNET_GENERATE_ASPNET_CERTIFICATE can be used to turn the feature off.
2017-11-10 22:47:05 +00:00
dotnetFirstTimeUseConfigurer.Configure();
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.FirstTimeWelcomeMessage)));
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.NugetCachePrimeMessage)));
_reporterMock.Verify(r => r.WriteLine(It.Is<string>(str => str == LocalizableStrings.AspNetCertificateInstalled)));
_aspNetCoreCertificateGeneratorMock.Verify(s => s.GenerateAspNetCoreDevelopmentCertificate(), Times.Once);
}
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
[Fact]
public void It_adds_the_tool_path_to_the_environment_if_the_first_run_experience_is_not_skipped()
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
{
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
_toolPathSentinelMock.Object,
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
_pathAdderMock.Object);
dotnetFirstTimeUseConfigurer.Configure();
_pathAdderMock.Verify(p => p.AddPackageExecutablePathToUserPath(), Times.Once);
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
}
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
[Fact]
public void It_does_not_add_the_tool_path_to_the_environment_if_the_first_run_experience_is_skipped()
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
{
Fix failure to add tools path on restricted Windows environments. On environments where registry access is disabled, the first run experience fails because it could not add the tools path to the user's environment. This fix properly handles the security exception by printing a warning and continuing. Users will have to manually add the PATH environment variable to their environments to prevent `dotnet tool install` from printing PATH instructions. A new file sentinel is added to track whether or not the PATH has been modified. The first run experience also now correctly skips modifying the PATH if `DOTNET_SKIP_FIRST_TIME_EXPERIENCE` is set. Fixes #8874.
2018-03-23 19:40:58 +00:00
_environmentProviderMock
.Setup(e => e.GetEnvironmentVariableAsBool("DOTNET_SKIP_FIRST_TIME_EXPERIENCE", false))
.Returns(true);
var dotnetFirstTimeUseConfigurer = new DotnetFirstTimeUseConfigurer(
_nugetCachePrimerMock.Object,
_nugetCacheSentinelMock.Object,
_firstTimeUseNoticeSentinelMock.Object,
_aspNetCertificateSentinelMock.Object,
_aspNetCoreCertificateGeneratorMock.Object,
_toolPathSentinelMock.Object,
_environmentProviderMock.Object,
_reporterMock.Object,
CliFallbackFolderPath,
_pathAdderMock.Object);
dotnetFirstTimeUseConfigurer.Configure();
_pathAdderMock.Verify(p => p.AddPackageExecutablePathToUserPath(), Times.Never);
Tools shim maker and env path handling (#8085) * Tools shim maker and env path handling Includes component: * Given executable, create shim (all three OSs) * Add executable path to Env PATH during first run * including manual instruction when there is no access
2017-11-27 18:45:43 +00:00
}
Almost all of the code to prime the NuGet cache from the archive. - Created a Configurer class that is responsible for deciding when to run the dotnet first time use experience and invoke the NuGetCachePrimer. - Added the NuGetCachePrimer which extract the archive and primes the cache. -- This is just missing creating the sentinel once restore succeeds. - Added a shell for the NugetPackagesArchiver, which will be responsible for expanding the archive (likely replaced in the future by an abstraction from Eric's code or its implementation will simply call Eric's code). - Added a TemporaryFolder abstration to Internal Abstractions that handles deleting the temporary folder once we are done with it.
2016-06-04 00:36:40 +00:00
}
}
Reference in a new issue Copy permalink