6e33ebe6f3
LEDs controlled through the leds-gpio driver are not PWM capable. Setting the max_brightness property to 1 instead of 255.
36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From ecc1613977400f117a4f399d46404b399547ee18 Mon Sep 17 00:00:00 2001
|
|
From: Dylan Van Assche <me@dylanvanassche.be>
|
|
Date: Tue, 29 Dec 2020 14:59:23 +0100
|
|
Subject: [PATCH] leds: gpio: Set max brightness to 1
|
|
|
|
GPIO LEDs only know 2 states: ON or OFF and do not have PWM capabilities.
|
|
However, the max brightness is reported as 255.
|
|
|
|
This patch sets the max brightness value of a GPIO controlled LED to 1.
|
|
|
|
Tested on my PinePhone 1.2.
|
|
|
|
Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
|
|
Related: https://gitlab.com/postmarketOS/pmaports/-/merge_requests/1832
|
|
Related: https://lkml.org/lkml/2020/12/27/64
|
|
---
|
|
drivers/leds/leds-gpio.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
|
|
index 93f5b1b60fde..0d66f19d71ba 100644
|
|
--- a/drivers/leds/leds-gpio.c
|
|
+++ b/drivers/leds/leds-gpio.c
|
|
@@ -96,7 +96,8 @@ static int create_gpio_led(const struct gpio_led *template,
|
|
} else {
|
|
state = (template->default_state == LEDS_GPIO_DEFSTATE_ON);
|
|
}
|
|
- led_dat->cdev.brightness = state ? LED_FULL : LED_OFF;
|
|
+ led_dat->cdev.brightness = state ? LED_ON : LED_OFF;
|
|
+ led_dat->cdev.max_brightness = LED_ON;
|
|
if (!template->retain_state_suspended)
|
|
led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;
|
|
if (template->panic_indicator)
|
|
--
|
|
2.26.2
|
|
|