3ed9591e41
This cmdline argument is now a no-op. Drop it everywhere and add a new CI check to enforce this. Adjust the deprecated "minimal" initramfs variant to use pmos.debug-shell to enable logging instead. It doesn't /support/ dropping to a shell, so the variable takes on a different meaning. But that's ok since it's at least more consistent. [ci:ignore-count] [ci:skip-vercheck] Signed-off-by: Caleb Connolly <caleb@postmarketos.org> Tweaked-by: Oliver Smith <ollieparanoid@postmarketos.org> [ci:skip-build]: kernel builds are very likely to go through now
90 lines
3.3 KiB
Bash
Executable file
90 lines
3.3 KiB
Bash
Executable file
#!/bin/sh -e
|
|
# Description: check various bad patterns with grep
|
|
# https://postmarketos.org/pmb-ci
|
|
|
|
exit_code=0
|
|
|
|
if [ "$(id -u)" = 0 ]; then
|
|
set -x
|
|
apk -q add grep
|
|
exec su "${TESTUSER:-build}" -c "sh -e $0"
|
|
fi
|
|
|
|
# Find CHANGEMEs in APKBUILDs
|
|
if grep -qr '(CHANGEME!)' -- *; then
|
|
echo "ERROR: Please replace '(CHANGEME!)' in the following files:"
|
|
grep --color=always -r '(CHANGEME!)' -- *
|
|
exit_code=1
|
|
fi
|
|
|
|
# DTBs installed to /usr/share/db
|
|
# shellcheck disable=SC2016
|
|
if grep -qr 'INSTALL_DTBS_PATH="$pkgdir"/usr/share/dtb' device/; then
|
|
echo 'ERROR: Please do not install dtbs to /usr/share/dtb!'
|
|
echo 'ERROR: Unless you have a good reason not to, please put them in /boot/dtbs'
|
|
echo 'ERROR: Files that need fixing:'
|
|
# shellcheck disable=SC2016
|
|
grep --color=always -r 'INSTALL_DTBS_PATH="$pkgdir"/usr/share/dtb' device/
|
|
exit_code=1
|
|
fi
|
|
|
|
|
|
# Find old mkinitfs paths (pre mkinitfs 2.0)
|
|
if grep -qr '/etc/postmarketos-mkinitfs' -- *; then
|
|
echo "ERROR: Please replace '/etc/postmarketos-mkinitfs' with '/usr/share/mkinitfs' in the following files:"
|
|
grep --color=always -r '/etc/postmarketos-mkinitfs' -- *
|
|
exit_code=1
|
|
fi
|
|
if grep -qr '/usr/share/postmarketos-mkinitfs' -- *; then
|
|
echo "ERROR: Please replace '/usr/share/postmarketos-mkinitfs' with '/usr/share/mkinitfs' in the following files:"
|
|
grep --color=always -r '/usr/share/postmarketos-mkinitfs' -- *
|
|
exit_code=1
|
|
fi
|
|
|
|
# Direct sourcing of deviceinfo
|
|
if grep --exclude='source_deviceinfo' -qEr 'source /etc/deviceinfo|\. /etc/deviceinfo' -- *; then
|
|
echo 'ERROR: Please source the source_deviceinfo script instead of sourcing deviceinfo directly!'
|
|
grep --color=always --exclude='rootfs-usr-share-misc-source_deviceinfo' -Er 'source /etc/deviceinfo|\. /etc/deviceinfo' -- *
|
|
exit_code=1
|
|
fi
|
|
|
|
# Removed deviceinfo variable
|
|
if grep -qr 'deviceinfo_modules_initfs' -- *; then
|
|
echo 'ERROR: deviceinfo_modules_initfs variable has been removed. Use "modules-initfs" file instead.'
|
|
grep --color=always -r 'deviceinfo_modules_initfs' -- *
|
|
exit_code=1
|
|
fi
|
|
|
|
POSTMARKETOS_WALLPAPER_PATH='/usr/share/wallpapers/postmarketos.jpg'
|
|
# The excluded devices are "grandfathered in". New devices should not be added here.
|
|
# See https://gitlab.com/postmarketOS/pmaports/-/issues/2529
|
|
if grep -qr $POSTMARKETOS_WALLPAPER_PATH \
|
|
--exclude-dir='device-pine64-pinetab' \
|
|
--exclude-dir='device-oneplus-kebab' \
|
|
--exclude-dir='device-xiaomi-willow' \
|
|
-- device; then
|
|
echo "ERROR: Please don't include configuration files that set the default wallpaper in device-specific packages!"
|
|
grep --color=always -r $POSTMARKETOS_WALLPAPER_PATH \
|
|
--exclude-dir='device-pine64-pinetab' \
|
|
--exclude-dir='device-oneplus-kebab' \
|
|
--exclude-dir='device-xiaomi-willow' \
|
|
-- device
|
|
exit_code=1
|
|
fi
|
|
|
|
OPENRC_SERVICE_FILES=$(find . -name '*.initd')
|
|
# shellcheck disable=SC2086
|
|
if grep -q 'before wpa_supplicant' $OPENRC_SERVICE_FILES; then
|
|
echo "ERROR: Please use 'before wlan' in OpenRC service files! This ensures compatibility with both wpa_supplicant and iwd."
|
|
grep --color=always 'before wpa_supplicant' $OPENRC_SERVICE_FILES
|
|
exit_code=1
|
|
fi
|
|
|
|
if grep -qEr 'PMOS_NO_OUTPUT_REDIRECT' -- *; then
|
|
echo "ERROR: PMOS_NO_OUTPUT_REDIRECT is deprecated and doesn't do anything."
|
|
echo "Please remove it from the following files:"
|
|
grep --color=always -Er 'PMOS_NO_OUTPUT_REDIRECT' -- *
|
|
exit_code=1
|
|
fi
|
|
|
|
exit "$exit_code"
|