fb7f99efe2
Unmaintained is a name which on multiple occasions have seen lead to confusion with people having the impression that unmaintained is for all unmaintained devices, which is not how we're really using it. Many devices in testing do not actually have a maintainer, yet there has been no push to move these out of there and into unmaintained. I think this is a result of that unmaintained was introduced not to keep unmaintained ports but rather a place to store ports that have a better replacement but where the inferior one still holds some sort of value, such as for debugging purposes. These ports also are not necessarily entirely unmaintained and see more fixes than many ports in testing. While one approach to solving this problem could be to simply moving all unmaintained ports to unmaintained, I think this comes with some problems: It would require an initial effort to figure out which ports are indeed unmaintained and which just don't have a maintained noted in the package, and given how many ports there are in testing this would be a big endeavour. It would also require continuous work on moving ports into unmaintained as the maintainers go silent if we are to keep testing and unmaintained's state consistent with reality. Additionally, just because a port doesn't have a maintainer on paper doens't mean that there aren't people who aren't willing to fix it up if there are issues that arise. As such, I think the way to go is renaming unmaintained to better reflect the original intent. Thanks to Luca Weiss for suggesting "archive", and to Arnav Singh for suggesting that "archived" would match the other category names better.
49 lines
1.5 KiB
Diff
49 lines
1.5 KiB
Diff
diff --git a/drivers/power/idol347/smb1360-charger-fg.c b/drivers/power/idol347/smb1360-charger-fg.c
|
|
index bc8859cd9a2..e223a5aea9e 100644
|
|
--- a/drivers/power/idol347/smb1360-charger-fg.c
|
|
+++ b/drivers/power/idol347/smb1360-charger-fg.c
|
|
@@ -9,6 +9,7 @@
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
+#define DEBUG
|
|
#define pr_fmt(fmt) "SMB:%s: " fmt, __func__
|
|
|
|
#include <linux/i2c.h>
|
|
@@ -472,7 +473,7 @@ static int __smb1360_write(struct smb1360_chip *chip, int reg,
|
|
val, reg, ret);
|
|
return ret;
|
|
}
|
|
- //pr_debug("Writing 0x%02x=0x%02x\n", reg, val);
|
|
+ pr_debug("Writing 0x%02x=0x%02x\n", reg, val);
|
|
return 0;
|
|
}
|
|
|
|
@@ -967,6 +968,10 @@ static enum power_supply_property smb1360_battery_properties[] = {
|
|
};
|
|
|
|
static int smb1360_get_prop_batt_present(struct smb1360_chip *chip)
|
|
+/* Disable pr_debug() for read routines, those spam too much */
|
|
+#pragma push_macro("pr_debug")
|
|
+#undef pr_debug
|
|
+#define pr_debug(fmt, ...)
|
|
{
|
|
return chip->batt_present;
|
|
}
|
|
@@ -1223,6 +1228,7 @@ static int smb1360_get_prop_current_now(struct smb1360_chip *chip)
|
|
}
|
|
|
|
static int smb1360_set_minimum_usb_current(struct smb1360_chip *chip)
|
|
+#pragma pop_macro("pr_debug")
|
|
{
|
|
int rc = 0;
|
|
|
|
@@ -2577,7 +2583,7 @@ static irqreturn_t smb1360_stat_handler(int irq, void *dev_id)
|
|
handlers[i].prev_val = handlers[i].val;
|
|
}
|
|
|
|
- pr_debug("handler count = %d\n", handler_count);
|
|
+ //pr_debug("handler count = %d\n", handler_count);
|
|
if (handler_count)
|
|
power_supply_changed(&chip->batt_psy);
|
|
|