fb7f99efe2
Unmaintained is a name which on multiple occasions have seen lead to confusion with people having the impression that unmaintained is for all unmaintained devices, which is not how we're really using it. Many devices in testing do not actually have a maintainer, yet there has been no push to move these out of there and into unmaintained. I think this is a result of that unmaintained was introduced not to keep unmaintained ports but rather a place to store ports that have a better replacement but where the inferior one still holds some sort of value, such as for debugging purposes. These ports also are not necessarily entirely unmaintained and see more fixes than many ports in testing. While one approach to solving this problem could be to simply moving all unmaintained ports to unmaintained, I think this comes with some problems: It would require an initial effort to figure out which ports are indeed unmaintained and which just don't have a maintained noted in the package, and given how many ports there are in testing this would be a big endeavour. It would also require continuous work on moving ports into unmaintained as the maintainers go silent if we are to keep testing and unmaintained's state consistent with reality. Additionally, just because a port doesn't have a maintainer on paper doens't mean that there aren't people who aren't willing to fix it up if there are issues that arise. As such, I think the way to go is renaming unmaintained to better reflect the original intent. Thanks to Luca Weiss for suggesting "archive", and to Arnav Singh for suggesting that "archived" would match the other category names better.
51 lines
1.8 KiB
Diff
51 lines
1.8 KiB
Diff
From 7acfecc35efefab4df9444f46726bb29a8b50afa Mon Sep 17 00:00:00 2001
|
|
From: Zhenhua Huang <zhenhuah@codeaurora.org>
|
|
Date: Wed, 27 Aug 2014 12:52:39 +0800
|
|
Subject: [PATCH] power: smb1360: Fix issue for safety-timer setting
|
|
|
|
Safety-timer means maximum duration in minutes that a single charge
|
|
cycle may last.
|
|
Fix issue by correcting the safety timer enable bit.
|
|
|
|
Change-Id: I2f4592bbb98360d80dd9210ed50b3cac83e137ae
|
|
Signed-off-by: Zhenhua Huang <zhenhuah@codeaurora.org>
|
|
---
|
|
drivers/power/smb1360-charger-fg-wt88047.c | 8 ++++----
|
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/drivers/power/smb1360-charger-fg-wt88047.c b/drivers/power/smb1360-charger-fg-wt88047.c
|
|
index fa03089b8b7..94672901436 100644
|
|
--- a/drivers/power/smb1360-charger-fg-wt88047.c
|
|
+++ b/drivers/power/smb1360-charger-fg-wt88047.c
|
|
@@ -75,7 +75,7 @@
|
|
#define CHG_STAT_DISABLE_BIT BIT(0)
|
|
|
|
#define CFG_SFY_TIMER_CTRL_REG 0x0A
|
|
-#define SAFETY_TIME_EN_BIT BIT(4)
|
|
+#define SAFETY_TIME_DISABLE_BIT BIT(5)
|
|
#define SAFETY_TIME_MINUTES_SHIFT 2
|
|
#define SAFETY_TIME_MINUTES_MASK SMB1360_MASK(3, 2)
|
|
|
|
@@ -3580,7 +3580,7 @@ static int smb1360_hw_init(struct smb1360_chip *chip)
|
|
if (chip->safety_time == 0) {
|
|
/* safety timer disabled */
|
|
rc = smb1360_masked_write(chip, CFG_SFY_TIMER_CTRL_REG,
|
|
- SAFETY_TIME_EN_BIT, 0);
|
|
+ SAFETY_TIME_DISABLE_BIT, SAFETY_TIME_DISABLE_BIT);
|
|
if (rc < 0) {
|
|
dev_err(chip->dev,
|
|
"Couldn't disable safety timer rc = %d\n",
|
|
@@ -3595,8 +3595,8 @@ static int smb1360_hw_init(struct smb1360_chip *chip)
|
|
}
|
|
}
|
|
rc = smb1360_masked_write(chip, CFG_SFY_TIMER_CTRL_REG,
|
|
- SAFETY_TIME_EN_BIT | SAFETY_TIME_MINUTES_MASK,
|
|
- SAFETY_TIME_EN_BIT | reg);
|
|
+ SAFETY_TIME_DISABLE_BIT | SAFETY_TIME_MINUTES_MASK,
|
|
+ reg);
|
|
if (rc < 0) {
|
|
dev_err(chip->dev,
|
|
"Couldn't set safety timer rc = %d\n",
|
|
--
|
|
2.30.1
|
|
|