f77dc643c9
which are probably too experimental to ask Alpine to carry them, while being very helpful for devices that pmOS targets. The explicit goal is to help Libcamera development and drop the fork again. For the dma heaps permissions see the ongoing debate in https://lore.kernel.org/all/bb372250-e8b8-4458-bc99-dd8365b06991@redhat.com/ It's possible that Libcamera will switch to another solution in a future release or that memory accounting issues around dma heaps will need to get fixed in the kernel before the permissions can be set by default by distros. Regarding `libcamera: simple:` patches: - 0001-0003 can likely be dropped once the Libcamera SoftISP gains support for raw (bayer) streams passthrough (on top of converting to RGB or YUV formats). - 0004 will likely be needed until Megi downstream patches for the Pinephone get improved/upstreamed and Libcamera adopted accordingly. With these patches libcamera and pipewire based applications should work on the Librem5, Pinephone and - hopefully soon - devices like the OP6. See https://gitlab.com/postmarketOS/pmaports/-/merge_requests/5162 for more context. [ci:skip-build]: already built successfully in CI
32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From 08c1dd69b556b0325fe6cdfea4b28b4f2df90658 Mon Sep 17 00:00:00 2001
|
|
From: Luca Weiss <luca@z3ntu.xyz>
|
|
Date: Sat, 28 Jan 2023 17:24:03 +0100
|
|
Subject: [PATCH] qcam: Decrease minimum width of selector dialog
|
|
|
|
On phone screens the default width is too wide, so the OK button cannot
|
|
be clicked.
|
|
|
|
Fix this by decreasing the minimum size of the dialog so it fits nicely.
|
|
|
|
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
|
|
---
|
|
src/apps/qcam/cam_select_dialog.cpp | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/src/apps/qcam/cam_select_dialog.cpp b/src/apps/qcam/cam_select_dialog.cpp
|
|
index 3c8b12a9..2a600383 100644
|
|
--- a/src/apps/qcam/cam_select_dialog.cpp
|
|
+++ b/src/apps/qcam/cam_select_dialog.cpp
|
|
@@ -25,6 +25,9 @@ CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManag
|
|
/* Use a QFormLayout for the dialog. */
|
|
QFormLayout *layout = new QFormLayout(this);
|
|
|
|
+ /* Decrease minimum width of dialog to fit on narrow screens */
|
|
+ setMinimumSize(250, 100);
|
|
+
|
|
/* Setup the camera id combo-box. */
|
|
cameraIdComboBox_ = new QComboBox;
|
|
for (const auto &cam : cm_->cameras())
|
|
--
|
|
2.39.1
|
|
|