From bb25d9aa6192587575e3bd3b65acefb0475474a8 Mon Sep 17 00:00:00 2001 From: Arnavion Date: Thu, 26 Aug 2021 00:34:46 -0700 Subject: [PATCH] pine64-pinephone: fix pinephone_modem-setup to correctly invoke atinout (MR 2462) `$DEV` was an undefined variable so the atinout commands were printing their helptext instead of actually running. This was noticeable because the "Failed to enable VoLTE profile auto selecting" log was being printed along with said helptext to syslog. The block that defined `$DEV` had been accidentally deleted in bb41f5387971a675d55a632af029c9e79054ca65 . This change restores it. --- device/main/device-pine64-pinephone/APKBUILD | 6 +++--- device/main/device-pine64-pinephone/setup-modem.sh | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/device/main/device-pine64-pinephone/APKBUILD b/device/main/device-pine64-pinephone/APKBUILD index 04bb90e30..91e6a650a 100644 --- a/device/main/device-pine64-pinephone/APKBUILD +++ b/device/main/device-pine64-pinephone/APKBUILD @@ -5,8 +5,8 @@ # Co-Maintainer: Clayton Craft # Co-Maintainer: Dylan Van Assche pkgname=device-pine64-pinephone -pkgver=0.30 -pkgrel=3 +pkgver=0.31 +pkgrel=0 pkgdesc="PINE64 PinePhone" url="https://postmarketos.org" license="MIT" @@ -170,7 +170,7 @@ ccbc83b84b5028bc2c8e526759004ce71b50b2675ecffee98f5676c70a3332197a231ff9d2fd4644 3dd6d612c381cb0002049d1974d8fb5aa5a53a1eb4d6bcbf62eb2ad52cfdc45f0f6ad24a699716d3513b0371aa1316f25dc72afc10d7176cc3b99d0965c3f030 hwtest.ini 6bc22b369b2d9058b702ac7a7862abaefaf8179b43491868bdb008d181b59104f1ded89db1da51a810e1ccdc803a579b924a438674283a65afc3a9c4d2894caf kirigami-lowpower.sh c5006c38828eb519917d57756f7831c4552feffef2d4922a384073f6a551535f615ad397d784e313818e0b943e1f6212bcca0aff9ce37da60b29547b1631f24b modemmanager.conf -fa063e2863afc48e627acc1a5b213a81499ba1dd30325f74f118a44e3964aec7e597b1f4bd318b7cf5bf14f27daf88e6ad9fc277ab106cbbe1189fdcc650d5c1 setup-modem.sh +420ee1d7522d4d56c2909580fd6ba7580483ca5455b13eb6d22e700063ce0c1a5c6d2f5b161dfce0d777636fe9a712aa82f38a0585f2feabea3785b02bae7515 setup-modem.sh 5fd1dba489e994510264c64823c68e183c685d9bbc725a96e3eb6826c0f7e67cd0334efed926304b6b1e8403af92eccc05370b1360660af77529cefb58e843b5 uboot-script.cmd f963898fa2ce66bc830e56feeec6ffc9888834e14cc1591d72908ef45ad82532bc3ef5fb32413e07b6722749c9d03e7cf92f06f1fcb859c38b9297cf58e5cedd HiFi.conf e852b48a687f9b2a0eca444aa3d00a1818aead9f5e5d28e070b51c9d6f8ec648e66f1d88e2bfa94d74533f9ffb9aacc1703da2a06693f85fa04ff97fd7528012 PinePhone.conf diff --git a/device/main/device-pine64-pinephone/setup-modem.sh b/device/main/device-pine64-pinephone/setup-modem.sh index 2ba65fc72..71c894a30 100644 --- a/device/main/device-pine64-pinephone/setup-modem.sh +++ b/device/main/device-pine64-pinephone/setup-modem.sh @@ -6,6 +6,13 @@ log() { QMBNCFG_CONFIG="1" +if [ -z "$1" ] +then + DEV="/dev/EG25.AT" +else + DEV="$1" +fi + # Read current config QMBNCFG_ACTUAL_CONFIG=$(echo 'AT+QMBNCFG="AutoSel"' | atinout - $DEV -)