From 143efc60f2e97ab03718436b5fc7fd7e87b77473 Mon Sep 17 00:00:00 2001 From: Richard Acayan Date: Mon, 29 Jul 2024 16:53:31 -0400 Subject: [PATCH] google-sargo: do not enable HexagonRPCD on every upgrade (MR 5400) There is an issue where resuming from suspend crashes the ADSP, and rebooting the ADSP makes the entire device hang. Autosuspend has other issues affecting higher category devices (namely, wake on modem events), but it was still possible to resume before adding HexagonRPCD. For now, remove the user's maintenance burden in keeping HexagonRPCD disabled. --- device/testing/device-google-sargo/APKBUILD | 5 +++-- .../device-google-sargo-nonfree-firmware.post-upgrade | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) delete mode 120000 device/testing/device-google-sargo/device-google-sargo-nonfree-firmware.post-upgrade diff --git a/device/testing/device-google-sargo/APKBUILD b/device/testing/device-google-sargo/APKBUILD index b2e58c736..d3cc71ab4 100644 --- a/device/testing/device-google-sargo/APKBUILD +++ b/device/testing/device-google-sargo/APKBUILD @@ -3,7 +3,7 @@ pkgname=device-google-sargo pkgdesc="Google Pixel 3a" pkgver=4 -pkgrel=0 +pkgrel=1 url="https://postmarketos.org" license="MIT" arch="aarch64" @@ -54,9 +54,10 @@ nonfree_firmware() { soc-qcom-sdm845-modem soc-qcom-sdm845-nonfree-firmware " + # Enable HexagonRPCD by default, but not if the user installed this + # package then disabled it. install=" device-google-sargo-nonfree-firmware.post-install - device-google-sargo-nonfree-firmware.post-upgrade " # The q6voiced configuration can only be used if the ADSP is brought up diff --git a/device/testing/device-google-sargo/device-google-sargo-nonfree-firmware.post-upgrade b/device/testing/device-google-sargo/device-google-sargo-nonfree-firmware.post-upgrade deleted file mode 120000 index d04b21bc3..000000000 --- a/device/testing/device-google-sargo/device-google-sargo-nonfree-firmware.post-upgrade +++ /dev/null @@ -1 +0,0 @@ -device-google-sargo-nonfree-firmware.post-install \ No newline at end of file