forge/pmaports
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions
pmaports/.gitlab-ci/apkbuild-linting.py

33 lines
957 B
Python
Raw Normal View History

CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-3.0-or-later
import common
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
import os.path
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
import subprocess
import sys
if __name__ == "__main__":
common.add_upstream_git_remote()
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
apkbuilds = {file for file in common.get_changed_files(removed=False)
if os.path.basename(file) == "APKBUILD"}
if len(apkbuilds) < 1:
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
print("No APKBUILDs to lint")
sys.exit(0)
issues = []
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
for apkbuild in apkbuilds:
if apkbuild.startswith("temp/") or apkbuild.startswith("cross/"):
print(f"NOTE: Skipping linting of {apkbuild}")
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
continue
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
result = subprocess.run(["apkbuild-lint", apkbuild], capture_output=True)
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
if len(result.stdout) > 0:
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
issues.append([apkbuild, result.stdout.decode("utf-8")])
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
if len(issues) > 0:
print("Linting issues found:")
for issue in issues:
print(issue[0] + ": " + issue[1])
sys.exit(1)
Reference in a new issue Copy permalink