forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
linux-uconsole/tools/lib/bpf
History
Leo Yan ef5b204336 bpf, libbpf, smatch: Fix potential NULL pointer dereference 
[ Upstream commit 33bae185f7 ]

Based on the following report from Smatch, fix the potential NULL
pointer dereference check:

  tools/lib/bpf/libbpf.c:3493
  bpf_prog_load_xattr() warn: variable dereferenced before check 'attr'
  (see line 3483)

  3479 int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr,
  3480                         struct bpf_object **pobj, int *prog_fd)
  3481 {
  3482         struct bpf_object_open_attr open_attr = {
  3483                 .file           = attr->file,
  3484                 .prog_type      = attr->prog_type,
                                         ^^^^^^
  3485         };

At the head of function, it directly access 'attr' without checking
if it's NULL pointer. This patch moves the values assignment after
validating 'attr' and 'attr->file'.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-07-26 09:14:15 +02:00
..
.gitignore tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf 2015-11-05 12:47:51 -03:00
bpf.c tools/bpf: fix perf build error with uClibc (seen on ARC) 2019-05-31 06:46:08 -07:00
bpf.h libbpf: fix samples/bpf build failure due to undefined UINT32_MAX 2019-05-31 06:46:14 -07:00
btf.c Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net 2018-08-11 17:52:00 -07:00
btf.h Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net 2018-08-11 17:52:00 -07:00
Build tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems 2018-09-18 10:16:18 -03:00
libbpf.c bpf, libbpf, smatch: Fix potential NULL pointer dereference 2019-07-26 09:14:15 +02:00
libbpf.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2018-08-07 11:02:05 -07:00
libbpf_errno.c tools: libbpf: move library error code into a separate file 2018-07-11 22:13:34 +02:00
Makefile libbpf: force fixdep compilation at the start of the build 2019-04-05 22:32:57 +02:00
nlattr.c libbpf: add error reporting in XDP 2018-02-02 17:53:48 -08:00
nlattr.h libbpf: add error reporting in XDP 2018-02-02 17:53:48 -08:00
str_error.c tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems 2018-09-18 10:16:18 -03:00
str_error.h tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems 2018-09-18 10:16:18 -03:00