linux-uconsole/drivers/nfc
Duoming Zhou 50403ee6da nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout
[ Upstream commit f1e941dbf8 ]

When the pn532 uart device is detaching, the pn532_uart_remove()
is called. But there are no functions in pn532_uart_remove() that
could delete the cmd_timeout timer, which will cause use-after-free
bugs. The process is shown below:

    (thread 1)                  |        (thread 2)
                                |  pn532_uart_send_frame
pn532_uart_remove               |    mod_timer(&pn532->cmd_timeout,...)
  ...                           |    (wait a time)
  kfree(pn532) //FREE           |    pn532_cmd_timeout
                                |      pn532_uart_send_frame
                                |        pn532->... //USE

This patch adds del_timer_sync() in pn532_uart_remove() in order to
prevent the use-after-free bugs. What's more, the pn53x_unregister_nfc()
is well synchronized, it sets nfc_dev->shutting_down to true and there
are no syscalls could restart the cmd_timeout timer.

Fixes: c656aa4c27 ("nfc: pn533: add UART phy driver")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-08-31 17:15:16 +02:00
..
fdp
microread
nfcmrvl nfc: nfcmrvl: Fix irq_of_parse_and_map() return value 2022-07-07 17:52:18 +02:00
nxp-nci NFC: nxp-nci: don't print header length mismatch on i2c error 2022-07-21 21:20:14 +02:00
pn533 nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout 2022-08-31 17:15:16 +02:00
pn544
s3fwrn5 nfc: s3fwrn5: Release the nfc firmware 2020-12-30 11:53:53 +01:00
st-nci
st21nfca nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION 2022-06-14 18:32:46 +02:00
st95hf
Kconfig
Makefile
mei_phy.c
mei_phy.h
nfcsim.c nfc: nfcsim: fix use after free during module unload 2021-08-04 12:46:41 +02:00
port100.c NFC: port100: fix use-after-free in port100_send_complete 2022-03-16 14:15:59 +01:00
trf7970a.c nfc: remove unneeded break 2020-10-20 10:36:41 -07:00