Taehee Yoo cee05c0371 netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace() ... [ Upstream commit 4c05ec4738 ] basechain->stats is rcu protected data which is updated from nft_chain_stats_replace(). This function is executed from the commit phase which holds the pernet nf_tables commit mutex - not the global nfnetlink subsystem mutex. Test commands to reproduce the problem are: %iptables-nft -I INPUT %iptables-nft -Z %iptables-nft -Z This patch uses RCU calls to handle basechain->stats updates to fix a splat that looks like: [89279.358755] ============================= [89279.363656] WARNING: suspicious RCU usage [89279.368458] 4.20.0-rc2+ #44 Tainted: G W L [89279.374661] ----------------------------- [89279.379542] net/netfilter/nf_tables_api.c:1404 suspicious rcu_dereference_protected() usage! [...] [89279.406556] 1 lock held by iptables-nft/5225: [89279.411728] #0: 00000000bf45a000 (&net->nft.commit_mutex){+.+.}, at: nf_tables_valid_genid+0x1f/0x70 [nf_tables] [89279.424022] stack backtrace: [89279.429236] CPU: 0 PID: 5225 Comm: iptables-nft Tainted: G W L 4.20.0-rc2+ #44 [89279.430135] Call Trace: [89279.430135] dump_stack+0xc9/0x16b [89279.430135] ? show_regs_print_info+0x5/0x5 [89279.430135] ? lockdep_rcu_suspicious+0x117/0x160 [89279.430135] nft_chain_commit_update+0x4ea/0x640 [nf_tables] [89279.430135] ? sched_clock_local+0xd4/0x140 [89279.430135] ? check_flags.part.35+0x440/0x440 [89279.430135] ? __rhashtable_remove_fast.constprop.67+0xec0/0xec0 [nf_tables] [89279.430135] ? sched_clock_cpu+0x126/0x170 [89279.430135] ? find_held_lock+0x39/0x1c0 [89279.430135] ? hlock_class+0x140/0x140 [89279.430135] ? is_bpf_text_address+0x5/0xf0 [89279.430135] ? check_flags.part.35+0x440/0x440 [89279.430135] ? __lock_is_held+0xb4/0x140 [89279.430135] nf_tables_commit+0x2555/0x39c0 [nf_tables] Fixes: f102d66b33 ("netfilter: nf_tables: use dedicated mutex to guard transactions") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-01-13 09:50:57 +01:00
..
acpi	ACPICA: Update version to 20180810	2018-08-14 23:49:13 +02:00
asm-generic	mm: introduce mm_[p4d|pud|pmd]_folded	2018-12-29 13:37:58 +01:00
clocksource
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
drm	drm: Get ref on CRTC commit object when waiting for flip_done	2018-10-18 14:23:13 -04:00
dt-bindings	ARM: SoC: late updates	2018-08-25 14:12:36 -07:00
keys
kvm	KVM: arm/arm64: vgic-v3: Add core support for Group0 SGIs	2018-08-12 12:06:34 +01:00
linux	netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()	2019-01-13 09:50:57 +01:00
math-emu
media	media: cec: keep track of outstanding transmits	2019-01-09 17:38:46 +01:00
memory
misc
net	sock: Make sock->sk_stamp thread-safe	2019-01-09 17:38:33 +01:00
pcmcia	pcmcia: remove long deprecated pcmcia_request_exclusive_irq() function	2018-08-18 12:30:42 -07:00
ras
rdma	IB/rxe: Revise the ib_wr_opcode enum	2018-11-13 11:08:43 -08:00
scsi	SCSI misc on 20180815	2018-08-15 22:06:26 -07:00
soc	soc: fsl: qbman: add APIs to retrieve the probing status	2018-09-27 15:43:35 -05:00
sound	ALSA: pcm: Fix interval evaluation with openmin/max	2018-12-13 09:16:16 +01:00
target
trace	ext4: force inode writes when nfsd calls commit_metadata()	2019-01-09 17:38:43 +01:00
uapi	Input: restore EV_ABS ABS_RESERVED	2019-01-13 09:50:56 +01:00
video	fbdev changes for v4.19:	2018-08-23 15:44:58 -07:00
xen	Revert "xen/balloon: Mark unallocated host memory as UNUSABLE"	2018-12-17 09:24:39 +01:00