Gabriel Krisman Bertazi e1a3bc4583 drm: qxl: Don't alloc fbdev if emulation is not supported ... [ Upstream commit 861078381b ] If fbdev emulation is disabled, the QXL shutdown path will try to clean a framebuffer that wasn't initialized, hitting the Oops below. The problem is that even when FBDEV_EMULATION is disabled we allocate the qfbdev strutucture, but we don't initialize it. The fix is to stop allocating the memory, since it won't be used. This allows the existing verification in the cleanup hook to do it's job preventing the oops. Now that we don't allocate the unused fbdev structure, we need to be careful when dereferencing it in the PM suspend hook. [ 24.284684] BUG: unable to handle kernel NULL pointer dereference at 00000000000002e0 [ 24.285627] IP: mutex_lock+0x18/0x30 [ 24.286049] PGD 78cdf067 [ 24.286050] PUD 7940f067 [ 24.286344] PMD 0 [ 24.286649] [ 24.287072] Oops: 0002 [#1] SMP [ 24.287422] Modules linked in: qxl [ 24.287806] CPU: 0 PID: 2328 Comm: bash Not tainted 4.10.0-rc5+ #97 [ 24.288515] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014 [ 24.289681] task: ffff88007c4c0000 task.stack: ffffc90001b58000 [ 24.290354] RIP: 0010:mutex_lock+0x18/0x30 [ 24.290812] RSP: 0018:ffffc90001b5bcb0 EFLAGS: 00010246 [ 24.291401] RAX: 0000000000000000 RBX: 00000000000002e0 RCX: 0000000000000000 [ 24.292209] RDX: ffff88007c4c0000 RSI: 0000000000000001 RDI: 00000000000002e0 [ 24.292987] RBP: ffffc90001b5bcb8 R08: fffffffffffffffe R09: 0000000000000001 [ 24.293797] R10: ffff880078d80b80 R11: 0000000000011400 R12: 0000000000000000 [ 24.294601] R13: 00000000000002e0 R14: ffffffffa0009c28 R15: 0000000000000060 [ 24.295439] FS: 00007f30e3acbb40(0000) GS:ffff88007fc00000(0000) knlGS:0000000000000000 [ 24.296364] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 24.296997] CR2: 00000000000002e0 CR3: 0000000078c7b000 CR4: 00000000000006f0 [ 24.297813] Call Trace: [ 24.298097] drm_framebuffer_cleanup+0x1f/0x70 [ 24.298612] qxl_fbdev_fini+0x68/0x90 [qxl] [ 24.299074] qxl_modeset_fini+0xd/0x30 [qxl] [ 24.299562] qxl_pci_remove+0x22/0x50 [qxl] [ 24.300025] pci_device_remove+0x34/0xb0 [ 24.300507] device_release_driver_internal+0x150/0x200 [ 24.301082] device_release_driver+0xd/0x10 [ 24.301587] unbind_store+0x108/0x150 [ 24.301993] drv_attr_store+0x20/0x30 [ 24.302402] sysfs_kf_write+0x32/0x40 [ 24.302827] kernfs_fop_write+0x108/0x190 [ 24.303269] __vfs_write+0x23/0x120 [ 24.303678] ? security_file_permission+0x36/0xb0 [ 24.304193] ? rw_verify_area+0x49/0xb0 [ 24.304636] vfs_write+0xb0/0x190 [ 24.305004] SyS_write+0x41/0xa0 [ 24.305362] entry_SYSCALL_64_fastpath+0x1a/0xa9 [ 24.305887] RIP: 0033:0x7f30e31d9620 [ 24.306285] RSP: 002b:00007ffc54b47e68 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 24.307128] RAX: ffffffffffffffda RBX: 00007f30e3497600 RCX: 00007f30e31d9620 [ 24.307928] RDX: 000000000000000d RSI: 0000000000da2008 RDI: 0000000000000001 [ 24.308727] RBP: 000000000070bc60 R08: 00007f30e3498760 R09: 00007f30e3acbb40 [ 24.309504] R10: 0000000000000073 R11: 0000000000000246 R12: 0000000000000001 [ 24.310295] R13: 0000000000000000 R14: 0000000000000000 R15: 00007ffc54b47f34 [ 24.311095] Code: 0e 01 e9 7b fe ff ff 66 90 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 53 48 89 fb e8 83 e8 ff ff 65 48 8b 14 25 40 c4 00 00 31 c0 <3e> 48 0f b1 13 48 85 c0 74 08 48 89 df e8 66 fd ff ff 5b 5d c3 [ 24.313182] RIP: mutex_lock+0x18/0x30 RSP: ffffc90001b5bcb0 [ 24.313811] CR2: 00000000000002e0 [ 24.314208] ---[ end trace 29669c1593cae14b ]--- Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Link: http://patchwork.freedesktop.org/patch/msgid/20170227203330.18542-1-krisman@collabora.co.uk Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-03-22 09:23:19 +01:00
..
accessibility
acpi	ACPI: sbshc: remove raw pointer from printk() message	2018-02-16 20:09:47 +01:00
amba
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	ahci: Add Intel Cannon Lake PCH-H PCI ID	2018-02-16 20:09:42 +01:00
atm	atm: horizon: Fix irq release error	2017-12-16 10:33:55 +01:00
auxdisplay
base	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:06:08 +01:00
bcma	bcma: use (get|put)_device when probing/removing device driver	2017-03-12 06:37:30 +01:00
block	loop: Fix lost writes caused by missing flag	2018-03-18 11:17:49 +01:00
bluetooth	Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version	2018-02-16 20:09:46 +01:00
bus	sunxi-rsb: Include OF based modalias in device uevent	2018-01-10 09:27:09 +01:00
cdrom
char	tpm_i2c_nuvoton: fix potential buffer overruns caused by bit glitches on the bus	2018-03-11 16:19:44 +01:00
clk	clk: tegra: Fix cclk_lp divisor register	2017-12-20 10:04:59 +01:00
clocksource	clockevents/drivers/cs5535: Improve resilience to spurious interrupts	2017-10-27 10:23:17 +02:00
connector
cpufreq	cpufreq: s3c24xx: Fix broken s3c_cpufreq_init()	2018-03-11 16:19:44 +01:00
cpuidle	cpuidle: fix broadcast control when broadcast can not be entered	2017-12-25 14:22:15 +01:00
crypto	crypto: s5p-sss - Fix kernel Oops in AES-ECB mode	2018-02-25 11:03:55 +01:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: zx: fix build warning	2018-02-25 11:03:50 +01:00
dma-buf
edac	EDAC, octeon: Fix an uninitialized variable warning	2018-02-16 20:09:47 +01:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire
firmware	efi/esrt: Cleanup bad memory map log messages	2017-12-20 10:04:56 +01:00
fmc
fpga
gpio	gpio: xgene: mark PM functions as __maybe_unused	2018-02-25 11:03:50 +01:00
gpu	drm: qxl: Don't alloc fbdev if emulation is not supported	2018-03-22 09:23:19 +01:00
hid	HID: reject input outside logical range only if null state is set	2018-03-22 09:23:19 +01:00
hsi
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	hwmon: (pmbus) Use 64bit math for DIRECT format values	2018-02-03 17:04:28 +01:00
hwspinlock
hwtracing	intel_th: pci: Add Gemini Lake support	2017-12-20 10:04:54 +01:00
i2c	i2c: remove __init from i2c_register_board_info()	2018-02-25 11:03:48 +01:00
ide
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio: adis_lib: Initialize trigger before requesting interrupt	2018-02-28 10:17:22 +01:00
infiniband	RDMA/mlx5: Fix integer overflow while resizing CQ	2018-03-18 11:17:48 +01:00
input	Input: tsc2007 - check for presence and power down tsc2007 during probe	2018-03-22 09:23:19 +01:00
iommu	iommu/arm-smmu-v3: Don't free page table ops twice	2018-01-17 09:35:25 +01:00
ipack
irqchip	irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq()	2018-02-28 10:17:22 +01:00
isdn	isdn: sc: work around type mismatch warning	2018-02-25 11:03:51 +01:00
leds	Revert "led: core: Fix brightness setting when setting delay_off=0"	2018-03-11 16:19:45 +01:00
lguest
lightnvm
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	bcache: don't attach backing with duplicate UUID	2018-03-18 11:17:49 +01:00
media	tc358743: fix register i2c_rd/wr function fix	2018-03-18 11:17:51 +01:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick
message	mptfusion: hide unused seq_mpt_print_ioc_summary function	2018-02-25 11:03:45 +01:00
mfd	mfd: twl6040: Fix child-node lookup	2018-01-02 20:33:20 +01:00
misc	cxl: Check if vphb exists before iterating over AFU devices	2017-12-25 14:22:08 +01:00
mmc	mmc: sdhci-of-esdhc: add/remove some quirks according to vendor version	2018-01-31 12:06:09 +01:00
mtd	ubi: Fix race condition between ubi volume creation and udev	2018-03-18 11:17:52 +01:00
net	ppp: prevent unregistered channels from connecting to PPP units	2018-03-11 16:19:46 +01:00
nfc	nfc: fdp: fix NULL pointer dereference	2017-08-06 19:19:40 -07:00
ntb	ntb_transport: fix bug calculating num_qps_mw	2017-08-30 10:19:29 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme: Fix managing degraded controllers	2018-02-16 20:09:47 +01:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: device: Export of_device_{get_modalias, uvent_modalias} to modules	2017-07-27 15:06:09 -07:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parisc, parport_gsc: Fixes for printk continuation lines	2017-06-17 06:39:37 +02:00
pci	PCI: keystone: Fix interrupt-controller-node lookup	2018-02-28 10:17:21 +01:00
pcmcia
perf
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: sunxi: Fix A80 interrupt pin bank	2018-02-25 11:03:39 +01:00
platform	dell-wmi, dell-laptop: depends DMI	2018-02-25 11:03:51 +01:00
pnp
power	power: bq27xxx_battery: mark some symbols __maybe_unused	2018-02-25 11:03:50 +01:00
powercap
pps
ps3
ptp
pwm	pwm: pca9685: Fix period change with same duty cycle	2017-03-15 09:57:14 +08:00
rapidio
ras
regulator	regulator: fan53555: fix I2C device ids	2017-11-02 09:40:50 +01:00
remoteproc
reset
rpmsg
rtc	rtc-opal: Fix handling of firmware error codes, prevent busy loops	2018-02-22 15:44:59 +01:00
s390	s390/qeth: fix IPA command submission race	2018-03-11 16:19:47 +01:00
sbus
scsi	scsi: qla2xxx: Replace fcport alloc with qla2x00_alloc_fcport	2018-03-18 11:17:52 +01:00
sfi
sh
sn
soc
spi	spi: atmel: fixed spin_lock usage inside atmel_spi_remove	2018-03-03 10:19:42 +01:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: wilc1000: add check for kmalloc allocation failure.	2018-03-22 09:23:19 +01:00
target	target/user: Fix cast from pointer to phys_addr_t	2018-02-25 11:03:46 +01:00
tc
thermal	thermal: spear: use __maybe_unused for PM functions	2018-02-25 11:03:44 +01:00
thunderbolt
tty	serial: 8250_pci: Add Brainboxes UC-260 4 port serial device	2018-03-18 11:17:53 +01:00
uio
usb	usb: gadget: f_fs: Fix use-after-free in ffs_fs_kill_sb()	2018-03-18 11:17:53 +01:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio-pci: Handle error from pci_iomap	2017-08-06 19:19:46 -07:00
vhost	vhost_net: stop device during reset owner	2018-02-16 20:09:38 +01:00
video	fbdev: sm712fb: avoid unused function warnings	2018-02-25 11:03:47 +01:00
virt
virtio	virtio_balloon: prevent uninitialized variable use	2018-02-25 11:03:42 +01:00
vlynq
vme	vme: Fix wrong pointer utilization in ca91cx42_slave_get	2017-01-19 20:17:21 +01:00
w1	w1: ds2490: USB transfer buffers need to be DMAable	2017-03-12 06:37:29 +01:00
watchdog	watchdog: hpwdt: fix unused variable warning	2018-03-18 11:17:50 +01:00
xen	xen/gntdev: Fix partial gntdev_mmap() cleanup	2018-03-03 10:19:45 +01:00
zorro
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00