Eric Paris d033ce7618 netfilter: NF_HOOK_COND has wrong conditional ... commit ac5aa2e333 upstream. The NF_HOOK_COND returns 0 when it shouldn't due to what I believe to be an error in the code as the order of operations is not what was intended. C will evalutate == before =. Which means ret is getting set to the bool result, rather than the return value of the function call. The code says if (ret = function() == 1) when it meant to say: if ((ret = function()) == 1) Normally the compiler would warn, but it doesn't notice it because its a actually complex conditional and so the wrong code is wrapped in an explict set of () [exactly what the compiler wants you to do if this was intentional]. Fixing this means that errors when netfilter denies a packet get propagated back up the stack rather than lost. Problem introduced by commit 2249065f (netfilter: get rid of the grossness in netfilter.h). Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>		2010-12-09 13:32:52 -08:00
..
acpi	ACPI: Fix typos	2010-09-28 21:38:19 -04:00
asm-generic	gpio: doc updates	2010-09-09 18:57:24 -07:00
crypto
drm	drm/ttm: Fix two race conditions + fix busy codepaths	2010-10-06 09:04:43 +10:00
keys
linux	netfilter: NF_HOOK_COND has wrong conditional	2010-12-09 13:32:52 -08:00
math-emu
media	V4L/DVB: videobuf-dma-sg: set correct size in last sg element	2010-09-27 22:22:01 -03:00
mtd	mtd: Update copyright notices	2010-08-08 20:58:20 +01:00
net	mac80211: clear txflags for ps-filtered frames	2010-12-09 13:32:12 -08:00
pcmcia
rdma
rxrpc
scsi	scsi: use __uX types for headers exported to user space	2010-08-11 08:59:01 -07:00
sound	ALSA: emu10k1 - delay the PCM interrupts (add pcm_irq_delay parameter)	2010-08-18 15:10:59 +02:00
trace	Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2010-08-24 12:21:49 -07:00
video	include: replace unifdef-y with header-y	2010-08-14 22:26:51 +02:00
xen	xen: pvhvm: make it clearer that XEN_UNPLUG_* define bits in a bitfield	2010-08-23 12:01:35 +01:00
Kbuild