linux-uconsole/arch/x86/kernel/apic
Suresh Siddha 4a10e12966 x86: Fix double enable_IR_x2apic() call on SMP kernel on !SMP boards
commit 472a474c66 upstream.

Jan Grossmann reported kernel boot panic while booting SMP
kernel on his system with a single core cpu. SMP kernels call
enable_IR_x2apic() from native_smp_prepare_cpus() and on
platforms where the kernel doesn't find SMP configuration we
ended up again calling enable_IR_x2apic() from the
APIC_init_uniprocessor() call in the smp_sanity_check(). Thus
leading to kernel panic.

Don't call enable_IR_x2apic() and default_setup_apic_routing()
from APIC_init_uniprocessor() in CONFIG_SMP case.

NOTE: this kind of non-idempotent and assymetric initialization
sequence is rather fragile and unclean, we'll clean that up
in v2.6.35. This is the minimal fix for v2.6.34.

Reported-by: Jan.Grossmann@kielnet.net
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: <jbarnes@virtuousgeek.org>
Cc: <david.woodhouse@intel.com>
Cc: <weidong.han@intel.com>
Cc: <youquan.song@intel.com>
Cc: <Jan.Grossmann@kielnet.net>
LKML-Reference: <1270083887.7835.78.camel@sbs-t61.sc.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-04-26 07:41:24 -07:00
..
apic.c x86: Fix double enable_IR_x2apic() call on SMP kernel on !SMP boards 2010-04-26 07:41:24 -07:00
apic_flat_64.c x86, apic: use physical mode for IBM summit platforms 2010-01-22 15:18:13 -08:00
bigsmp_32.c x86: apic namespace cleanup 2009-08-31 21:30:47 +02:00
es7000_32.c Merge branch 'for-ingo' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-sfi-2.6 into x86/apic 2009-08-29 09:31:47 +02:00
io_apic.c x86: Fix SCI on IOAPIC != 0 2010-03-15 08:50:07 -07:00
ipi.c Merge commit 'v2.6.31-rc7' into x86/cleanups 2009-08-24 12:25:54 +02:00
Makefile x86, apic: separate 32-bit setup functionality out of apic_32.c 2009-02-17 23:12:48 +01:00
nmi.c sysctl: remove "struct file *" argument of ->proc_handler 2009-09-24 07:21:04 -07:00
numaq_32.c x86: apic namespace cleanup 2009-08-31 21:30:47 +02:00
probe_32.c x86, apic: Don't use logical-flat mode when CPU hotplug may exceed 8 CPUs 2010-04-01 15:58:14 -07:00
probe_64.c x86, apic: Don't use logical-flat mode when CPU hotplug may exceed 8 CPUs 2010-04-01 15:58:14 -07:00
summit_32.c x86: apic namespace cleanup 2009-08-31 21:30:47 +02:00
x2apic_cluster.c x86: Fix MSI-X initialization by using online_mask for x2apic target_cpus 2009-08-08 17:04:58 +02:00
x2apic_phys.c x86: Fix MSI-X initialization by using online_mask for x2apic target_cpus 2009-08-08 17:04:58 +02:00
x2apic_uv_x.c x86: SGI UV: Fix mapping of MMIO registers 2010-01-22 15:18:16 -08:00