raid10 discard optimizations having introduced potential for
corruption. Those reverts exposed a dm-raid.c compiler warning that
wasn't ever knowingly introduced. That min_not_zero() type mismatch
warning was thought to be safely fixed simply by changing 'struct
mddev' to use 'unsigned int' rather than int for chunk_sectors members
in that struct. I proposed either using a cast local to dm-raid.c but
thought changing the type to 'unsigned int' more correct. While that
may be, not enough testing was paired with code review associated with
making that change. As such we were left exposed and the result was a
report that with v5.10 btrfs on MD RAID6 failed to mount:
https://lkml.org/lkml/2020/12/14/7
Given that report, it is justified to simply revert these offending
commits. stable@ has already taken steps to revert these for 5.10.1 -
this pull request just makes sure mainline does so too.
-----BEGIN PGP SIGNATURE-----
iQFHBAABCAAxFiEEJfWUX4UqZ4x1O2wixSPxCi2dA1oFAl/XoXMTHHNuaXR6ZXJA
cmVkaGF0LmNvbQAKCRDFI/EKLZ0DWtVIB/9GL6t9jz3xCsyECmHG068T4KkqH5yd
uczj2UQ7Bjw797WH6D+bDYIbV6GqDDVJ7UTu31oSOB6vObJk0R7ZXq9eVxccFpqI
3eRftQpqF/l5PrDUPgpPUTblhLzSUtggwqfm7gN99HlVZot3WsVrxIRxQYIFVQC7
9o2mjFjrXud6kejZFaXvt9CMgOWDuWx/i2FI6qIhJerMSChjuKMO6h3rCvmw2tqw
aS9ZuO/qMBHrd+FiuBVugTUE2zuZX4ixDtQWBnTe8pMX8dNw2dG6FFXFR8WkB9Wa
AI1qBcwQgt2c1YmIO2F/AD36uT0fOHqvw5w8xCeJpSlgQCxcx2iN7ec4
=H7tI
-----END PGP SIGNATURE-----
Merge tag 'for-5.11/revert-problem-v5.10-raid-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
Pull MD regression reverts from Mike Snitzer:
"A cascade of MD reverts occurred late in the v5.10-rcX cycle due to MD
raid10 discard optimizations having introduced potential for
corruption.
Those reverts exposed a dm-raid.c compiler warning that wasn't ever
knowingly introduced. That min_not_zero() type mismatch warning was
thought to be safely fixed simply by changing 'struct mddev' to use
'unsigned int' rather than int for chunk_sectors members in that
struct.
I proposed either using a cast local to dm-raid.c but thought changing
the type to 'unsigned int' more correct. While that may be, not enough
testing was paired with code review associated with making that
change. As such we were left exposed and the result was a report that
with v5.10 btrfs on MD RAID6 failed to mount:
https://lkml.org/lkml/2020/12/14/7
Given that report, it is justified to simply revert these offending
commits. stable@ has already taken steps to revert these for 5.10.1 -
this just makes sure mainline does so too"
* tag 'for-5.11/revert-problem-v5.10-raid-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
Revert "dm raid: fix discard limits for raid1 and raid10"
Revert "md: change mddev 'chunk_sectors' from int to unsigned"
ae1985b50a