Christophe Leroy aae4cd90ce spi: fsl: don't map irq during probe ... [ Upstream commit 3194d2533e ] With lastest kernel, the following warning is observed at startup: [ 1.500609] ------------[ cut here ]------------ [ 1.505225] remove_proc_entry: removing non-empty directory 'irq/22', leaking at least 'fsl_spi' [ 1.514234] WARNING: CPU: 0 PID: 1 at fs/proc/generic.c:682 remove_proc_entry+0x198/0x1c0 [ 1.522403] CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.0-s3k-dev-02248-g93532430a4ff #2564 [ 1.530724] NIP: c0197694 LR: c0197694 CTR: c0050d80 [ 1.535762] REGS: df4a5af0 TRAP: 0700 Not tainted (5.4.0-02248-g93532430a4ff) [ 1.543818] MSR: 00029032 <EE,ME,IR,DR,RI> CR: 22028222 XER: 00000000 [ 1.550524] [ 1.550524] GPR00: c0197694 df4a5ba8 df4a0000 00000054 00000000 00000000 00004a38 00000010 [ 1.550524] GPR08: c07c5a30 00000800 00000000 00001032 22000208 00000000 c0004b14 00000000 [ 1.550524] GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 c0830000 c07fc078 [ 1.550524] GPR24: c08e8ca0 df665d10 df60ea98 c07c9db8 00000001 df5d5ae3 df5d5a80 df43f8e3 [ 1.585327] NIP [c0197694] remove_proc_entry+0x198/0x1c0 [ 1.590628] LR [c0197694] remove_proc_entry+0x198/0x1c0 [ 1.595829] Call Trace: [ 1.598280] [df4a5ba8] [c0197694] remove_proc_entry+0x198/0x1c0 (unreliable) [ 1.605321] [df4a5bd8] [c0067acc] unregister_irq_proc+0x5c/0x70 [ 1.611238] [df4a5bf8] [c005fbc4] free_desc+0x3c/0x80 [ 1.616286] [df4a5c18] [c005fe2c] irq_free_descs+0x70/0xa8 [ 1.621778] [df4a5c38] [c033d3fc] of_fsl_spi_probe+0xdc/0x3cc [ 1.627525] [df4a5c88] [c02f0f64] platform_drv_probe+0x44/0xa4 [ 1.633350] [df4a5c98] [c02eee44] really_probe+0x1ac/0x418 [ 1.638829] [df4a5cc8] [c02ed3e8] bus_for_each_drv+0x64/0xb0 [ 1.644481] [df4a5cf8] [c02ef950] __device_attach+0xd4/0x128 [ 1.650132] [df4a5d28] [c02ed61c] bus_probe_device+0xa0/0xbc [ 1.655783] [df4a5d48] [c02ebbe8] device_add+0x544/0x74c [ 1.661096] [df4a5d88] [c0382b78] of_platform_device_create_pdata+0xa4/0x100 [ 1.668131] [df4a5da8] [c0382cf4] of_platform_bus_create+0x120/0x20c [ 1.674474] [df4a5df8] [c0382d50] of_platform_bus_create+0x17c/0x20c [ 1.680818] [df4a5e48] [c0382e88] of_platform_bus_probe+0x9c/0xf0 [ 1.686907] [df4a5e68] [c0751404] __machine_initcall_cmpcpro_cmpcpro_declare_of_platform_devices+0x74/0x1a4 [ 1.696629] [df4a5e98] [c072a4cc] do_one_initcall+0x8c/0x1d4 [ 1.702282] [df4a5ef8] [c072a768] kernel_init_freeable+0x154/0x204 [ 1.708455] [df4a5f28] [c0004b2c] kernel_init+0x18/0x110 [ 1.713769] [df4a5f38] [c00122ac] ret_from_kernel_thread+0x14/0x1c [ 1.719926] Instruction dump: [ 1.722889] 2c030000 4182004c 3863ffb0 3c80c05f 80e3005c 388436a0 3c60c06d 7fa6eb78 [ 1.730630] 7fe5fb78 38840280 38634178 4be8c611 <0fe00000> 4bffff6c 3c60c071 7fe4fb78 [ 1.738556] ---[ end trace 05d0720bf2e352e2 ]--- The problem comes from the error path which calls irq_dispose_mapping() while the IRQ has been requested with devm_request_irq(). IRQ doesn't need to be mapped with irq_of_parse_and_map(). The only need is to get the IRQ virtual number. For that, use of_irq_to_resource() instead of the irq_of_parse_and_map()/irq_dispose_mapping() pair. Fixes: 500a32abaf ("spi: fsl: Call irq_dispose_mapping in err path") Cc: stable@vger.kernel.org Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Link: https://lore.kernel.org/r/518cfb83347d5372748e7fe72f94e2e9443d0d4a.1575905123.git.christophe.leroy@c-s.fr Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-01-04 19:13:43 +01:00
..
accessibility
acpi	ACPI: button: Add DMI quirk for Medion Akoya E2215T	2019-12-31 16:35:28 +01:00
amba
android	binder: Handle start==NULL in binder_update_page_range()	2019-12-13 08:52:52 +01:00
ata	libata: Ensure ata_port probe has completed before detach	2019-12-31 16:35:31 +01:00
atm	atm: zatm: Fix empty body Clang warnings	2019-12-01 09:16:41 +01:00
auxdisplay
base	drivers/base/platform.c: kmemleak ignore a known leak	2019-12-05 09:21:04 +01:00
bcma
block	nbd: fix shutdown and recv work deadlock v2	2019-12-31 16:36:36 +01:00
bluetooth	Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading	2019-12-05 09:20:39 +01:00
bus	bus: ti-sysc: Fix getting optional clocks in clock_roles	2019-12-13 08:51:23 +01:00
cdrom	cdrom: respect device capabilities during opening action	2020-01-04 19:13:12 +01:00
char	ipmi: Don't allow device module unload when in use	2019-12-31 16:35:23 +01:00
clk	clk: pxa: fix one of the pxa RTC clocks	2020-01-04 19:12:57 +01:00
clocksource	clocksource/drivers/timer-of: Use unique device name instead of timer	2020-01-04 19:12:45 +01:00
connector
cpufreq	cpufreq: Register drivers only after CPU devices have been registered	2019-12-31 16:36:01 +01:00
cpuidle	cpuidle: Do not unset the driver if it is there already	2019-12-17 20:35:00 +01:00
crypto	crypto: vmx - Avoid weird build failures	2019-12-31 16:36:13 +01:00
dax
dca
devfreq	PM / devfreq: Lock devfreq in trans_stat_show	2019-12-17 20:35:03 +01:00
dio
dma	dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset	2020-01-04 19:12:38 +01:00
dma-buf	dma-buf: Fix memory leak in sync_file_merge()	2019-12-21 10:57:38 +01:00
edac	EDAC/ghes: Fix grain calculation	2019-12-31 16:35:58 +01:00
eisa
extcon	extcon: sm5502: Reset registers during initialization	2019-12-31 16:35:11 +01:00
firewire
firmware	firmware: arm_scmi: Avoid double free in error flow	2019-12-17 20:35:52 +01:00
fmc
fpga	fpga: altera-ps-spi: Fix getting of optional confd gpio	2019-09-21 07:16:53 +02:00
fsi	fsi: core: Fix small accesses and unaligned offsets via sysfs	2019-12-31 16:35:55 +01:00
gnss
gpio	gpio: mpc8xxx: Don't overwrite default irq_set_type callback	2020-01-04 19:13:07 +01:00
gpu	drm/amdgpu: fix uninitialized variable pasid_mapping_needed	2019-12-31 16:36:19 +01:00
hid	HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device	2020-01-04 19:13:00 +01:00
hsi
hv	vmbus: keep pointer to ring buffer page	2019-11-20 18:47:31 +01:00
hwmon	hwmon: (npcm-750-pwm-fan) Change initial pwm target to 255	2019-11-24 08:21:01 +01:00
hwspinlock
hwtracing	intel_th: pci: Add Elkhart Lake SOC support	2019-12-31 16:36:24 +01:00
i2c	i2c: imx: don't print error message on probe defer	2019-12-13 08:51:57 +01:00
ide
idle
iio	iio: dac: ad5446: Add support for new AD5600 DAC	2019-12-31 16:36:00 +01:00
infiniband	RDMA/qedr: Fix memory leak in user qp and mr	2019-12-31 16:35:29 +01:00
input	Input: atmel_mxt_ts - disable IRQ across suspend	2020-01-04 19:12:36 +01:00
iommu	iommu/tegra-smmu: Fix page tables in > 4 GiB memory	2020-01-04 19:12:38 +01:00
ipack
irqchip	irqchip: ingenic: Error out if IRQ domain creation failed	2020-01-04 19:12:52 +01:00
isdn	staging: gigaset: add endpoint-type sanity check	2019-12-17 20:34:33 +01:00
leds	leds: lm3692x: Handle failure to probe the regulator	2020-01-04 19:12:43 +01:00
lightnvm	lightnvm: pblk: consider max hw sectors supported for max_write_pgs	2019-11-24 08:20:52 +01:00
macintosh	macintosh/windfarm_smu_sat: Fix debug output	2019-12-01 09:16:37 +01:00
mailbox	mailbox: imx: Fix Tx doorbell shutdown path	2020-01-04 19:13:17 +01:00
mcb
md	bcache: at least try to shrink 1 node in bch_mca_scan()	2020-01-04 19:12:58 +01:00
media	media: si470x-i2c: add missed operations in remove	2019-12-31 16:35:57 +01:00
memory	memory: omap-gpmc: Get the header of the enum	2019-12-05 09:20:29 +01:00
memstick	memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()'	2019-10-29 09:20:07 +01:00
message
mfd	mfd: max8997: Enale irq-wakeup unconditionally	2019-12-01 09:16:57 +01:00
misc	altera-stapl: check for a null key before strcasecmp'ing it	2019-12-13 08:51:56 +01:00
mmc	mmc: sdhci: Add a quirk for broken command queuing	2019-12-31 16:36:36 +01:00
mtd	mtd: spear_smi: Fix Write Burst mode	2019-12-17 20:34:42 +01:00
mux
net	gtp: avoid zero size hashtable	2020-01-04 19:13:43 +01:00
nfc	NFC: nxp-nci: Fix NULL pointer dereference after I2C communication error	2019-12-13 08:51:03 +01:00
ntb	ntb: intel: fix return value for ndev_vec_mask()	2019-12-01 09:17:13 +01:00
nubus
nvdimm	libnvdimm/btt: fix variable 'rc' set but not used	2020-01-04 19:13:00 +01:00
nvme	nvme: Discard workaround for non-conformant devices	2019-12-31 16:36:01 +01:00
nvmem	nvmem: imx-ocotp: reset error status on probe	2019-12-31 16:35:37 +01:00
of	of: unittest: fix memory leak in attach_node_and_children	2019-12-17 20:36:04 +01:00
opp	OPP: Return error on error from dev_pm_opp_get_opp_count()	2019-11-24 08:20:06 +01:00
oprofile
parisc	parisc: Disable HP HSC-PCI Cards to prevent kernel crash	2019-10-05 13:10:04 +02:00
parport	parport: load lowlevel driver if ports not found	2019-12-31 16:36:01 +01:00
pci	PCI: rpaphp: Correctly match ibm, my-drc-index to drc-name when using drc-info	2020-01-04 19:12:55 +01:00
pcmcia
perf
phy	phy: qcom-usb-hs: Fix extcon double register after power cycle	2019-12-31 16:35:30 +01:00
pinctrl	pinctrl: amd: fix __iomem annotation in amd_gpio_irq_handler()	2019-12-31 16:35:35 +01:00
platform	platform/x86: hp-wmi: Make buffer for HPWMI_FEATURE2_QUERY 128 bytes	2019-12-31 16:36:25 +01:00
pnp
power	power: supply: cpcap-battery: Fix signed counter sample register	2019-12-17 20:35:37 +01:00
powercap
pps
ps3
ptp	ptp: fix the race between the release of ptp_clock and cdev	2020-01-04 19:13:35 +01:00
pwm	pwm: Clear chip_data in pwm_put()	2019-12-05 09:21:29 +01:00
rapidio
ras
regulator	regulator: max8907: Fix the usage of uninitialized variable in max8907_regulator_probe()	2019-12-31 16:34:56 +01:00
remoteproc	remoteproc: qcom: q6v5: Fix a race condition on fatal crash	2019-11-24 08:20:29 +01:00
reset	reset: Fix memory leak in reset_control_array_put()	2019-12-05 09:19:36 +01:00
rpmsg	rpmsg: glink: Free pending deferred work on remove	2019-12-21 10:57:30 +01:00
rtc	rtc: disable uie before setting time and enable after	2019-12-17 20:35:43 +01:00
s390	s390/zcrypt: handle new reply code FILTERED_BY_HYPERVISOR	2020-01-04 19:13:14 +01:00
sbus
scsi	scsi: iscsi: Don't send data to unbound connection	2020-01-04 19:13:05 +01:00
sfi
sh
siox
slimbus	slimbus: ngd: Fix build error on x86	2019-12-13 08:51:54 +01:00
sn
soc	soc: renesas: r8a77990-sysc: Fix initialization order of 3DG-{A,B}	2019-12-13 08:52:29 +01:00
soundwire	soundwire: intel: fix PDI/stream mapping for Bulk	2019-12-31 16:35:55 +01:00
spi	spi: fsl: don't map irq during probe	2020-01-04 19:13:43 +01:00
spmi
ssb
staging	staging: comedi: gsc_hpdi: check dma_alloc_coherent() return value	2019-12-31 16:36:26 +01:00
target	scsi: target: iscsi: Wait for all commands to finish before freeing a session	2020-01-04 19:13:06 +01:00
tc
tee	tee: optee: add missing of_node_put after of_device_is_available	2019-11-24 08:19:08 +01:00
thermal	thermal: Fix deadlock in thermal thermal_zone_device_check	2019-12-13 08:52:50 +01:00
thunderbolt	thunderbolt: Power cycle the router if NVM authentication fails	2019-12-05 09:21:27 +01:00
tty	vcs: prevent write access to vcsu devices	2019-12-13 08:52:51 +01:00
uio	vmbus: keep pointer to ring buffer page	2019-11-20 18:47:31 +01:00
usb	USB: EHCI: Do not return -EPIPE when hub is disconnected	2019-12-31 16:36:23 +01:00
uwb
vfio	vfio/pci: call irq_bypass_unregister_producer() before freeing irq	2019-12-21 10:57:37 +01:00
vhost	vhost/vsock: accept only packets with the right dst_cid	2020-01-04 19:13:36 +01:00
video	video/hdmi: Fix AVI bar unpack	2019-12-17 20:35:17 +01:00
virt	virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr	2019-11-06 13:06:04 +01:00
virtio	virtio-balloon: fix managed page counts when migrating pages between zones	2019-12-17 20:34:43 +01:00
visorbus
vlynq
vme
w1	w1: IAD Register is yet readable trough iad sys file. Fix snprintf (%u for unsigned, count for max size).	2019-12-01 09:16:22 +01:00
watchdog	watchdog: Fix the race between the release of watchdog_core_data and cdev	2020-01-04 19:13:01 +01:00
xen	xen/gntdev: Use select for DMA_SHARED_BUFFER	2019-12-31 16:35:50 +01:00
zorro
Kconfig
Makefile