linux-uconsole/include/uapi
Jakub Sitnicki 995f517888 bpf: Make dst_port field in struct bpf_sock 16-bit wide
[ Upstream commit 4421a58271 ]

Menglong Dong reports that the documentation for the dst_port field in
struct bpf_sock is inaccurate and confusing. From the BPF program PoV, the
field is a zero-padded 16-bit integer in network byte order. The value
appears to the BPF user as if laid out in memory as so:

  offsetof(struct bpf_sock, dst_port) + 0  <port MSB>
                                      + 8  <port LSB>
                                      +16  0x00
                                      +24  0x00

32-, 16-, and 8-bit wide loads from the field are all allowed, but only if
the offset into the field is 0.

32-bit wide loads from dst_port are especially confusing. The loaded value,
after converting to host byte order with bpf_ntohl(dst_port), contains the
port number in the upper 16-bits.

Remove the confusion by splitting the field into two 16-bit fields. For
backward compatibility, allow 32-bit wide loads from offsetof(struct
bpf_sock, dst_port).

While at it, allow loads 8-bit loads at offset [0] and [1] from dst_port.

Reported-by: Menglong Dong <imagedong@tencent.com>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/r/20220130115518.213259-2-jakub@cloudflare.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-04-13 21:00:55 +02:00
..
asm-generic aio: fix use-after-free due to missing POLLFREE handling 2021-12-14 11:32:40 +01:00
drm drm/fourcc: fix Amlogic format modifier masks 2021-03-04 11:37:38 +01:00
linux bpf: Make dst_port field in struct bpf_sock 16-bit wide 2022-04-13 21:00:55 +02:00
misc habanalabs: Add an option to map CB to device MMU 2020-09-22 18:49:54 +03:00
mtd MTD: mtd-abi.h: drop a duplicated word 2020-08-02 23:00:10 +02:00
rdma RDMA/vmw_pvrdma: Fix network_hdr_type reported in WC 2021-01-30 13:55:18 +01:00
scsi
sound ALSA: fix kernel-doc markups 2020-10-26 15:26:31 +01:00
video
xen xen/gntdev: gntdev.h: drop a duplicated word 2020-08-03 07:46:42 +02:00
Kbuild