Jiang Yi 73155507af vfio/pci: call irq_bypass_unregister_producer() before freeing irq ... commit d567fb8819 upstream. Since irq_bypass_register_producer() is called after request_irq(), we should do tear-down in reverse order: irq_bypass_unregister_producer() then free_irq(). Specifically free_irq() may release resources required by the irqbypass del_producer() callback. Notably an example provided by Marc Zyngier on arm64 with GICv4 that he indicates has the potential to wedge the hardware: free_irq(irq) __free_irq(irq) irq_domain_deactivate_irq(irq) its_irq_domain_deactivate() [unmap the VLPI from the ITS] kvm_arch_irq_bypass_del_producer(cons, prod) kvm_vgic_v4_unset_forwarding(kvm, irq, ...) its_unmap_vlpi(irq) [Unmap the VLPI from the ITS (again), remap the original LPI] Signed-off-by: Jiang Yi <giangyi@amazon.com> Cc: stable@vger.kernel.org # v4.4+ Fixes: 6d7425f109 ("vfio: Register/unregister irq_bypass_producer") Link: https://lore.kernel.org/kvm/20191127164910.15888-1-giangyi@amazon.com Reviewed-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> [aw: commit log] Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-12-21 10:57:37 +01:00
..
Kconfig	vfio/pci: Make IGD support a configurable option	2018-06-18 16:39:50 -06:00
Makefile	vfio/pci: Intel IGD OpRegion support	2016-02-22 16:10:09 -07:00
vfio_pci.c	vfio/pci: Mask buggy SR-IOV VF INTx support	2019-11-20 18:47:32 +01:00
vfio_pci_config.c	vfio/pci: Mask buggy SR-IOV VF INTx support	2019-11-20 18:47:32 +01:00
vfio_pci_igd.c	vfio/pci: Intel IGD host and LCP bridge config space access	2016-02-22 16:10:09 -07:00
vfio_pci_intrs.c	vfio/pci: call irq_bypass_unregister_producer() before freeing irq	2019-12-21 10:57:37 +01:00
vfio_pci_private.h	vfio/pci: Add ioeventfd support	2018-03-26 13:22:58 -06:00
vfio_pci_rdwr.c	vfio/pci: Add ioeventfd support	2018-03-26 13:22:58 -06:00