linux-uconsole/drivers/usb
Keiya Nobuta ecd8db9987 usb: core: hub: Improved device recognition on remote wakeup
commit 9c06ac4c83 upstream.

If hub_activate() is called before D+ has stabilized after remote
wakeup, the following situation might occur:

         __      ___________________
        /  \    /
D+   __/    \__/

Hub  _______________________________
          |  ^   ^           ^
          |  |   |           |
Host _____v__|___|___________|______
          |  |   |           |
          |  |   |           \-- Interrupt Transfer (*3)
          |  |    \-- ClearPortFeature (*2)
          |   \-- GetPortStatus (*1)
          \-- Host detects remote wakeup

- D+ goes high, Host starts running by remote wakeup
- D+ is not stable, goes low
- Host requests GetPortStatus at (*1) and gets the following hub status:
  - Current Connect Status bit is 0
  - Connect Status Change bit is 1
- D+ stabilizes, goes high
- Host requests ClearPortFeature and thus Connect Status Change bit is
  cleared at (*2)
- After waiting 100 ms, Host starts the Interrupt Transfer at (*3)
- Since the Connect Status Change bit is 0, Hub returns NAK.

In this case, port_event() is not called in hub_event() and Host cannot
recognize device. To solve this issue, flag change_bits even if only
Connect Status Change bit is 1 when got in the first GetPortStatus.

This issue occurs rarely because it only if D+ changes during a very
short time between GetPortStatus and ClearPortFeature. However, it is
fatal if it occurs in embedded system.

Signed-off-by: Keiya Nobuta <nobuta.keiya@fujitsu.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200109051448.28150-1-nobuta.keiya@fujitsu.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-23 08:21:29 +01:00
..
atm USB: atm: ueagle-atm: add missing endpoint check 2019-12-17 20:34:37 +01:00
c67x00
chipidea usb: chipidea: host: Disable port power only if previously enabled 2020-01-14 20:06:58 +01:00
class usb: usbtmc: uninitialized symbol 'actual' in usbtmc_ioctl_clear 2019-11-20 18:47:53 +01:00
common usb: common: Consider only available nodes for dr_mode 2019-04-03 06:26:27 +02:00
core usb: core: hub: Improved device recognition on remote wakeup 2020-01-23 08:21:29 +01:00
dwc2 usb: dwc2: use a longer core rest timeout in dwc2_core_reset() 2019-12-05 09:21:25 +01:00
dwc3 usb: dwc3: gadget: Fix request complete check 2020-01-12 12:17:29 +01:00
early
gadget USB: dummy-hcd: increase max number of devices to 32 2020-01-12 12:17:04 +01:00
host USB: EHCI: Do not return -EPIPE when hub is disconnected 2019-12-31 16:36:23 +01:00
image USB: microtek: fix info-leak at probe 2019-10-17 13:45:05 -07:00
isp1760 usb: isp1760: remove redundant variable 'selector' 2018-07-13 15:41:56 +02:00
misc USB: adutux: fix interface sanity check 2019-12-17 20:34:40 +01:00
mon usb: mon: Fix a deadlock in usbmon between mmap and read 2019-12-17 20:34:41 +01:00
mtu3 usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler 2019-12-13 08:52:32 +01:00
musb usb: musb: dma: Correct parameter passed to IRQ handler 2020-01-14 20:07:04 +01:00
phy usb: phy: fix link errors 2019-03-13 14:02:34 -07:00
renesas_usbhs usb: renesas_usbhs: add suspend event support in gadget mode 2019-12-31 16:34:54 +01:00
roles usb: roles: fix a potential use after free 2019-12-17 20:34:39 +01:00
serial USB: serial: quatech2: handle unbound ports 2020-01-23 08:21:28 +01:00
storage USB: uas: heed CAPACITY_HEURISTICS 2019-12-17 20:34:30 +01:00
typec usb: typec: fix use after free in typec_register_port() 2019-12-17 20:35:27 +01:00
usbip usbip: Fix error path of vhci_recv_ret_submit() 2019-12-31 16:36:21 +01:00
wusbcore
Kconfig usb: roles: Add a description for the class to Kconfig 2019-01-09 17:38:40 +01:00
Makefile
README
usb-skeleton.c USB: usb-skeleton: fix NULL-deref on disconnect 2019-10-17 13:44:50 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.