Sven Van Asbroeck 244db54441 firmware: improve LSM/IMA security behaviour ... commit 2472d64af2 upstream. The firmware loader queries if LSM/IMA permits it to load firmware via the sysfs fallback. Unfortunately, the code does the opposite: it expressly permits sysfs fw loading if security_kernel_load_data( LOADING_FIRMWARE) returns -EACCES. This happens because a zero-on-success return value is cast to a bool that's true on success. Fix the return value handling so we get the correct behaviour. Fixes: 6e852651f2 ("firmware: add call to LSM hook before firmware sysfs fallback") Cc: Stable <stable@vger.kernel.org> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com> Cc: Kees Cook <keescook@chromium.org> To: Luis Chamberlain <mcgrof@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-07-21 09:03:03 +02:00
..
fallback.c	firmware: improve LSM/IMA security behaviour	2019-07-21 09:03:03 +02:00
fallback.h	firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()	2018-05-14 16:43:09 +02:00
fallback_table.c	firmware: enable to force disable the fallback mechanism at run time	2018-03-20 09:28:47 +01:00
firmware.h	firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()	2018-05-14 16:43:09 +02:00
Kconfig	firmware_loader: move kconfig FW_LOADER entries to its own file	2018-05-14 16:43:10 +02:00
main.c	firmware: Always initialize the fw_priv list object	2018-09-30 08:49:55 -07:00
Makefile