Takashi Iwai 804536e8e0 PM / sleep: Fix request_firmware() error at resume ... commit 4320f6b1d9 upstream. The commit [247bc037: PM / Sleep: Mitigate race between the freezer and request_firmware()] introduced the finer state control, but it also leads to a new bug; for example, a bug report regarding the firmware loading of intel BT device at suspend/resume: https://bugzilla.novell.com/show_bug.cgi?id=873790 The root cause seems to be a small window between the process resume and the clear of usermodehelper lock. The request_firmware() function checks the UMH lock and gives up when it's in UMH_DISABLE state. This is for avoiding the invalid f/w loading during suspend/resume phase. The problem is, however, that usermodehelper_enable() is called at the end of thaw_processes(). Thus, a thawed process in between can kick off the f/w loader code path (in this case, via btusb_setup_intel()) even before the call of usermodehelper_enable(). Then usermodehelper_read_trylock() returns an error and request_firmware() spews WARN_ON() in the end. This oneliner patch fixes the issue just by setting to UMH_FREEZING state again before restarting tasks, so that the call of request_firmware() will be blocked until the end of this function instead of returning an error. Fixes: 247bc03742 (PM / Sleep: Mitigate race between the freezer and request_firmware()) Link: https://bugzilla.novell.com/show_bug.cgi?id=873790 Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-07-28 08:00:07 -07:00
..
autosleep.c	PM / Sleep: avoid 'autosleep' in shutdown progress	2013-07-28 16:30:21 -07:00
block_io.c	block: kill off REQ_UNPLUG	2011-03-10 08:52:27 +01:00
console.c	PM: make VT switching to the suspend console optional v3	2013-02-20 01:33:41 +01:00
hibernate.c	Power management updates for 3.6	2012-07-22 13:36:52 -07:00
Kconfig	PM / Domains: Add power off/on function for system core suspend stage	2012-09-04 01:36:01 +02:00
main.c	suspend: enable freeze timeout configuration through sys	2013-02-09 22:32:48 +01:00
Makefile	PM / Sleep: Add user space interface for manipulating wakeup sources, v3	2012-05-01 21:26:05 +02:00
power.h	PM / Hibernate: Enable suspend to both for in-kernel hibernation.	2012-07-01 13:31:22 +02:00
poweroff.c	power/sysrq: fix inconstistent help message of sysrq key	2013-04-30 17:04:10 -07:00
process.c	PM / sleep: Fix request_firmware() error at resume	2014-07-28 08:00:07 -07:00
qos.c	PM / QoS: Fix workqueue deadlock when using pm_qos_update_request_timeout()	2013-08-20 08:43:05 -07:00
snapshot.c	PM / hibernate: Avoid overflow in hibernate_preallocate_memory()	2013-12-04 10:56:58 -08:00
suspend.c	PM / sleep: invalidate TEST_CPUS and TEST_CORE support for freeze state	2013-04-05 14:18:25 +02:00
suspend_test.c	driver-core: constify data for class_find_device()	2013-02-06 12:18:56 -08:00
swap.c	PM / Hibernate: use rb_entry	2012-11-15 00:37:08 +01:00
user.c	Make wait_for_device_probe() also do scsi_complete_async_scans()	2012-07-18 18:15:46 -07:00
wakelock.c	PM / Sleep: Require CAP_BLOCK_SUSPEND to use wake_lock/wake_unlock	2012-07-19 00:00:58 +02:00