forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
linux-uconsole/drivers/bluetooth
History
Michał Mirosław 207dffe6bc Bluetooth: hci_bcm: fix freeing not-requested IRQ 
commit 81bd5d0c62 upstream.

When BT module can't be initialized, but it has an IRQ, unloading
the driver WARNs when trying to free not-yet-requested IRQ. Fix it by
noting whether the IRQ was requested.

WARNING: CPU: 2 PID: 214 at kernel/irq/devres.c:144 devm_free_irq+0x49/0x4ca
[...]
WARNING: CPU: 2 PID: 214 at kernel/irq/manage.c:1746 __free_irq+0x8b/0x27c
Trying to free already-free IRQ 264
Modules linked in: hci_uart(-) btbcm bluetooth ecdh_generic ecc libaes
CPU: 2 PID: 214 Comm: rmmod Tainted: G        W         5.6.1mq-00044-ga5f9ea098318-dirty #928
[...]
[<b016aefb>] (devm_free_irq) from [<af8ba1ff>] (bcm_close+0x97/0x118 [hci_uart])
[<af8ba1ff>] (bcm_close [hci_uart]) from [<af8b736f>] (hci_uart_unregister_device+0x33/0x3c [hci_uart])
[<af8b736f>] (hci_uart_unregister_device [hci_uart]) from [<b035930b>] (serdev_drv_remove+0x13/0x20)
[<b035930b>] (serdev_drv_remove) from [<b037093b>] (device_release_driver_internal+0x97/0x118)
[<b037093b>] (device_release_driver_internal) from [<b0370a0b>] (driver_detach+0x2f/0x58)
[<b0370a0b>] (driver_detach) from [<b036f855>] (bus_remove_driver+0x41/0x94)
[<b036f855>] (bus_remove_driver) from [<af8ba8db>] (bcm_deinit+0x1b/0x740 [hci_uart])
[<af8ba8db>] (bcm_deinit [hci_uart]) from [<af8ba86f>] (hci_uart_exit+0x13/0x30 [hci_uart])
[<af8ba86f>] (hci_uart_exit [hci_uart]) from [<b01900bd>] (sys_delete_module+0x109/0x1d0)
[<b01900bd>] (sys_delete_module) from [<b0101001>] (ret_fast_syscall+0x1/0x5a)
[...]

Cc: stable@vger.kernel.org
Fixes: 6cc4396c88 ("Bluetooth: hci_bcm: Add wake-up capability")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-22 09:05:26 +02:00
..
ath3k.c Bluetooth: ath3k: fix checkpatch warning 2018-02-07 09:46:09 +01:00
bcm203x.c Bluetooth: mark expected switch fall-throughs 2017-10-14 09:25:51 +02:00
bfusb.c bluetooth: bfusb: Replace GFP_ATOMIC with GFP_KERNEL in bfusb_send_frame() 2018-07-23 18:05:00 +02:00
bluecard_cs.c bluetooth: bluecard_cs: Replace GFP_ATOMIC with GFP_KERNEL in bluecard_hci_set_baud_rate() 2018-07-23 18:05:00 +02:00
bpa10x.c bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame() 2018-07-23 18:05:00 +02:00
bt3c_cs.c Bluetooth: Use bt_dev_err and bt_dev_info when possible 2017-10-30 12:25:45 +02:00
btbcm.c Bluetooth: btbcm: Add 2 missing models to subver tables 2020-06-22 09:05:13 +02:00
btbcm.h Bluetooth: btbcm: Allow using btbcm_initialize() for reinit 2018-05-18 06:37:51 +02:00
btintel.c Bluetooth: btintel: Create common function for firmware download 2018-01-25 09:28:40 +01:00
btintel.h Bluetooth: btintel: Create common function for firmware download 2018-01-25 09:28:40 +01:00
btmrvl_debugfs.c Bluetooth: btmrvl: Re-use kstrtol_from_user() 2018-05-30 08:16:05 +02:00
btmrvl_drv.h Bluetooth: btmrvl: support sysfs initiated firmware coredump 2018-05-29 15:59:50 +02:00
btmrvl_main.c Bluetooth: btmrvl: support sysfs initiated firmware coredump 2018-05-29 15:59:50 +02:00
btmrvl_sdio.c bluetooth: btmrvl_sdio: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_sdio_card_to_host() 2018-07-23 18:05:00 +02:00
btmrvl_sdio.h
btmtkuart.c Bluetooth: mediatek: fix up an error path to restore bdev->tx_state 2019-05-08 07:21:52 +02:00
btqca.c Bluetooth: btqca: Add a short delay before downloading the NVM 2019-09-10 10:33:43 +01:00
btqca.h Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990 2018-08-03 14:44:07 +02:00
btqcomsmd.c Bluetooth: btqcomsmd: Fix rx/tx stats 2018-05-18 06:37:50 +02:00
btrsi.c Bluetooth: btrsi: fix bt tx timeout issue 2019-11-20 18:47:42 +01:00
btrtl.c Bluetooth: btrtl: HCI reset on close for Realtek BT chip 2019-10-01 08:26:11 +02:00
btrtl.h Bluetooth: btrtl: HCI reset on close for Realtek BT chip 2019-10-01 08:26:11 +02:00
btsdio.c Bluetooth: btsdio: Do not bind to non-removable BCM43341 2017-12-13 00:28:41 +01:00
btusb.c Bluetooth: btusb: fix PM leak in error case of setup 2020-01-09 10:19:04 +01:00
btwilink.c Bluetooth: Style fix - align block comments 2017-07-22 08:39:39 +02:00
dtl1_cs.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
h4_recv.h Bluetooth: hci_uart: Check if socket buffer is ERR_PTR in h4_recv_buf() 2019-03-27 14:14:41 +09:00
hci_ag6xx.c
hci_ath.c Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_bcm.c Bluetooth: hci_bcm: fix freeing not-requested IRQ 2020-06-22 09:05:26 +02:00
hci_bcsp.c Bluetooth: Fix invalid-free in bcsp_close() 2019-12-01 09:17:35 +01:00
hci_h4.c Bluetooth: hci_uart: Check if socket buffer is ERR_PTR in h4_recv_buf() 2019-03-27 14:14:41 +09:00
hci_h5.c Bluetooth: Introduce BT_HCIUART_RTL configuration option 2018-08-09 20:48:10 +03:00
hci_intel.c Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_ldisc.c Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_ll.c Bluetooth: hci_serdev: Move serdev_device_close/open into common hci_serdev code 2018-05-30 08:47:42 +02:00
hci_mrvl.c Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_nokia.c bluetooth: hci_nokia: Don't include linux/unaligned/le_struct.h directly. 2018-06-17 08:38:55 +09:00
hci_qca.c Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_serdev.c Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races 2019-11-20 18:47:42 +01:00
hci_uart.h Bluetooth: hci_uart: check for missing tty operations 2019-08-04 09:30:55 +02:00
hci_vhci.c vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
Kconfig Bluetooth: Make BT_HCIUART_RTL configuration option depend on ACPI 2018-08-21 16:36:12 +02:00
Makefile Bluetooth: mediatek: Add protocol support for MediaTek serial devices 2018-08-07 21:33:25 +02:00