Thomas Gleixner e5d4a35afb genirq: Deal with desc->set_type() changing desc->chip ... commit 4673247562 upstream. The set_type() function can change the chip implementation when the trigger mode changes. That might result in using an non-initialized irq chip when called from __setup_irq() or when called via set_irq_type() on an already enabled irq. The set_irq_type() function should not be called on an enabled irq, but because we forgot to put a check into it, we have a bunch of users which grew the habit of doing that and it never blew up as the function is serialized via desc->lock against all users of desc->chip and they never hit the non-initialized irq chip issue. The easy fix for the __setup_irq() issue would be to move the irq_chip_set_defaults(desc->chip) call after the trigger setting to make sure that a chip change is covered. But as we have already users, which do the type setting after request_irq(), the safe fix for now is to call irq_chip_set_defaults() from __irq_set_trigger() when desc->set_type() changed the irq chip. It needs a deeper analysis whether we should refuse to change the chip on an already enabled irq, but that'd be a large scale change to fix all the existing users. So that's neither stable nor 2.6.35 material. Reported-by: Esben Haabendal <eha@doredevelopment.dk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: linuxppc-dev <linuxppc-dev@ozlabs.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>		2010-08-02 10:20:52 -07:00
..
autoprobe.c	async: Asynchronous function calls to speed up kernel boot	2009-01-07 08:45:46 -08:00
chip.c	x86: Avoid race condition in pci_enable_msix()	2010-03-15 08:50:06 -07:00
devres.c	genirq: add support for threaded interrupts to devres	2009-03-24 12:15:23 +01:00
handle.c	headers: remove sched.h from interrupt.h	2009-10-11 11:20:58 -07:00
internals.h	genirq: Add buslock support	2009-08-17 10:54:05 +02:00
Makefile	x86/irq: use move_irq_desc() in create_irq_nr()	2009-05-01 19:01:12 +02:00
manage.c	genirq: Deal with desc->set_type() changing desc->chip	2010-08-02 10:20:52 -07:00
migration.c	genirq: Delegate irq affinity setting to the irq thread	2009-07-21 14:35:07 +02:00
numa_migrate.c	x86/irq: Fix move_irq_desc() for nodes without ram	2009-08-08 17:06:03 +02:00
pm.c	genirq: Fix comment describing suspend_device_irqs()	2009-07-05 13:07:00 +02:00
proc.c	cpumask: update irq_desc to use cpumask_var_t	2009-01-11 19:12:46 +01:00
resend.c	irq: Remove superfluous NULL pointer check in check_irq_resend()	2009-08-09 12:44:29 +02:00
spurious.c	genirq: try_one_irq() must be called with irq disabled	2009-11-07 21:44:45 +01:00