909a801f21
Per the databook of designware mmc controller 2.70a, table 3-2, cmd done interrupt should be fired as soon as the the cmd is sent via cmd line. And the response timeout interrupt should be generated unconditioinally as well if the controller doesn't receive the resp. However that doesn't seem to meet the fact of rockchip specified Soc platforms using dwmmc. We have continuously found the the cmd done or response timeout interrupt missed somehow which took us a long time to understand what was happening. Finally we narrow down the root to the reconstruction of sample circuit for dwmmc IP introduced by rockchip and the buggy design sweeps over all the existing rockchip Socs using dwmmc disastrously. It seems no way to work around this bug without the proper break-out mechanism so that we seek for a parallel pair the same as the handling for missing data response timeout, namely dto timer. Adding this cto timer seems easily to handle this bug but it's hard to restrict the code under the rockchip specified context. So after merging this patch, it sets up the cto timer for all the platforms using dwmmc IP which isn't ideal but at least we don't advertise new quirk here. Fortunately, no obvious performance regression was found by test and the pre-existing similar catch-all timer for sdhci has proved it's an acceptant way to make the code as robust as possible. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196321 Signed-off-by: Addy Ke <addy.ke@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> [shawn.lin: rewrite the code and the commit msg throughout] Change-Id: I47238c9758fe74b98a1dd3939f22e569261e696f Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> (cherry picked from https://patchwork.kernel.org/patch/9834331/) |
||
|---|---|---|
| .. | ||
| boot.h | ||
| card.h | ||
| core.h | ||
| dw_mmc.h | ||
| host.h | ||
| mmc.h | ||
| pm.h | ||
| rk_mmc.h | ||
| sd.h | ||
| sdhci-pci-data.h | ||
| sdio.h | ||
| sdio_func.h | ||
| sdio_ids.h | ||
| sh_mmcif.h | ||
| sh_mobile_sdhi.h | ||
| slot-gpio.h | ||
| tmio.h | ||