Arnd Bergmann fd79e43632 mtd: avoid stack overflow in MTD CFI code ... commit fddcca5107 upstream. When map_word gets too large, we use a lot of kernel stack, and for MTD_MAP_BANK_WIDTH_32, this means we use more than the recommended 1024 bytes in a number of functions: drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_write_buffers': drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_erase_varsize': drivers/mtd/chips/cfi_cmdset_0020.c:972:1: warning: the frame size of 1208 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': drivers/mtd/chips/cfi_cmdset_0001.c:1835:1: warning: the frame size of 1240 bytes is larger than 1024 bytes [-Wframe-larger-than=] This can be avoided if all operations on the map word are done indirectly and the stack gets reused between the calls. We can mostly achieve this by selecting MTD_COMPLEX_MAPPINGS whenever MTD_MAP_BANK_WIDTH_32 is set, but for the case that no other bank width is enabled, we also need to use a non-constant map_bankwidth() to convince the compiler to use less stack. Signed-off-by: Arnd Bergmann <arnd@arndb.de> [Brian: this patch mostly achieves its goal by forcing MTD_COMPLEX_MAPPINGS (and the accompanying indirection) for 256-bit mappings; the rest of the change is mostly a wash, though it helps reduce stack size slightly. If we really care about supporting 256-bit mappings though, we should consider rewriting some of this code to avoid keeping and assigning so many 256-bit objects on the stack.] Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-05-08 07:46:01 +02:00
..
bbm.h
blktrans.h
cfi.h	mtd: cfi: deinline large functions	2015-05-27 12:42:16 -07:00
cfi_endian.h
concat.h
doc2000.h
flashchip.h
fsmc.h
ftl.h
gen_probe.h
inftl.h
latch-addr-flash.h
lpc32xx_mlc.h
lpc32xx_slc.h
map.h	mtd: avoid stack overflow in MTD CFI code	2017-05-08 07:46:01 +02:00
mtd.h	MTD updates for 3.20-rc1	2015-02-18 08:01:44 -08:00
mtdram.h
nand-gpio.h
nand.h	mtd: nand: pass page number to ecc->write_xxx() methods	2015-10-13 12:56:49 -07:00
nand_bch.h
nand_ecc.h
ndfc.h
nftl.h
onenand.h
onenand_regs.h
partitions.h
pfow.h
physmap.h
pismo.h
plat-ram.h
qinfo.h
sh_flctl.h
sharpsl.h
spear_smi.h
spi-nor.h	mtd: spi-nor: fix Spansion regressions (aliased with Winbond)	2016-01-05 16:00:03 -08:00
super.h
ubi.h	UBI: Add initial support for scatter gather	2015-01-28 16:04:26 +01:00
xip.h